gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,190 Commits 1 Branch 0 Tags
Commit Graph

9615 Commits

Author SHA1 Message Date
Oran Agra
f7bb301644 Memory leak when bind config is provided twice 2020-02-06 09:17:39 +02:00
Oran Agra
ddc1845286 A few non-data commands that should be allowed while loading or stale 
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).

MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
 2020-02-06 08:53:23 +02:00
Oran Agra
467090e45f Add handling of short read of module id in rdb 2020-02-05 19:47:09 +02:00
Oran Agra
13a7379024 update RM_SignalModifiedKey doc comment 2020-02-05 18:15:38 +02:00
Oran Agra
7d12ef55ca Optimize temporary memory allocations for getKeysFromCommand mechanism 
now that we may use it more often (ACL), these excessive calls to malloc
and free can become an overhead.
 2020-02-05 18:06:33 +02:00
Salvatore Sanfilippo
ec92713d1e Merge pull request #6831 from oranagra/config_c_refactor_3 
config.c verbose error replies for CONFIG SET, like config file parsing
 2020-02-05 13:41:15 +01:00
Oran Agra
097a0a52d6 config.c verbose error replies for CONFIG SET, like config file parsing 
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.

instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.

and also renamed the enum group functions to be consistent with the
naming of other types.
 2020-02-05 11:41:24 +02:00
Oran Agra
f7067d371b memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command 2020-02-05 09:42:49 +02:00
Guy Benoish
a0d45826a3 Add RM_CreateStringFromDouble 2020-02-04 19:28:09 +05:30
antirez
f1518f63b1 ACL LOG: make max log entries configurable. 2020-02-04 13:19:40 +01:00
antirez
debc5d4ef9 ACL LOG: log failed auth attempts. 2020-02-04 12:55:26 +01:00
lifubang
54199c93be fix ssl flag check for redis-cli 
Signed-off-by: lifubang <lifubang@acmcoder.com>
 2020-02-04 17:32:30 +08:00
Guy Benoish
2ad427f862 ld2string should fail if string contains \0 in the middle 
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.

Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
   having duplicated code here

The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
 2020-02-04 10:23:48 +01:00
Leo Murillo
5b2c6c5efa Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-04 10:23:48 +01:00
antirez
229229eb55 Add more info in the unblockClientFromModule() function. 2020-02-04 10:23:48 +01:00
WuYunlong
294b194ad4 Fix lua related memory leak. 2020-02-04 10:23:48 +01:00
Guy Benoish
d9f508d527 Modules: Fix blocked-client-related memory leak 
If a blocked module client times-out (or disconnects, unblocked
by CLIENT command, etc.) we need to call moduleUnblockClient
in order to free memory allocated by the module sub-system
and blocked-client private data

Other changes:
Made blockedonkeys.tcl tests a bit more aggressive in order
to smoke-out potential memory leaks
 2020-02-04 10:23:48 +01:00
Yossi Gottlieb
a27a4b82f4 TLS: Fix missing initialization in redis-cli. 2020-02-04 10:23:48 +01:00
Oran Agra
2ffb9a3682 fix uninitialized info_cb var in module.c 2020-02-04 10:23:48 +01:00
Salvatore Sanfilippo
32e2e7770a Merge pull request #6818 from leomurillo/zskiplistLevels 
Set ZSKIPLIST_MAXLEVEL to 32
 2020-02-04 10:20:56 +01:00
WuYunlong
85bc26f8da Fix lua related memory leak. 2020-02-04 16:38:46 +08:00
John Sully
6bb1429a46 module fixes 
Former-commit-id: ef4e11ecb8a6f1a05bb21f014120b0ef9e771b60
 2020-02-04 01:22:25 -05:00
John Sully
41f26be34a rename to pro binary 
Former-commit-id: a8854bfd83de72d6aa418ee6d9b44fae1f622787
 2020-02-04 00:30:13 -05:00
John Sully
42b3e32c8d Bump version 
Former-commit-id: ac84153f61b213d42ad503ac38948f9740a5f923
 2020-02-03 20:01:53 -05:00
John Sully
78810588e1 Merge branch 'unstable' into keydbpro 
Former-commit-id: 0db79c793e30ab268cb0f771928468e477e3b8da
 2020-02-03 20:00:16 -05:00
John Sully
771787273a Fix cluster test failures from Redis 6 merge 
Former-commit-id: fd702e43f19ac2b8097afef84a73c8e71172979b
 2020-02-03 20:00:09 -05:00
John Sully
316ac20087 Fix failure to save RDB on shutdown 
Former-commit-id: 1a8331c88a17deaa5faf34c7ea65957c57530546
 2020-02-03 16:00:01 -05:00
Salvatore Sanfilippo
a0781a2ce8 Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x 
TLS: Fix missing initialization in redis-cli.
 2020-02-03 16:43:56 +01:00
Oran Agra
f5d37082ca fix uninitialized info_cb var in module.c 2020-02-03 16:35:39 +02:00
Guy Benoish
2492bdc90b Exclude "keymiss" notification from NOTIFY_ALL 
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)

Also updated redis.conf and module.c docs
 2020-02-03 15:43:44 +05:30
John Sully
3610783851 Optimize bgsave snapshotting 
Former-commit-id: 15b4bf003537fe6fd926146f46d38203683846be
 2020-02-02 23:42:44 -05:00
John Sully
6ead122691 3 fixes, 0 array access on boot, getAsync is useless on single theaded, and don't print COW info for BG thread work since it will be inaccurate 
Former-commit-id: 09362ff44afed8525816437aead84f215eb59c36
 2020-02-02 23:30:42 -05:00
John Sully
88a148d86e RDB thread cleanup fixes 
Former-commit-id: 3e30cf6de930c40c3a1c63a761b2018836d4ae52
 2020-02-02 23:29:20 -05:00
John Sully
424981309d Handle case where src dict is larger in dictMerge 
Former-commit-id: c750fdb381f5dd3e92d251a82bd86533eb2cadf5
 2020-02-02 23:27:25 -05:00
Leo Murillo
0ab1604c0c Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-02 02:48:00 -06:00
John Sully
78da9b3af1 endSnapshotAsync implementation (fails tests w/ multithreading) 
Former-commit-id: b401e9fcae40cf1d4e4c1584f57e760d9adf36a9
 2020-02-01 22:28:24 -05:00
John Sully
cb9c7d3a80 Merge branch 'unstable' into keydbpro 
Former-commit-id: 53b36801cede2dbebbf33ec665af69f810b438d5
 2020-02-01 21:52:26 -05:00
John Sully
ae0a3e9f65 addRef memory model too restrictive 
Former-commit-id: 249e0fdd363853ab7b489314002bdacd2438fa55
 2020-02-01 21:52:17 -05:00
John Sully
40fc4eefbb use dictMerge() in endSnapshot for speed and cleaner code 
Former-commit-id: ed8e10234e4499506f2557b0858dba86c30c9dc0
 2020-02-01 21:08:26 -05:00
John Sully
2b86140abb Allow rehashing if RDB thread is active, it doesn't suffer from COW madness 
Former-commit-id: 2f1f2eaa9d160701f45eed52fc7903fcccd7656b
 2020-02-01 20:28:17 -05:00
John Sully
82cb879485 Fix spurious error messages trying to join the RDB save thread 
Former-commit-id: 775f3477655207a4df2b0b3609f3ee83d41098af
 2020-02-01 20:26:09 -05:00
John Sully
d715bc15e1 Add new faster dictionary merging for use by snapshotting code 
Former-commit-id: b6f120b3d401c92ef5cf1cc6f5e77da139e33a97
 2020-02-01 20:17:40 -05:00
John Sully
1e50be75f9 Increase trial timeout to 2 hours 
Former-commit-id: 2614f902e4292c84b9bc473c8d3a5bba9dfdbc2d
 2020-01-31 23:35:13 -05:00
John Sully
e3e64034e2 snapshot optimizations 
Former-commit-id: 642f67376a480497554f2891ebfbe7639583c6f1
 2020-01-31 17:32:48 -05:00
John Sully
9adc302858 Initialize the storage provider after daemonize 
Former-commit-id: 5910af623b024b087c69b17ec32ce351fc4d00c2
 2020-01-30 22:26:44 -05:00
John Sully
5321e425a0 build break non-TLS 
Former-commit-id: 72e455b94739625a217a664b61f4a4b7ae98f7f1
 2020-01-30 21:19:08 -05:00
John Sully
5f061c9178 Merge branch 'unstable' into keydbpro 
Former-commit-id: aca1a6605685811833729d746df85781177d5a78
 2020-01-30 21:15:42 -05:00
John Sully
8ea5d731ad RDB memory leaks 
Former-commit-id: 6208118b133c7f4209fd0a55d2a75341407e3e2c
 2020-01-30 17:57:10 -05:00
John Sully
24c9edd93b replication memory leaks 
Former-commit-id: 73020b6a939f241ade7512d58a4ddf17f5a803c5
 2020-01-30 17:56:24 -05:00
John Sully
1cfc7071f5 Fix memory leak in cron 
Former-commit-id: a9667e84ad44a3f2c08df0d95caeb6364f3f3509
 2020-01-30 17:55:48 -05:00