gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,190 Commits 1 Branch 0 Tags
Commit Graph

9615 Commits

Author SHA1 Message Date
hwware
89f5aaa4d7 fix potentical memory leaks 2020-01-16 17:33:23 -05:00
antirez
c0bdf0eb73 Change error message for #6775. 2020-01-15 17:55:24 +01:00
Salvatore Sanfilippo
b2ccea5f3c Merge pull request #6775 from SqREL/make-error-of-invalid-command-withing-context-explicit 
Make error when submitting command in incorrect context more explicit
 2020-01-15 17:53:51 +01:00
Ponnuvel Palaniyappan
9df0a501ee Fix a potential overflow with strncpy 2020-01-14 08:10:39 +00:00
antirez
aca010264c Setting N I/O threads should mean N-1 additional + 1 main thread. 2020-01-13 18:53:36 +01:00
antirez
5c5f25a9f9 Simplify #6379 changes. 2020-01-13 13:25:37 +01:00
Salvatore Sanfilippo
520a0a6b75 Merge pull request #6739 from trevor211/fixMemoryLeak 
Fix potential memory leak of rioWriteBulkStreamID().
 2020-01-13 13:23:49 +01:00
antirez
5ac23a2765 Jump to right label on AOF parsing error. 
Related to #6054.
 2020-01-13 13:16:15 +01:00
antirez
ff9e42365f Port PR #6110 to new connection object code. 2020-01-13 12:54:39 +01:00
antirez
9d6f439760 A few comments about main thread serving I/O as well. 
Related to #6110.
 2020-01-13 12:50:26 +01:00
Salvatore Sanfilippo
3875ea7671 Merge pull request #6110 from soloestoy/enhance-io-threaded 
Enhance IO Threaded: use main thread to handle read/write work
 2020-01-13 12:46:40 +01:00
John Sully
9a16678a7d Fix build break for X64 
Former-commit-id: 76590fdce3ccf7bf3124832f6034c31caf7a8269
 2020-01-12 01:28:30 -05:00
John Sully
7f74e0409f Merge branch 'keydbpro' of https://github.com/JohnSully/KeyDB-Pro into keydbpro 
Former-commit-id: 4f39ca139f15a5f585f829937a46a56f20644db0
 2020-01-12 01:27:22 -05:00
John Sully
49c2b7b77f Fix snapshot consolidation bugs and reduce log noise 
Former-commit-id: 7f3cb2981529277d3f02dceb2f60e7aa8385847d
 2020-01-12 01:22:44 -05:00
John Sully
46d5a1977e remove debug printfs 
Former-commit-id: 3dbd455321e4a2ee47a24662e164eac0e5614965
 2020-01-12 01:20:52 -05:00
John Sully
f40359cde6 Merge branch 'moar_perf' into keydbpro_moarperf 
Former-commit-id: d0990a465c3c5c29b71f239d84a875af40699281
 2020-01-11 22:06:20 -05:00
John Sully
793f0bf274 Avoid locking as late as possible 
Former-commit-id: acc894fe41d4e8869f28928cb0feffa1792c11c4
 2020-01-11 19:28:13 -05:00
John Sully
9af43f254d Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable 
Former-commit-id: 762396d997b4e155778ba62346376b37b4673154
 2020-01-11 16:35:06 -05:00
John Sully
6e096ca33e Avoid crash due to excessive posted functions for AOF rewrite 
Former-commit-id: c575e7df9408ad7bd66ac7a104a38e841d525681
 2020-01-11 16:34:30 -05:00
John Sully
b9b8272724 Avoid crash due to excessive posted functions for AOF rewrite 
Former-commit-id: aa6409f2e8a37288eb4953fbcf3a82e02545348b
 2020-01-11 16:34:09 -05:00
John Sully
18df86fcde Merge branch 'unstable' into RELEASE_5 
Former-commit-id: e603e57588d040f96876d6b281a3867a8db53f6a
 2020-01-10 17:46:23 -05:00
John Sully
18cc4b3ebe Ignore other flags after pro is enabled since we won't understand them 
Former-commit-id: 049b48ef79fdde4c9b1c9f227a329bd9223e2b1d
 2020-01-10 17:46:02 -05:00
Vasyl Melnychuk
9ea3bfdb8b Make error when submitting command in incorrect context more explicit 
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
 2020-01-10 23:34:15 +02:00
ShooterIT
4e0c2ff1d8 Rename rdb asynchronously 2020-01-10 13:16:25 +01:00
Leo Murillo
b6caf319e5 Fix bug on KEYS command where pattern starts with * followed by \x00 (null char). 2020-01-10 13:16:25 +01:00
antirez
a4f462bebb Free fakeclient argv on AOF error. 
We exit later, so no bug fixed, but it is more correct.

See #6054, thanks to @ShooterIT for finding the issue.
 2020-01-10 13:16:25 +01:00
Guy Benoish
3913ffd5bc Blocking XREAD[GROUP] should always reply with valid data (or timeout) 
This commit solves the following bug:
127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM
OK
127.0.0.1:6379> XADD x 666 f v
"666-0"
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
   2) 1) 1) "666-0"
         2) 1) "f"
            2) "v"
127.0.0.1:6379> XADD x 667 f v
"667-0"
127.0.0.1:6379> XDEL x 667
(integer) 1
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
   2) (empty array)

The root cause is that we use s->last_id in streamCompareID
while we should use the last *valid* ID
 2020-01-10 13:16:14 +01:00
John Sully
2539a8a3ce Add support for incremental build with header files 2020-01-10 13:16:14 +01:00
WuYunlong
7030e66807 Fix petential cluster link error. 
Funcion adjustOpenFilesLimit() has an implicit parameter, which is server.maxclients.
This function aims to ajust maximum file descriptor number according to server.maxclients
by best effort, which is "bestlimit" could be lower than "maxfiles" but greater than "oldlimit".
When we try to increase "maxclients" using CONFIG SET command, we could increase maximum
file descriptor number to a bigger value without calling aeResizeSetSize the same time.
When later more and more clients connect to server, the allocated fd could be bigger and bigger,
and eventually exceeds events size of aeEventLoop.events. When new nodes joins the cluster,
new link is created, together with new fd, but when calling aeCreateFileEvent, we did not
check the return value. In this case, we have a non-null "link" but the associated fd is not
registered.

So when we dynamically set "maxclients" we could reach an inconsistency between maximum file
descriptor number of the process and server.maxclients. And later could cause cluster link and link
fd inconsistency.

While setting "maxclients" dynamically, we consider it as failed when resulting "maxclients" is not
the same as expected. We try to restore back the maximum file descriptor number when we failed to set
"maxclients" to the specified value, so that server.maxclients could act as a guard as before.
 2020-01-10 13:16:14 +01:00
Yossi Gottlieb
3f8a690161 Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY. 2020-01-10 13:16:03 +01:00
hwware
86fd8f0e3f typo fix in acl.c 2020-01-10 13:16:03 +01:00
Itamar Haber
d6a6b6f40c Adjusts 'io_threads_num' max to 128 
Instead of 512, use the defined max from networking.c
 2020-01-10 13:16:03 +01:00
antirez
69a4508bee Merge branch 'unstable' of github.com:/antirez/redis into unstable 2020-01-10 13:15:36 +01:00
Salvatore Sanfilippo
eee3e28cbf Merge pull request #6114 from ShooterIT/async-rename-rdb 
Rename rdb when replica finish receiving rdb asynchronously
 2020-01-10 13:06:39 +01:00
antirez
b275416746 Free fakeclient argv on AOF error. 
We exit later, so no bug fixed, but it is more correct.

See #6054, thanks to @ShooterIT for finding the issue.
 2020-01-10 13:02:45 +01:00
Salvatore Sanfilippo
56ce6b00a6 Merge pull request #6746 from leomurillo/unstable 
Fix bug on KEYS command where pattern starts with * followed by \x00
 2020-01-10 12:18:19 +01:00
Salvatore Sanfilippo
7fc6cb4081 Merge pull request #6703 from guybe7/blocking_xread_empty_reply 
Blocking XREAD[GROUP] should always reply with valid data (or timeout)
 2020-01-09 17:32:14 +01:00
Salvatore Sanfilippo
8c0e7f7df7 Merge pull request #6724 from JohnSully/incremental 
Add support for incremental build with header files
 2020-01-09 17:10:02 +01:00
Salvatore Sanfilippo
6c1ce6b565 Merge pull request #6715 from trevor211/fixPotentialClusterLinkError 
Fix petential cluster link error.
 2020-01-09 17:05:54 +01:00
Salvatore Sanfilippo
4021f3d968 Merge pull request #6698 from yossigo/ctx-flags-multi-dirty 
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
 2020-01-08 13:09:48 +01:00
Salvatore Sanfilippo
7956f6fe6c Merge pull request #6748 from hwware/typofix 
typo fix in acl.c
 2020-01-08 13:06:06 +01:00
Salvatore Sanfilippo
3449828238 Merge pull request #6735 from itamarhaber/io-threads 
Adjusts 'io_threads_num' max in config.c
 2020-01-08 12:50:13 +01:00
antirez
4a63d5d881 XCLAIM: Create the consumer only on successful claims. 
Fixes #6744.
 2020-01-08 12:31:39 +01:00
yz1509
28622cc532 avoid sentinel changes promoted_slave to be its own replica. 2020-01-08 12:31:25 +01:00
Salvatore Sanfilippo
68b2c53f7f Merge pull request #6743 from yz1509/unstable 
Sentinel: avoid sentinel changes promoted_slave to be its own replica.
 2020-01-08 12:30:49 +01:00
antirez
4573a41249 XCLAIM: Create the consumer only on successful claims. 
Fixes #6744.
 2020-01-08 10:10:11 +01:00
hwware
2a6a01cbf2 typo fix in acl.c 2020-01-07 21:09:44 -05:00
Leo Murillo
4a1e1a8c24 Fix bug on KEYS command where pattern starts with * followed by \x00 (null char). 2020-01-07 13:55:26 -06:00
WuYunlong
fc9f1b9012 Free allocated sds in pfdebugCommand() to avoid memory leak. 2020-01-07 11:17:52 +08:00
yz1509
a127e0cc7d avoid sentinel changes promoted_slave to be its own replica. 2020-01-07 10:29:54 +08:00