John Sully
fef9925b7f
Fix higher latency at low load by grouping clients to threads. This fixes slow perf in cluster benchmarks mentioned in issue #102
...
Former-commit-id: 1a4c3224c9848f02fbdb49674045b593cfc41d31
2020-02-11 01:00:21 -05:00
John Sully
e4d74b993f
Fix cases where duplicate RREPLAY is applied
...
Former-commit-id: c3317686f8b8d94a3b2295def899ae30e208f327
2020-02-11 00:59:07 -05:00
John Sully
30ece138d5
Fix issue #119
...
Former-commit-id: 46224721237616c345f6726b721a354d7bda71df
2020-02-10 19:52:57 -05:00
John Sully
68235881e9
Fix memory leak in cron
...
Former-commit-id: f1748f8c7611ad96d7ba4fed66439cd1f043e6f3
2020-02-10 18:26:04 -05:00
antirez
c797326742
Tracking: BCAST: parsing of the options + skeleton.
2020-02-10 17:18:11 +01:00
antirez
f7dccdf3d0
Tracking: always reply with an array of keys.
2020-02-10 13:42:18 +01:00
meir@redislabs.com
054932343e
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-10 12:10:32 +02:00
John Sully
eac3cffe41
CLANG build fix
...
Former-commit-id: dc78bf1ccbd3dfd2de582d2a0d0be3223de3c7c3
2020-02-10 00:29:26 -05:00
John Sully
25ef65463e
Ensure multi-master works for ring topologies
...
Former-commit-id: a7cc3aac28ccec4dadb80aa2cc7279c53982bc28
2020-02-10 00:25:03 -05:00
John Sully
3aa271fe38
Merge branch 'unstable' into keydbpro
...
Former-commit-id: fec8209c1996112976d927d65dbc2b4492131681
2020-02-07 16:46:13 -05:00
John Sully
bf83742b4f
merge 5.0 unstable
...
Former-commit-id: c45f1328ac82fa9ebc8731314b40bd059ea45b6f
2020-02-07 16:45:59 -05:00
antirez
dcb43f4530
Tracking: minor change of names and new INFO field.
2020-02-07 18:12:45 +01:00
antirez
d5286419fc
Rax.c: populate data field after random walk.
2020-02-07 18:12:10 +01:00
antirez
ddc2a9f5ee
Tracking: rename INFO field with total items.
2020-02-07 17:19:17 +01:00
antirez
bcc9361ad4
Tracking: first conversion from hashing to key names.
2020-02-07 14:03:43 +01:00
John Sully
eabc436814
Fix issue #137 and #132
...
Former-commit-id: 050d58007f84e4f71b0ae8b053ae4d6fd5bb4ec7
2020-02-06 23:31:31 -05:00
John Sully
8800a516d1
Add test to detect issue #137 and #132
...
Former-commit-id: 49d86746edef497a568c6f3a64695d420305cca8
2020-02-06 23:31:12 -05:00
Oran Agra
0cacccddc3
add no-slowlog option to RM_CreateCommand
2020-02-06 15:06:33 +02:00
Oran Agra
19e6ef248b
add no_auth to COMMAND INFO
2020-02-06 14:53:54 +02:00
Salvatore Sanfilippo
8052340ce8
Merge pull request #6822 from guybe7/diskless_load_module_hook_fix
...
Diskless-load emptyDb-related fixes
2020-02-06 13:10:00 +01:00
Guy Benoish
b2bd353f62
Diskless-load emptyDb-related fixes
...
1. Call emptyDb even in case of diskless-load: We want modules
to get the same FLUSHDB event as disk-based replication.
2. Do not fire any module events when flushing the backups array.
3. Delete redundant call to signalFlushedDb (Called from emptyDb).
2020-02-06 16:48:02 +05:30
antirez
2700fae0b7
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-02-06 11:24:22 +01:00
antirez
3d167847aa
Merge branch 'acl-log' into unstable
2020-02-06 11:24:16 +01:00
Salvatore Sanfilippo
fedec37757
Merge pull request #6826 from lifubang/opensslcli
...
fix ssl args check for redis-cli
2020-02-06 11:22:20 +01:00
Oran Agra
f390ad6d51
RM_Scan disable dict rehashing
...
The callback approach we took is very efficient, the module can do any
filtering of keys without building any list and cloning strings, it can
also read data from the key's value. but if the user tries to re-open
the key, or any other key, this can cause dict re-hashing (dictFind does
that), and that's very bad to do from inside dictScan.
this commit protects the dict from doing any rehashing during scan, but
also warns the user not to attempt any writes or command calls from
within the callback, for fear of unexpected side effects and crashes.
2020-02-06 11:48:12 +02:00
Salvatore Sanfilippo
7d10c95786
Merge pull request #6821 from guybe7/key_miss_notify
...
Exclude "keymiss" notification from NOTIFY_ALL
2020-02-06 10:43:05 +01:00
Salvatore Sanfilippo
4bf051d4d2
Merge pull request #6837 from oranagra/signal_modified_key_doc
...
update RM_SignalModifiedKey doc comment
2020-02-06 10:38:36 +01:00
Salvatore Sanfilippo
acb1ce28bf
Merge pull request #6840 from oranagra/short_read_moduleid
...
Add handling of short read of module id in rdb
2020-02-06 10:35:42 +01:00
Salvatore Sanfilippo
f703f2ac56
Merge pull request #6843 from oranagra/command_flags
...
A few non-data commands that should be allowed while loading or stale
2020-02-06 10:34:26 +01:00
Salvatore Sanfilippo
f27243d2da
Merge pull request #6844 from oranagra/bind_config_leak
...
Memory leak when bind config is provided twice
2020-02-06 10:33:40 +01:00
Salvatore Sanfilippo
c923153ab2
Merge pull request #6845 from oranagra/maxmemory_warning
...
fix maxmemory config warning
2020-02-06 10:33:15 +01:00
Salvatore Sanfilippo
1056e09940
Merge pull request #6846 from oranagra/module_client_flags
...
Fix client flags to be int64 in module.c
2020-02-06 10:32:35 +01:00
Salvatore Sanfilippo
8211b8d5ae
Merge pull request #6847 from oranagra/module_read_err_panic
...
moduleRDBLoadError, add key name, and use panic rather than exit
2020-02-06 10:31:29 +01:00
Salvatore Sanfilippo
cdd502da4c
Merge pull request #6848 from oranagra/opt_use_diskless_load_calls
...
reduce repeated calls to use_diskless_load
2020-02-06 10:30:39 +01:00
Salvatore Sanfilippo
086f25d1a8
Merge pull request #6849 from oranagra/free_client_mutex
...
freeClientAsync don't lock mutex if there's just one thread
2020-02-06 10:29:46 +01:00
Salvatore Sanfilippo
965cc6b607
Merge pull request #6850 from oranagra/restart_aof_unset_master
...
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
2020-02-06 10:27:05 +01:00
Salvatore Sanfilippo
6a677cc2fa
Merge pull request #6851 from oranagra/aof_rewrite_scheduled
...
stopAppendOnly resets aof_rewrite_scheduled
2020-02-06 10:23:11 +01:00
Salvatore Sanfilippo
b8a57dc76e
Merge pull request #6852 from oranagra/acl_help
...
add SAVE subcommand to ACL HELP and top comment
2020-02-06 10:22:16 +01:00
Salvatore Sanfilippo
fd94ed0819
Merge pull request #6853 from oranagra/debug_help
...
DEBUG HELP - add PROTOCOL
2020-02-06 10:21:55 +01:00
Guy Benoish
2b10c2ce47
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-06 14:12:08 +05:30
Oran Agra
bc705b1b26
DEBUG HELP - add PROTOCOL
2020-02-06 10:40:29 +02:00
Guy Benoish
818b77193b
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-06 14:10:02 +05:30
Oran Agra
7e53f26984
add SAVE subcommand to ACL HELP and top comment
2020-02-06 10:31:43 +02:00
Oran Agra
a772eb89cc
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-06 10:17:34 +02:00
Oran Agra
3a74aa3ebe
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-06 10:14:32 +02:00
Oran Agra
df866ad322
freeClientAsync don't lock mutex if there's just one thread
2020-02-06 10:07:17 +02:00
Oran Agra
3ea0716cad
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-06 09:41:45 +02:00
Oran Agra
01eadbd6e1
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-06 09:37:04 +02:00
Oran Agra
4050c57139
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-06 09:33:20 +02:00
Oran Agra
e41c1824d6
fix maxmemory config warning
...
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.
other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
2020-02-06 09:23:22 +02:00