Salvatore Sanfilippo
f616ecf361
Merge pull request #6698 from yossigo/ctx-flags-multi-dirty
...
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2020-01-08 13:09:48 +01:00
Salvatore Sanfilippo
2ee4f9f34e
Merge pull request #6748 from hwware/typofix
...
typo fix in acl.c
2020-01-08 13:06:06 +01:00
Salvatore Sanfilippo
c89ec5af1e
Merge pull request #6735 from itamarhaber/io-threads
...
Adjusts 'io_threads_num' max in config.c
2020-01-08 12:50:13 +01:00
Salvatore Sanfilippo
0e38c5f39c
Merge pull request #6743 from yz1509/unstable
...
Sentinel: avoid sentinel changes promoted_slave to be its own replica.
2020-01-08 12:30:49 +01:00
antirez
7080a28efc
XCLAIM: Create the consumer only on successful claims.
...
Fixes #6744 .
2020-01-08 10:10:11 +01:00
hwware
fda2bf9c92
typo fix in acl.c
2020-01-07 21:09:44 -05:00
yz1509
18c2676084
avoid sentinel changes promoted_slave to be its own replica.
2020-01-07 10:29:54 +08:00
Itamar Haber
408e8e9f44
Adjusts 'io_threads_num' max to 128
...
Instead of 512, use the defined max from networking.c
2020-01-04 18:33:24 +02:00
antirez
0af467d18f
Fix active expire division by zero.
...
Likely fix #6723 .
This is what happens AFAIK: we enter the main loop where we expire stuff
until a given percentage of keys is still found to be logically expired.
There are however other potential exit conditions.
However the "sampled" variable is not always incremented inside the
loop, because we may found no valid slot as we scan the hash table, but
just NULLs ad dict entries. So when the do/while loop condition is
triggered at the end, we do (expired*100/sampled), dividing by zero if
we sampled 0 keys.
2020-01-01 18:13:13 +01:00
antirez
6e4f70b817
Fix duplicated CLIENT SETNAME reply.
...
Happened when we set the name to "" to cancel the name.
Was introduced during the RESP3 refactoring.
See #6036 .
2019-12-29 15:44:59 +01:00
antirez
faea46710c
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-29 15:42:08 +01:00
antirez
5521910de7
Inline protocol: handle empty strings well.
...
This bug is from the first version of Redis. Probably the problem here
is that before we used an SDS split function that created empty strings
for additional spaces, like in "SET foo bar".
AFAIK later we replaced it with the curretn sdssplitarg() API that has
no such a problem. As a result, we introduced a bug, where it is no
longer possible to do something like:
SET foo ""
Using the inline protocol. Now it is fixed.
2019-12-29 15:40:40 +01:00
Salvatore Sanfilippo
3ff95d9074
Merge pull request #6706 from guybe7/stream_id_edge_cases
...
Stream: Handle streamID-related edge cases
2019-12-29 14:53:06 +01:00
Salvatore Sanfilippo
1bae5dfff6
Merge pull request #6707 from oranagra/fix_config_limits
...
config.c adjust config limits and mutable
2019-12-29 14:51:40 +01:00
Oran Agra
0c3fe52ef7
config.c adjust config limits and mutable
...
- make lua-replicate-commands mutable (it never was, but i don't see why)
- make tcp-backlog immutable (fix a recent refactory mistake)
- increase the max limit of a few configs to match what they were before
the recent refactory
2019-12-26 15:16:15 +02:00
Guy Benoish
1f75ce30df
Stream: Handle streamID-related edge cases
...
This commit solves several edge cases that are related to
exhausting the streamID limits: We should correctly calculate
the succeeding streamID instead of blindly incrementing 'seq'
This affects both XREAD and XADD.
Other (unrelated) changes:
Reply with a better error message when trying to add an entry
to a stream that has exhausted last_id
2019-12-26 15:31:37 +05:30
Yossi Gottlieb
0c898bdb07
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2019-12-23 19:43:51 +02:00
antirez
324e22accf
Fix ip and missing mode in RM_GetClusterNodeInfo().
2019-12-20 12:29:02 +01:00
Salvatore Sanfilippo
d3a9dff6b9
Merge pull request #6615 from soloestoy/wrap-also-propagate-as-multi
...
Wrap also propagate as multi
2019-12-19 09:24:52 +01:00
Salvatore Sanfilippo
9a7b6a9f51
Merge pull request #5780 from soloestoy/lua-multi-more-clear
...
scripting: flag lua_client as CLIENT_MULTI after redis.replicate_command() immediately
2019-12-19 09:06:28 +01:00
Salvatore Sanfilippo
f4b8197060
Merge pull request #6052 from jtru/better-systemd-integration-v2
...
Better systemd integration v2
2019-12-19 08:54:22 +01:00
antirez
c5bc1c14c0
Modules: rewrite top function doc of AvoidReplicaTraffic().
2019-12-18 17:11:03 +01:00
Salvatore Sanfilippo
ef0b45ece8
Merge pull request #6497 from oranagra/avoid_replica_traffic
...
Add config and module API for AvoidReplicaTraffic
2019-12-18 17:06:05 +01:00
antirez
5a72c5058c
Fix GEOHASH negative shifting in a more compatible way.
2019-12-18 12:57:32 +01:00
antirez
e6e58e455c
Revert "Geo: output 10 chars of geohash, not 11."
...
This reverts commit 009862ab7eee394061eeaf1aa187fa339ca50be4.
2019-12-18 12:54:46 +01:00
antirez
5b9d3ac6c6
Avoid changing setKey() API after #6679 fix.
2019-12-18 11:58:02 +01:00
Salvatore Sanfilippo
9d1baa0705
Merge pull request #6679 from soloestoy/keepttl
...
Add a new SET option KEEPTTL and fix issue #5256
2019-12-18 11:52:08 +01:00
zhaozhao.zz
58554396d6
incrbyfloat: fix issue #5256 ttl lost after propagate
2019-12-18 15:44:51 +08:00
zhaozhao.zz
24044f3356
add a new SET option KEEPTTL that doesn't remove expire time
2019-12-18 15:20:36 +08:00
Salvatore Sanfilippo
b7c78b7651
Merge pull request #5916 from madolson/dev-unstable-acl-module-pr
...
Add module APIs for custom authentication
2019-12-17 09:58:26 +01:00
antirez
4348d25fc4
Add some comment to PR #6144 changes.
2019-12-17 09:19:47 +01:00
Salvatore Sanfilippo
f3d67b3842
Merge pull request #6144 from madolson/dev-unstable-cluster-down
...
Add configuration option for allowing reads on cluster down
2019-12-17 09:15:20 +01:00
Madelyn Olson
7f04a15311
Removed old auth context reference
2019-12-17 07:51:19 +00:00
Madelyn Olson
a511a37bb7
Fixed some documentation
2019-12-17 07:49:21 +00:00
Madelyn Olson
7b3e3d6a13
Resolved merge miss
2019-12-16 23:40:19 -08:00
Madelyn Olson
12caffee61
Added a missed space in lua errors
2019-12-16 23:38:31 -08:00
Madelyn Olson
576a08908b
Split error message so dependandent callers give a useful result
2019-12-16 23:34:37 -08:00
Madelyn Olson
44aa22c635
Added better exception handling around scripting and module
2019-12-16 23:33:53 -08:00
Madelyn Olson
c95a582a74
Add configuration option for allowing reads on cluster down
2019-12-16 23:33:16 -08:00
Madelyn Olson
f891b64a83
Tweaking the documentation
2019-12-17 07:28:55 +00:00
Madelyn Olson
67aa527b22
Added some documentation and fixed a test
2019-12-17 07:15:04 +00:00
Madelyn Olson
034dcf185c
Add module APIs for custom authentication
2019-12-17 06:59:59 +00:00
Salvatore Sanfilippo
e9b99c78df
Merge pull request #6649 from chaten/unstable
...
Fix outdated information on max memory policies
2019-12-16 11:25:53 +01:00
antirez
901b7469b9
Clarify change in #6662 .
2019-12-16 11:24:19 +01:00
antirez
aa3f13761f
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-16 11:18:20 +01:00
Salvatore Sanfilippo
276a093753
Merge pull request #6662 from oranagra/fix_hz_div0
...
init server.hz early to avoid div by 0 during config file loading
2019-12-16 11:18:08 +01:00
antirez
096592506e
Modules: allow to execute RM_Call() from the module init function.
2019-12-13 17:34:37 +01:00
Salvatore Sanfilippo
ba28738083
Merge pull request #6663 from yossigo/fix-replace-value
...
Improve RM_ModuleTypeReplaceValue() API.
2019-12-12 18:00:07 +01:00
Yossi Gottlieb
0283db5883
Improve RM_ModuleTypeReplaceValue() API.
...
With the previous API, a NULL return value was ambiguous and could
represent either an old value of NULL or an error condition. The new API
returns a status code and allows the old value to be returned
by-reference.
This commit also includes test coverage based on
tests/modules/datatype.c which did not exist at the time of the original
commit.
2019-12-12 18:50:11 +02:00
Oran Agra
ef6e263fde
init server.hz early to avoid div by 0 during config file loading
...
since the refactory of config.c, it was initialized from config_hz in initServer
but apparently that's too late since the config file loading creates objects
which call LRU_CLOCK
2019-12-12 17:56:02 +02:00