Salvatore Sanfilippo
d945eee8be
Merge pull request #5416 from halaei/fix-timer-selected-db
...
fix timer context selected database
2018-10-15 13:01:58 +02:00
antirez
71d6760f48
Make comment about nack->consumer test for minidle more obvious.
...
Related to #5437 .
2018-10-15 12:01:17 +02:00
antirez
b061b05d5f
Streams: use propagate_last_id itself as streamPropagateGroupID trigger.
...
Avoid storing the dirty value. See #5437 .
2018-10-15 11:52:24 +02:00
antirez
9372eddb95
Streams: better naming: lastid_updated -> propagate_last_id.
...
See #5437 but also I updated a previous usage of the same var name.
2018-10-15 11:50:18 +02:00
Salvatore Sanfilippo
f2929c1d34
Merge pull request #5437 from soloestoy/fix-xclaim
...
Fix xclaim
2018-10-15 11:47:21 +02:00
Salvatore Sanfilippo
c5c1788372
Merge pull request #5440 from scadgek/patch-1
...
fixed typos in readme
2018-10-15 11:15:24 +02:00
antirez
05b3c803f9
redis.conf typo fixed: ingore -> ignore.
2018-10-15 11:01:37 +02:00
antirez
460e951154
Rax: radix tree updated to latest version from antirez/rax.
2018-10-13 14:17:38 +02:00
antirez
ff963fade8
Test: avoid time related false positive in RESTORE test.
2018-10-13 14:17:11 +02:00
Sergey Chupov
9f32ab7e78
fixed typos in readme
2018-10-12 22:56:51 +03:00
zhaozhao.zz
cae5cb86bc
Streams: panic if streamID invalid after check, should not be possible.
2018-10-11 21:46:47 +08:00
zhaozhao.zz
df4099c0d2
Streams: propagate lastid in XCLAIM when it has effect
2018-10-11 21:44:20 +08:00
zhaozhao.zz
929e39d1f5
Streams: XCLAIM ignore minidle if NACK is created by FORCE
...
Because the NACK->consumer is NULL, if idletime < minidle
the NACK does not belong to any consumer, then redis will crash
in XPENDING.
2018-10-11 21:20:49 +08:00
zhaozhao.zz
fe8a6c4fba
Streams: bugfix XCLAIM should propagate group name not consumer name
2018-10-11 21:12:09 +08:00
antirez
5840d1fc52
LOLWUT: capitalize Nees.
2018-10-11 13:00:55 +02:00
antirez
de45608faa
Test: cgroup propagation test also for NOACK variant.
...
Related to #5433 .
2018-10-10 17:37:41 +02:00
antirez
f28775a5b5
Test: consumer group last ID slave propagation test.
...
This is a regression for #5433 .
2018-10-10 17:32:17 +02:00
antirez
110747ff92
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-10 12:51:39 +02:00
antirez
599e872fba
Fix propagation of consumer groups last ID.
...
Issue #5433 .
2018-10-10 12:51:02 +02:00
antirez
19b668de4c
changelog.tcl: get optional argument for number of commits.
2018-10-10 11:03:36 +02:00
Salvatore Sanfilippo
8c24e72c07
Merge pull request #5428 from soloestoy/client-protected
...
Avoid recreate write handler for protected client.
2018-10-09 18:02:56 +02:00
zhaozhao.zz
95d9667583
Avoid recreate write handler for protected client.
2018-10-09 20:34:11 +08:00
antirez
0c1e09100f
Free protected clients asynchronously.
...
Related to #4840 .
Note that when we re-enter the event loop with aeProcessEvents() we
don't process timers, nor before/after sleep callbacks, so we should
never end calling freeClientsInAsyncFreeQueue() when re-entering the
loop.
2018-10-09 13:28:51 +02:00
antirez
1624139e91
Actually use the protectClient() API where needed.
...
Related to #4804 .
2018-10-09 13:18:52 +02:00
antirez
25119c7069
Introduce protectClient() + some refactoring.
...
The idea is to have an API for the cases like -BUSY state and DEBUG
RELOAD where we have to manually deinstall the read handler.
See #4804 .
2018-10-09 13:15:41 +02:00
Salvatore Sanfilippo
fae1ef5ded
Merge pull request #4804 from soloestoy/fix-debug-load
...
debug: avoid free client unexpectedly when reload & loadaof
2018-10-09 12:56:08 +02:00
antirez
0d151aa3af
aof.c: improve indentation and change warning message.
...
Related to #5201 .
I removed the !!! Warning part since compared to the other errors, a
missing EXEC is in theory a normal happening in the AOF file, at least
in theory: may happen in a differnet number of situations, and it's
probably better to don't give the user the feeling that something really
bad happened.
2018-10-09 11:51:04 +02:00
Salvatore Sanfilippo
8ce4a9b366
Merge pull request #5201 from soloestoy/abort-if-lost-exec-aof-load
...
AOF: discard if we lost EXEC when loading aof
2018-10-09 11:47:04 +02:00
antirez
65598e3f22
Refactoring of XADD / XTRIM MAXLEN rewriting.
...
See #5141 .
2018-10-08 12:05:22 +02:00
Salvatore Sanfilippo
f654899b7f
Merge pull request #5141 from soloestoy/fix-xtrim-inconsistency
...
Fix XTRIM and XADD with MAXLEN inconsistency
2018-10-08 12:00:00 +02:00
Salvatore Sanfilippo
0b0241012c
Merge pull request #5422 from ziyasal/patch-1
...
Fix typo in the comment of raxSeekGreatest function
2018-10-08 11:34:42 +02:00
O(ʒ)
ec7f1a0fe4
Fix typo
2018-10-07 13:37:58 +02:00
antirez
32ebb1d7d2
Fix typo in replicationCron() comment.
2018-10-05 18:30:45 +02:00
antirez
d4d448d43e
Fix typo in design comment of bio.c.
2018-10-05 18:29:23 +02:00
antirez
511e94cabf
xclaimCommand(): fix comment typos.
2018-10-04 17:34:06 +02:00
Hamid Alaei
a2ddb585ec
fix timer context selected database
2018-10-04 17:02:10 +03:30
antirez
de25d81b21
streamAppendItem(): Update the radix tree pointer only if changed.
2018-10-02 19:45:33 +02:00
antirez
e36d334579
Listpack: optionally force reallocation on inserts.
...
This is useful in order to spot bugs where we fail
at updating the pointer returned by the insertion
function. Normally often the same pointer is returned,
making it harder than needed to spot bugs.
Related to #5210 .
2018-10-02 19:37:36 +02:00
antirez
ec656a2071
Fix printf type mismatch in genRedisInfoString().
2018-10-02 16:26:30 +02:00
antirez
9179b87231
streamIteratorRemoveEntry(): set back lp only if pointer changed.
...
Most of the times the pointer will remain the same since integers of
similar size don't take more space in listpacks.
Related to #5210 .
2018-10-02 16:20:40 +02:00
Salvatore Sanfilippo
132e115d29
Merge pull request #5210 from soloestoy/raxinsert-in-xdel
...
Streams: update listpack with new pointer in XDEL
2018-10-02 16:18:55 +02:00
Salvatore Sanfilippo
f09c0fdc4e
Merge pull request #5392 from soloestoy/bugfix-brpoplpush
...
bugfix: replace lastcmd with cmd when rewrite BRPOPLPUSH as RPOPLPUSH
2018-10-02 16:09:22 +02:00
Salvatore Sanfilippo
96b51145a3
Merge pull request #5242 from oranagra/script_mem
...
script cache memory in INFO and MEMORY includes both script code and overheads
2018-10-02 16:03:05 +02:00
Salvatore Sanfilippo
895fefcea4
Merge pull request #5397 from bmerry/fix-bad-zmalloc-size
...
Fix invalid use of sdsZmallocSize on an embedded string
2018-10-01 13:30:42 +02:00
Salvatore Sanfilippo
bcb7c04e40
Merge pull request #5398 from bmerry/fix-zrealloc-accounting
...
Fix incorrect memory usage accounting in zrealloc
2018-10-01 13:28:53 +02:00
Salvatore Sanfilippo
2a7093e1d0
Merge pull request #5396 from oranagra/cmdstats_exec
...
fix #5024 - commandstats for multi-exec were logged as EXEC.
2018-10-01 13:24:49 +02:00
Salvatore Sanfilippo
86f5c8a98d
Merge pull request #5400 from halaei/fix-dict-get-on-not-found
...
fix dict get on not found
2018-10-01 13:22:33 +02:00
Hamid Alaei
168f8b7ef6
fix dict get on not found
2018-10-01 13:57:25 +03:30
antirez
241e2e938d
Fix XINFO comment for consistency.
2018-10-01 11:38:58 +02:00
Bruce Merry
a2b68c02de
Fix incorrect memory usage accounting in zrealloc
...
When HAVE_MALLOC_SIZE is false, each call to zrealloc causes used_memory
to increase by PREFIX_SIZE more than it should, due to mis-matched
accounting between the original zmalloc (which includes PREFIX size in
its increment) and zrealloc (which misses it from its decrement).
I've also supplied a command-line test to easily demonstrate the
problem. It's not wired into the test framework, because I don't know
TCL so I'm not sure how to automate it.
2018-09-30 11:49:03 +02:00