Salvatore Sanfilippo
cdd502da4c
Merge pull request #6848 from oranagra/opt_use_diskless_load_calls
...
reduce repeated calls to use_diskless_load
2020-02-06 10:30:39 +01:00
Salvatore Sanfilippo
086f25d1a8
Merge pull request #6849 from oranagra/free_client_mutex
...
freeClientAsync don't lock mutex if there's just one thread
2020-02-06 10:29:46 +01:00
Salvatore Sanfilippo
965cc6b607
Merge pull request #6850 from oranagra/restart_aof_unset_master
...
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
2020-02-06 10:27:05 +01:00
Salvatore Sanfilippo
6a677cc2fa
Merge pull request #6851 from oranagra/aof_rewrite_scheduled
...
stopAppendOnly resets aof_rewrite_scheduled
2020-02-06 10:23:11 +01:00
Salvatore Sanfilippo
b8a57dc76e
Merge pull request #6852 from oranagra/acl_help
...
add SAVE subcommand to ACL HELP and top comment
2020-02-06 10:22:16 +01:00
Salvatore Sanfilippo
fd94ed0819
Merge pull request #6853 from oranagra/debug_help
...
DEBUG HELP - add PROTOCOL
2020-02-06 10:21:55 +01:00
Salvatore Sanfilippo
df9ca7d05a
Merge pull request #6854 from guybe7/mem_overhead_miscalc
...
Fix small bugs related to replica and monitor ambiguity
2020-02-06 10:21:30 +01:00
Guy Benoish
2b10c2ce47
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-06 14:12:08 +05:30
Oran Agra
bc705b1b26
DEBUG HELP - add PROTOCOL
2020-02-06 10:40:29 +02:00
Guy Benoish
818b77193b
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-06 14:10:02 +05:30
Oran Agra
7e53f26984
add SAVE subcommand to ACL HELP and top comment
2020-02-06 10:31:43 +02:00
Oran Agra
a772eb89cc
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-06 10:17:34 +02:00
Oran Agra
3a74aa3ebe
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-06 10:14:32 +02:00
Oran Agra
df866ad322
freeClientAsync don't lock mutex if there's just one thread
2020-02-06 10:07:17 +02:00
Oran Agra
3ea0716cad
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-06 09:41:45 +02:00
Salvatore Sanfilippo
9d016c0084
Merge pull request #6839 from yossigo/fix/redis-conf-tls-clarifications
...
TLS: Some redis.conf clarifications.
2020-02-05 17:33:21 +01:00
Yossi Gottlieb
f4c7f1ac27
TLS: Some redis.conf clarifications.
2020-02-05 18:30:12 +02:00
Salvatore Sanfilippo
ec92713d1e
Merge pull request #6831 from oranagra/config_c_refactor_3
...
config.c verbose error replies for CONFIG SET, like config file parsing
2020-02-05 13:41:15 +01:00
Salvatore Sanfilippo
823d8e6a8b
Merge pull request #6829 from oranagra/memory_get_keys
...
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-05 13:33:18 +01:00
Oran Agra
097a0a52d6
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-05 11:41:24 +02:00
Oran Agra
f7067d371b
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-05 09:42:49 +02:00
Salvatore Sanfilippo
32e2e7770a
Merge pull request #6818 from leomurillo/zskiplistLevels
...
Set ZSKIPLIST_MAXLEVEL to 32
2020-02-04 10:20:56 +01:00
Salvatore Sanfilippo
2659773a0b
Merge pull request #6825 from trevor211/fixMemoryLeakAboutLuaScript
...
Fix memory leak about lua script
2020-02-04 10:19:16 +01:00
WuYunlong
85bc26f8da
Fix lua related memory leak.
2020-02-04 16:38:46 +08:00
WuYunlong
c0c29adce9
Add tcl regression test in scripting.tcl to reproduce memory leak.
2020-02-04 16:34:11 +08:00
Salvatore Sanfilippo
a0781a2ce8
Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x
...
TLS: Fix missing initialization in redis-cli.
2020-02-03 16:43:56 +01:00
Salvatore Sanfilippo
bac311851e
Merge pull request #6824 from oranagra/fix_module_c_uninit_var
...
fix uninitialized info_cb var in module.c
2020-02-03 15:46:13 +01:00
Oran Agra
f5d37082ca
fix uninitialized info_cb var in module.c
2020-02-03 16:35:39 +02:00
Leo Murillo
0ab1604c0c
Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25
2020-02-02 02:48:00 -06:00
Salvatore Sanfilippo
541a667c77
Merge pull request #6812 from guybe7/str_convert_fix
...
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
Guy Benoish
3fd717daee
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
Yossi Gottlieb
a7420b2478
TLS: Fix missing initialization in redis-cli.
2020-01-29 21:40:02 +02:00
antirez
2ed300b786
Add more info in the unblockClientFromModule() function.
2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo
d0bb1e572f
Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
...
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
antirez
c0bdf0eb73
Change error message for #6775 .
2020-01-15 17:55:24 +01:00
Salvatore Sanfilippo
b2ccea5f3c
Merge pull request #6775 from SqREL/make-error-of-invalid-command-withing-context-explicit
...
Make error when submitting command in incorrect context more explicit
2020-01-15 17:53:51 +01:00
antirez
4b1de05757
Document I/O threads in redis.conf.
2020-01-13 19:10:42 +01:00
antirez
aca010264c
Setting N I/O threads should mean N-1 additional + 1 main thread.
2020-01-13 18:53:36 +01:00
antirez
5c5f25a9f9
Simplify #6379 changes.
2020-01-13 13:25:37 +01:00
Salvatore Sanfilippo
520a0a6b75
Merge pull request #6739 from trevor211/fixMemoryLeak
...
Fix potential memory leak of rioWriteBulkStreamID().
2020-01-13 13:23:49 +01:00
antirez
5ac23a2765
Jump to right label on AOF parsing error.
...
Related to #6054 .
2020-01-13 13:16:15 +01:00
antirez
ff9e42365f
Port PR #6110 to new connection object code.
2020-01-13 12:54:39 +01:00
antirez
9d6f439760
A few comments about main thread serving I/O as well.
...
Related to #6110 .
2020-01-13 12:50:26 +01:00
Salvatore Sanfilippo
3875ea7671
Merge pull request #6110 from soloestoy/enhance-io-threaded
...
Enhance IO Threaded: use main thread to handle read/write work
2020-01-13 12:46:40 +01:00
Vasyl Melnychuk
9ea3bfdb8b
Make error when submitting command in incorrect context more explicit
...
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
2020-01-10 23:34:15 +02:00
antirez
69a4508bee
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-01-10 13:15:36 +01:00
Salvatore Sanfilippo
eee3e28cbf
Merge pull request #6114 from ShooterIT/async-rename-rdb
...
Rename rdb when replica finish receiving rdb asynchronously
2020-01-10 13:06:39 +01:00
antirez
b275416746
Free fakeclient argv on AOF error.
...
We exit later, so no bug fixed, but it is more correct.
See #6054 , thanks to @ShooterIT for finding the issue.
2020-01-10 13:02:45 +01:00
antirez
c8decc87e8
Git ignore: ignore more files.
2020-01-10 12:22:16 +01:00
Salvatore Sanfilippo
56ce6b00a6
Merge pull request #6746 from leomurillo/unstable
...
Fix bug on KEYS command where pattern starts with * followed by \x00
2020-01-10 12:18:19 +01:00