12926 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Григорий Сафронов	9d6053c00f	Delete src/modules/hellodict.c	2025-02-15 15:55:30 +00:00
Григорий Сафронов	9b9baca82c	Delete src/modules/Makefile	2025-02-15 15:55:21 +00:00
Григорий Сафронов	315bc059be	Delete src/modules/helloblock.c	2025-02-15 15:54:55 +00:00
Григорий Сафронов	4cf16b5249	Delete src/modules/helloacl.c	2025-02-15 15:54:40 +00:00
Григорий Сафронов	fe3c1c34b0	Delete valkey.conf	2025-02-13 19:39:37 +00:00
Григорий Сафронов	5979980595	Upload files to "/"	2025-02-13 19:38:56 +00:00
Григорий Сафронов	7317466c05	Update src/rdb.c	2025-02-10 20:30:08 +00:00
Григорий Сафронов	18e232f0e5	Upload files to "/"	2025-02-03 20:02:39 +00:00
Григорий Сафронов	a5601ba85a	Delete cluster	2025-02-03 20:01:27 +00:00
Григорий Сафронов	7eaad5782b	Delete utils/create-cluster/create-cluster	2025-02-03 20:01:10 +00:00
Григорий Сафронов	5cba04d02c	Delete utils/create-cluster/.gitignore	2025-02-03 20:01:01 +00:00
Григорий Сафронов	e9a66d0ae0	Delete utils/create-cluster/README	2025-02-03 20:00:51 +00:00
Григорий Сафронов	e6ad354b20	Update README.md	2025-02-03 18:47:46 +00:00
Григорий Сафронов	be5f5e18e0	Update README.md	2025-02-03 18:42:56 +00:00
Григорий Сафронов	0865036a8d	Update COPYING	2025-02-03 18:41:48 +00:00
Григорий Сафронов	e6f6239b05	Delete 00-RELEASENOTES	2025-02-03 18:40:23 +00:00
Григорий Сафронов	3667aefcd7	Upload files to "src"	2025-02-03 18:39:44 +00:00
Григорий Сафронов	0f15725225	Delete src/server.c	2025-02-03 18:38:56 +00:00
Григорий Сафронов	feb27073ca	Upload files to "src"	2025-02-03 18:38:34 +00:00
Григорий Сафронов	3a40802dfe	Delete src/valkey-cli.c	2025-02-03 18:38:16 +00:00
Григорий Сафронов	28a627c170	Upload files to "src"	2025-02-03 17:34:11 +00:00
Григорий Сафронов	f9d25adab9	Upload files to "src"	2025-02-03 17:32:27 +00:00
Григорий Сафронов	410738342c	Upload files to "src"	2025-02-03 17:32:06 +00:00
Григорий Сафронов	da64d5a94f	Delete src/config.c	2025-02-03 16:55:31 +00:00
Григорий Сафронов	f8730df47f	Delete src/asciilogo.h	2025-02-03 16:55:10 +00:00
Григорий Сафронов	2bd092bcb8	Delete src/valkey-cli.c	2025-02-03 16:54:47 +00:00
Григорий Сафронов	2ccd70a257	Delete src/server.c	2025-02-03 16:53:07 +00:00
Григорий Сафронов	a4f2c53f46	Update README.md	2025-02-02 22:06:37 +00:00
Григорий Сафронов	916e917d50	Upload files to "/"	2025-02-02 21:52:21 +00:00
Григорий Сафронов	9982efe26d	Upload files to "/"	2025-02-02 21:51:12 +00:00
Григорий Сафронов	2cae0b1910	Update README.md	2025-02-02 21:50:41 +00:00
Григорий Сафронов	5664f394c0	Upload files to "src"	2025-02-02 21:47:42 +00:00
Григорий Сафронов	2ba8847b6d	Delete src/Makefile	2025-02-02 21:46:38 +00:00
烈香	26c6f1af9b	Loop optimization: move maxlen check outside to reduce unnecessary checks (#1557) ... A trival pr, move maxlen check outside to reduce unnecessary ecks --------- Signed-off-by: hengyouhai <hengyouhai@tuhu.cn> Signed-off-by: 烈香 <hengyoush1@163.com> Co-authored-by: hengyouhai <hengyouhai@tuhu.cn>	2025-02-01 05:10:32 -08:00
Harkrishn Patro	78bcc0a2cf	Update daily failure notification job list (#1648) ... Two jobs were missing from the job list for failure notification * test-ubuntu-tls-io-threads * test-sanitizer-force-defrag Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>	2025-01-30 15:21:31 -08:00
Viktor Söderqvist	12ec3d5932	Increase timeout for cross-version-replication test (#1644) ... Fixes #1641 Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>	2025-01-29 13:29:35 -08:00
Madelyn Olson	d3aabd7f13	Hex encode the data in dump test (#1637) ... Addresses the failure here: https://github.com/valkey-io/valkey/actions/runs/13000845302/job/36259016156#step:5:7272. This change does three things: 1. For some reason TCL 8.5 (which is used on macos) is handling `\x03ba` as `\0xba`, according to https://www.tcl-lang.org/man/tcl8.5/TclCmd/Tcl.htm#M27 so we encode "bar" using hex escapes too. 2. Fix a spacing issue. 3. Make it so that if the restore fails, it immediately errors. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>	2025-01-29 16:20:38 -05:00
xingbowang	ff8a528fd6	Fix a heap-use-after-free bug in cluster bus (#1643) ... https://github.com/valkey-io/valkey/issues/1642 Avoid heap-use-after-free in cluster bus around node cleanup code. freeClusterNode free the human_nodename. https://github.com/valkey-io/valkey/blob/unstable/src/cluster_legacy.c#L1725 Then it calls freeClusterLink to free the links. https://github.com/valkey-io/valkey/blob/unstable/src/cluster_legacy.c#L1730 freeClusterLink print human_nodename here, which just got freed by the caller freeClusterNode. https://github.com/valkey-io/valkey/blob/unstable/src/cluster_legacy.c#L1383 Signed-off-by: xingbowang <shawn.xingbo.wang@gmail.com>	2025-01-29 13:13:40 -08:00
Binbin	4b8f3ed9ac	Do command existence and arity checks when loading AOF to avoid crash (#1614) ... Do command existence and arity checks when loading AOF to avoid crash Currently, loading commands such as `cluster` or `cluster slots xxx` from AOF will cause the server to crash. 1. `cluster` is a container command, and executing proc will cause a crash because we do not check subcommand and arity. 2. `cluster slots xxx`, arity check fail, reply with an error from the AOF client and trigger a panic. Of course, there are many other ways for a problematic AOF to cause the panic, but it is still necessary do some basic checks before executing. In this way, in these basic cases, we can print useful error messages instead of crashing directly. Signed-off-by: Binbin <binloveplay1314@qq.com>	2025-01-30 01:06:13 +08:00
zhenwei pi	d72a97edf6	RDMA: Protect RDMA memory regions (#1602) ... Use Linux syscall mmap/munmap to manage a RDMA memory region, then we have a guard page protected VMA like (cat /proc/PID/maps): 785018afe000-785018aff000 ---p 00000000 00:00 0 -> top guard page 785018aff000-785018bff000 rw-p 00000000 00:00 0 -> RDMA memory region 785018bff000-785018c00000 ---p 00000000 00:00 0 -> bottom guard page Once any code accesses memory unexpectedly, segment fault occurs. Signed-off-by: zhenwei pi <zhenwei.pi@linux.dev> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>	2025-01-28 12:22:16 -05:00
Wen Hui	ad60d6b7b3	Initialize one variable in struct to avoid risk (#1606) ... In C, we had better initialize every variable in struct, this PR fixes one missed variable Initialization. --------- Signed-off-by: hwware <wen.hui.ware@gmail.com>	2025-01-28 11:37:41 -05:00
Madelyn Olson	f695c52acb	Fix timing issue in pause test (#1631)	2025-01-28 06:35:24 -08:00
ranshid	230efa4fbf	deflake tracking-redir-broken test (#1628) ... This address 2 issues: 1. It is possible (somehow) that the inner server client (r) was not working resp 3 when entering this test. this makes sure it does. 2. in case the test failed it might leave the redirection client closed. there is a cross test assumption it should be open, so moved most of the assert checks to the end of the test. example fail: https://github.com/valkey-io/valkey/actions/runs/12979601179/job/36195523412 --------- Signed-off-by: Ran Shidlansik <ranshid@amazon.com>	2025-01-28 12:35:32 +02:00
Viktor Söderqvist	e9b8970e72	Relaxed RDB version check (#1604) ... New config `rdb-version-check` with values: * `strict`: Reject future RDB versions. * `relaxed`: Try parsing future RDB versions and fail only when an unknown RDB opcode or type is encountered. This can make it possible for Valkey 8.1 to try read a dump from for example Valkey 9.0 or later on a best-effort basis. The conditions for when this is expected to work can be defined when the future Valkey versions are released. Loading is expected to fail in the following cases: * If the data set contains any new key types or other data elements not supported by the current version. * If the RDB contains new representations or encodings of existing key types or other data elements. This change also prepares for the next RDB version bump. A range of RDB versions (12-79) is reserved, since it's expected to be used by foreign software RDB versions, so Valkey will not accept versions in this range even with the `relaxed` version check. The DUMP/RESTORE format has no magic string; only the RDB version number. This change also prepares for the magic string to change from REDIS to VALKEY next time we bump the RDB version. Related to #1108. --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>	2025-01-27 18:44:24 +01:00
Viktor Söderqvist	7699a3a94a	Fix use-after-free in hashtableTwoPhasePopDelete (#1626) ... Use-after-free has been detect by address sanitizer, such as in this test run: https://github.com/valkey-io/valkey/actions/runs/12981530413/job/36200075972?pr=1620#step:5:1339 `hashtableShrinkIfNeeded` may free one of the hash tables and invalidate the variables used by the `fillBucketHole(ht, b, pos_in_bucket, table_index)` just after, causing use-after-free. Fill bucket hole first and shrink afterwards is assumed to solve the issue. (Not reproduced locally.) Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>	2025-01-27 15:45:09 +01:00
Madelyn Olson	88a68303c0	Make sure to disable pause after fork for dual channel test (#1612) ... Might close https://github.com/valkey-io/valkey/issues/1484. I noticed that we don't disable pause after fork on the last test that was getting executed, so it might getting stuck in pause loops after the test ends if it tries another psync for any reason. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>	2025-01-27 06:44:48 -08:00
Viktor Söderqvist	a18fcdb371	Deflake hashtable random fairness test (#1618) ... Fixes the unit test for hashtable random fairness intermittent failures when running with the `--accurate` flag. https://github.com/valkey-io/valkey/actions/runs/12969591890/job/36173815884#step:10:105 The test case picks a random element out of 400, repeated 1M times, and then checks that 60% of the elements are picked within 3 standard deviations from the number of times they're expected to be picked. In this test run (with `--accurate`), the expected number is 2500 and the standard deviation is 50, which is only 2% of the expected value. This makes the check too strict and makes the test flaky. As an alternative, we allow 80% of the elements to be picked within 10% of the expected number. With this alternative condition, we can also raise the check for the non-edge case from 60% to 80% of the elements to be within 3 standard deviations. (With fewer repetitions, 3 standard deviations is greater than 10% of the expected value, so this new condition only affects the `--accurate` test run.) Additional change: Set a random seed to the hash function in the test suite. Until now, we only seeded the random number generator. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>	2025-01-27 10:13:46 +01:00
Viktor Söderqvist	66577573f2	Test coverage for COMMANDLOG HELP (#1617) ... Fixes reply-schema-validator test job which needs coverage for all commands. Failing job: https://github.com/valkey-io/valkey/actions/runs/12969591890/job/36173810824 Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>	2025-01-27 04:38:54 +01:00
Harkrishn Patro	9071a5c8e6	Set GH actions job timeout to a day (#1540) ... Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>	2025-01-24 10:47:10 -08:00
zhaozhao.zz	3f21705a6c	Feature COMMANDLOG to record slow execution and large request/reply (#1294) ... As discussed in PR #336. We have different types of resources like CPU, memory, network, etc. The `slowlog` can only record commands eat lots of CPU during the processing phase (doesn't include read/write network time), but can not record commands eat too many memory and network. For example: 1. run "SET key value(10 megabytes)" command would not be recored in slowlog, since when processing it the SET command only insert the value's pointer into db dict. But that command eats huge memory in query buffer and bandwidth from network. In this case, just 1000 tps can cause 10GB/s network flow. 2. run "GET key" command and the key's value length is 10 megabytes. The get command can eat huge memory in output buffer and bandwidth to network. This PR introduces a new command `COMMANDLOG`, to log commands that consume significant network bandwidth, including both input and output. Users can retrieve the results using `COMMANDLOG get <count> large-request` and `COMMANDLOG get <count> large-reply`, all subcommands for `COMMANDLOG` are: * `COMMANDLOG HELP` * `COMMANDLOG GET <count> <slow|large-request|large-reply>` * `COMMANDLOG LEN <slow|large-request|large-reply>` * `COMMANDLOG RESET <slow|large-request|large-reply>` And the slowlog is also incorporated into the commandlog. For each of these three types, additional configs have been added for control: * `commandlog-request-larger-than` and `commandlog-large-request-max-len` represent the threshold for large requests(the unit is Bytes) and the maximum number of commands that can be recorded. * `commandlog-reply-larger-than` and `commandlog-large-reply-max-len` represent the threshold for large replies(the unit is Bytes) and the maximum number of commands that can be recorded. * `commandlog-execution-slower-than` and `commandlog-slow-execution-max-len` represent the threshold for slow executions(the unit is microseconds) and the maximum number of commands that can be recorded. * Additionally, `slowlog-log-slower-than` and `slowlog-max-len` are now set as aliases for these two new configs. --------- Signed-off-by: zhaozhao.zz <zhaozhao.zz@alibaba-inc.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Ping Xie <pingxie@outlook.com>	2025-01-24 11:41:40 +08:00