antirez
605ba6ad38
redis-trib: fixed slot allocation when --replicas is used.
2013-11-07 16:12:06 +01:00
antirez
9982e0aaa3
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2013-11-06 11:30:44 +01:00
antirez
b64dbf7387
Sentinel: sentinelSendSlaveOf() was missing a var and the prototype.
2013-11-06 11:23:53 +01:00
antirez
3be2b18d9f
Sentinel: increment pending_commands counter in two more places.
...
AUTH and SCRIPT KILL were sent without incrementing the pending commands
counter. Clearly this needs some kind of wrapper doing it for the caller
in order to be less bug prone.
2013-11-06 11:21:44 +01:00
antirez
1071abc4a4
Sentinel: always send CONFIG REWRITE when changing instance role.
...
This change makes Sentinel less fragile about a number of failure modes.
This commit also fixes a different bug as a side effect, SLAVEOF command
was sent multiple times without incrementing the pending commands count.
2013-11-06 11:13:27 +01:00
Salvatore Sanfilippo
789eb2cff3
Merge pull request #1365 from yaauie/deprecate-redis-copy-script
...
Deprecate utils/redis-copy.rb in favor of redis-copy gem
2013-11-06 00:42:03 -08:00
Ryan Biesemeyer
58efb01204
Deprecate utils/redis-copy.rb in favor of redis-copy gem
2013-11-06 08:31:57 +00:00
antirez
6e98e93c5f
Fixed typo in parseScanCursorOrReply(): ad -> at.
...
Thanks to @badboy for reporting it.
2013-11-05 17:23:11 +01:00
antirez
1a1eb8bc8d
SCAN code refactored to parse cursor first.
...
The previous implementation of SCAN parsed the cursor in the generic
function implementing SCAN, SSCAN, HSCAN and ZSCAN.
The actual higher-level command implementation only checked for empty
keys and return ASAP in that case. The result was that inverting the
arguments of, for instance, SSCAN for example and write:
SSCAN 0 key
Instead of
SSCAN key 0
Resulted into no error, since 0 is a non-existing key name very likely.
Just the iterator returned no elements at all.
In order to fix this issue the code was refactored to extract the
function to parse the cursor and return the error. Every higher level
command implementation now parses the cursor and later checks if the key
exist or not.
2013-11-05 15:47:50 +01:00
antirez
f31cf249b9
SCAN: when iterating ziplists or intsets always return cursor of 0.
...
The previous implementation assumed that the first call always happens
with cursor set to 0, this may not be the case, and we want to return 0
anyway otherwise the (broken) client code will loop forever.
2013-11-05 15:32:25 +01:00
antirez
b97cff8b63
Use strtoul() instead of sscanf() in SCAN implementation.
2013-11-05 15:30:21 +01:00
antirez
7dfcfe47b6
Added tests for [SHZ]SCAN with MATCH.
2013-11-05 15:19:44 +01:00
antirez
56f53f7b3c
HSCAN/ZSCAN: skip value when matching.
...
This fixes issue #1360 and #1362 .
2013-11-05 12:16:29 +01:00
antirez
f6738923a6
Cluster: initialize senderConfigEpoch and senderCurrentEpoch for warnings suppression.
2013-11-05 12:01:07 +01:00
antirez
522549729f
Pass int64_t to intsetGet() instead of long long.
2013-11-05 11:57:30 +01:00
antirez
865d3b0f33
removed not used vars in dictScan().
2013-11-05 11:56:11 +01:00
antirez
e1a469d3b0
Initial support for --replicas in redis-trib.
2013-11-05 11:24:24 +01:00
antirez
adcc1fc04d
SSCAN with integer encoded object test improved.
2013-10-31 10:37:27 +01:00
antirez
653347d253
Inverted variable boolean value and name after scanGenericCommand() refactoring.
2013-10-31 10:35:56 +01:00
antirez
34e471e748
scanGenericCommand() refactoring and handling of integer encoded elements.
...
This commit fixes issue #1354 .
2013-10-31 10:32:39 +01:00
antirez
4f3d9c0595
Regression test added for [SHZ]SCAN issue #1354 .
2013-10-31 09:43:21 +01:00
antirez
996bffbfb6
Test: added a SCAN test trying to trigger HT resize.
2013-10-30 16:50:25 +01:00
antirez
cde7c072ba
Test: added ZSCAN test.
2013-10-30 16:25:53 +01:00
antirez
82dcd85503
Test: added HSCAN test.
2013-10-30 16:24:39 +01:00
antirez
35250fa9df
Test: added SSCAN test.
2013-10-30 11:58:04 +01:00
antirez
a23bf27718
SCAN test keys sorting turned into more idiomatic Tcl.
2013-10-30 11:36:12 +01:00
antirez
d1bdb17b42
SCAN: tests moved to unit/scan.tcl.
2013-10-30 11:34:01 +01:00
antirez
af411f4c92
redis-benchmark: update help for new __rand_int__ form.
2013-10-28 18:13:42 +01:00
antirez
e23fa0ec99
Aesthetic fix (missing space) into HSCAN and ZSCAN implementations.
...
Thanks to @badboy for reporting.
2013-10-28 13:20:11 +01:00
antirez
b2618c6cdb
ZSCAN implemented.
2013-10-28 11:36:42 +01:00
antirez
6618167a9f
HSCAN implemented.
2013-10-28 11:35:26 +01:00
antirez
e96ffac563
SSCAN implemented.
2013-10-28 11:17:32 +01:00
antirez
99efa37a6b
dictScan(): empty hash table requires special handling.
2013-10-28 11:17:18 +01:00
antirez
e74c235567
SCAN is a random command and does not require output sorting.
...
Sorting the output helps when we want to turn a non-deterministic into a
deterministic command, in that case this is not possible.
2013-10-28 11:13:43 +01:00
antirez
0685c1ca13
SCAN: refactored into scanGenericCommand.
...
The new implementation is capable of iterating the keyspace but also
sets, hashes, and sorted sets, and can be used to implement SSCAN, ZSCAN
and HSCAN.
2013-10-28 11:11:34 +01:00
antirez
f86c07df30
Fixed typos in dictScan() comment.
2013-10-25 17:05:55 +02:00
antirez
817e6766aa
dictScan() algorithm documented.
2013-10-25 17:01:30 +02:00
antirez
eda292a7fa
SCAN: stay inside 80 cols.
2013-10-25 12:01:49 +02:00
antirez
fe0ffe6a1c
Revert "Fixed typo in SCAN comment. iff -> if."
...
Probably here Pieter means "if and only if".
This reverts commit 0a970b93e911c0ece1fa2551ade71e122d8c01e1.
2013-10-25 12:00:13 +02:00
antirez
7bd87839c1
SCAN: simplify keys list cleanup using listSetFreeMethod().
2013-10-25 11:58:03 +02:00
antirez
b18ac5f574
SCAN: Fix test after option renamed from PATTERN to MATCH.
2013-10-25 11:55:28 +02:00
antirez
6f69128751
SCAN: improve variable names for readability.
2013-10-25 11:54:45 +02:00
antirez
6bff0f3cb6
SCAN: remove additional newlines to conform to Redis code base.
2013-10-25 11:51:08 +02:00
antirez
32b555c5fb
SCAN: remove useless assertion, already enforced by command table.
2013-10-25 11:49:08 +02:00
antirez
6874fcc216
SCAN: use define REDIS_LONGSTR_SIZE instead of fixed len.
2013-10-25 11:48:18 +02:00
antirez
0a970b93e9
Fixed typo in SCAN comment. iff -> if.
2013-10-25 11:46:02 +02:00
antirez
5227a1f66f
SCAN option name changed: pattern -> match.
2013-10-25 11:45:32 +02:00
Pieter Noordhuis
f18269d1ef
Fix error in scan algorithm
...
The irrelevant bits shouldn't be masked to 1. This can result in slots being
skipped when the hash table is resized between calls to the iterator.
2013-10-25 10:50:03 +02:00
Pieter Noordhuis
25ae316f65
SCAN requires at least 1 argument
2013-10-25 10:49:56 +02:00
Pieter Noordhuis
956c0ed927
Add SCAN command
2013-10-25 10:49:48 +02:00