gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,920 Commits 1 Branch 0 Tags
Commit Graph

9599 Commits

Author SHA1 Message Date
chendianqiang
004c26ec28 make memory usage consistent of robj with OBJ_ENCODING_INT 2019-07-22 17:45:30 +08:00
Oran Agra
d7d028a7a7 Allow modules to handle RDB loading errors. 
This is especially needed in diskless loading, were a short read could have
caused redis to exit. now the module can handle the error and return to the
caller gracefully.

this fixes #5326
 2019-07-21 18:19:32 +03:00
John Sully
ff682d7902 Modules must have execute permissions to load 2019-07-19 15:28:31 -04:00
John Sully
2e6f1098e4 Any +x bit is acceptable 
Former-commit-id: 156e596f9c7a922bc3361652b74b78bbeab0f2dc
 2019-07-19 15:26:17 -04:00
antirez
bc5cb168f5 RDB: fix MODULE_AUX loading by continuing to next opcode. 
Thanks to @JohnSully for noticing this problem.
 2019-07-19 11:12:46 +02:00
John Sully
b2aa7b0683 Any +x bit is acceptable 
Former-commit-id: fc58516cca72fc9db97bc4c388f9fa692d115df4
 2019-07-19 01:42:05 -04:00
John Sully
70534846d1 Modules must have execute permissions to load 2019-07-19 01:37:34 -04:00
John Sully
08d067fbcf Modules must have execute permissions to load 
Former-commit-id: a4efcd35af52227a22daf7f882e8e14db3f8bf57
 2019-07-19 01:31:10 -04:00
antirez
1aa5638b93 RDB: make sure to abort on LZF encoding error. 
Former-commit-id: 27fe1658a2019bcd5d880e844bac21ccef8303f2
 2019-07-19 01:03:16 -04:00
antirez
3e75e77dcd RDB: handle encoding errors with rdbExitReportCorruptRDB(). 
Without such change, the diskless replicas, when loading RDB files from
the socket will not abort when a broken RDB file gets loaded. This is
potentially unsafe, because right now Redis is not able to guarantee
that encoding errors are safe from the POV of memory corruptions (for
instance the LZF library may not be safe against untrusted data?) so
better to abort when the RDB file we are going to load is corrupted.

Instead I/O errors are still returned to the caller without aborting,
so that in case of short read the diskless replica can try again.


Former-commit-id: 47feb2719ca7fd04e7e108ec1af0f777e536bf8a
 2019-07-19 01:02:49 -04:00
John Sully
bb9b8ee164 Fix bad merge in SCAN KEYS command 
Former-commit-id: c21af6b351328ffbdb1d1e2a7eed44f8f929f8b2
 2019-07-19 00:43:23 -04:00
John Sully
15f5c7ccf7 Merge commit '722446510faf0debf0d309708b2ed4fe4d939319' into unstable 
Former-commit-id: 821c12c482d20b15dfb5a6eeab52e167997627d8
 2019-07-19 00:32:43 -04:00
John Sully
4088de0ed2 Merge commit '677e95e2f5ee903682ce44a7bfd9558a22577926' into unstable 
Former-commit-id: 4602f8c391409e9dd59f1fbee6a5ef011b219ca1
 2019-07-19 00:01:56 -04:00
John Sully
e642441354 Fix compile errors from merges 
Former-commit-id: 27a927fe0011536c6539d7c2a79ccfdaf78cee22
 2019-07-18 23:35:51 -04:00
Angus Pearson
7b615e7274 Add char* typeNameCanonicalize(robj*) to remove duplicate code between SCAN and TYPE commands, 
and to keep OBJ_* enum to string canonicalization in one place.


Former-commit-id: 3cdc6e8d846e88cf4e250b2643662bde2a9317c5
 2019-07-18 23:31:31 -04:00
Madelyn Olson
a8fc002adc Fixed some spelling issues in ACL codepath including user facing error 
Former-commit-id: 50ad880ad55e7761fe2598e09be43947e88740fe
 2019-07-18 23:28:36 -04:00
John Sully
e160fbdeb9 Merge commit 'de035c94816722dd923e4aedd852869de79a5185' into unstable 
Former-commit-id: 15bed4bbcc962ec1e8ad5f57653534b721df9a70
 2019-07-18 23:26:46 -04:00
John Sully
73df5494a8 Merge commit 'bf963253ecfd367b49081a26c1b5c410558aecfc' into unstable 
Former-commit-id: 10986ae3a801c13013ec74880dd1f7969c284d01
 2019-07-18 23:22:36 -04:00
John Sully
f4c0c12e71 Merge commit '074d24df1e82b5c794a5da9fb6cda5b77b60b27b' into unstable 
Former-commit-id: ee460301fd160cf3fc82e52cf47d4a5f7503d781
 2019-07-18 23:20:46 -04:00
John Sully
c2eba1f742 Merge commit 'caf74e507e6535dab58ce6f3db19f8b594b5f7ca' into unstable 
Former-commit-id: 8ebe2fce3da506639acb37fedf1a2d3e47669572
 2019-07-18 23:18:42 -04:00
antirez
a9dbdb3348 Make comment in getClientOutputBufferMemoryUsage() describing the present. 
Former-commit-id: 35acae360a4c3c67370b03b4835c51b08194ca28
 2019-07-18 23:12:39 -04:00
John Sully
efc6bb9e0c Release version 5 
Former-commit-id: 25e18a7de91d4af651f8f22674846cb0238dd5d3
 2019-07-18 20:50:40 -04:00
John Sully
47e7652611 Active Replicas should always use their own slaveseldb variable when sending/saving rdbs - never those of their masters. This is because the Active Replica is also simultaneously a master 
Former-commit-id: bb090b6d20bfc3d5d3ca07270f64bf15fad42681
 2019-07-18 20:50:20 -04:00
John Sully
7ba2941735 Add support for sanitizers and fix issues they have found 
Former-commit-id: 58971a430dd3e4e8c39c7b5288211bc2ba7699ed
 2019-07-18 18:39:42 -04:00
John Sully
e41ab66722 Resolve race on neterr variable 
Former-commit-id: 1512274f4c51dc4e8f4e3d11df2f35e051c0c079
 2019-07-18 17:11:28 -04:00
John Sully
aa560582b4 Make object refcounts atomic, technically it doesn't need to be currently but the semantics are complicated and error prone. This is much safer with little performance impact 
Former-commit-id: e310d33c121550f69b1c06d101db0c3f944a7fb0
 2019-07-18 15:49:12 -04:00
John Sully
afa1a2e023 Suppress initialized data sanitizer warnings 
Former-commit-id: ad32ba0343a241c46206ada273b0c0125e9e3101
 2019-07-18 15:49:03 -04:00
antirez
5f450e4928 RDB: make sure to abort on LZF encoding error. 2019-07-18 18:59:38 +02:00
antirez
bd0f06c18c RDB: handle encoding errors with rdbExitReportCorruptRDB(). 
Without such change, the diskless replicas, when loading RDB files from
the socket will not abort when a broken RDB file gets loaded. This is
potentially unsafe, because right now Redis is not able to guarantee
that encoding errors are safe from the POV of memory corruptions (for
instance the LZF library may not be safe against untrusted data?) so
better to abort when the RDB file we are going to load is corrupted.

Instead I/O errors are still returned to the caller without aborting,
so that in case of short read the diskless replica can try again.
 2019-07-18 18:51:45 +02:00
Salvatore Sanfilippo
41ed85bd26
Merge pull request #6252 from soloestoy/tracking-flushdb 
Tracking flushdb
 2019-07-18 16:41:37 +02:00
antirez
947319cadd RDB: update rdbLoadRio comment about EOF condition. 2019-07-18 12:37:55 +02:00
zhaozhao.zz
f59119aad6 Client side caching: filter clients untracking 2019-07-18 16:46:19 +08:00
John Sully
452ace5b95 Another RESP3 regression 
Former-commit-id: 4e30a5b4e53a4d1580f8d7cca8a8eac11e36ce4d
 2019-07-17 22:57:52 -04:00
antirez
42b6305964 RDB: try to make error handling code more readable. 2019-07-17 17:30:02 +02:00
antirez
6b72b04a37 Rio: when in error condition avoid doing the operation. 2019-07-17 16:46:22 +02:00
antirez
5189db3d81 RDB: modify rdbReportError() var name for clarity. 2019-07-17 16:46:22 +02:00
antirez
48d91cf4cc Rio: remember read/write error conditions. 2019-07-17 16:46:22 +02:00
Oran Agra
c56b4ddc6f prevent diskless replica from terminating on short read 
now that replica can read rdb directly from the socket, it should avoid exiting
on short read and instead try to re-sync.

this commit tries to have minimal effects on non-diskless rdb reading.
and includes a test that tries to trigger this scenario on various read cases.
 2019-07-17 16:46:22 +02:00
Oran Agra
56258c6b7d Module API for Forking 
* create module API for forking child processes.
* refactor duplicate code around creating and tracking forks by AOF and RDB.
* child processes listen to SIGUSR1 and dies exitFromChild in order to
  eliminate a valgrind warning of unhandled signal.
* note that BGSAVE error reply has changed.

valgrind error is:
  Process terminating with default action of signal 10 (SIGUSR1)
 2019-07-17 16:40:24 +03:00
zhaozhao.zz
6191ea90a1 Client side caching: implement trackingInvalidateKeysOnFlush() 2019-07-17 20:33:52 +08:00
Oran Agra
6e07fac405 RM_Log - add support for logging without a context or context without module 
for instance detached thread safe contexts, or various callbacks that don't
provide a context.
 2019-07-17 15:08:18 +03:00
antirez
241d18d954 Merge branch 'unstable' of github.com:/antirez/redis into unstable 2019-07-17 12:26:38 +02:00
John Sully
cb58295ade Fix Issue #58 
Former-commit-id: c8516f3dc484920de4fc52acd72f5104d643ca87
 2019-07-17 02:34:02 -04:00
John Sully
bc0c9054b2 Shared objects should be marked as such 
Former-commit-id: aae0fdc11434fa76a1847eca9292c277b559730a
 2019-07-16 18:32:01 -04:00
John Sully
79731e805a Crash when aborting SYNC with a master on a thread other than main 
Former-commit-id: a19d0f67b9fffefd9029b9a2ef3358b110302bbf
 2019-07-15 14:55:41 -04:00
John Sully
bdc901f01c Implement test mode to make finding bugs easier 
Former-commit-id: 971f69fe1ff9cce50492a47f306b312457e50b9f
 2019-07-15 14:55:18 -04:00
John Sully
a9500e5483 Blocked clients can stall when under low load 
Former-commit-id: 7468c691ad04829c1fd3ae69f206946e8f38254a
 2019-07-13 16:44:11 -04:00
John Sully
e78ed8cc64 Fix more locking deadlocks 
Former-commit-id: 3081b6f98b5e7a9f3ef7cfe040236070398b081c
 2019-07-12 23:51:45 -04:00
John Sully
8f1e7d9d5b Fix deadlock with client and ae locks 
Former-commit-id: 8630339e43c1de1cd723bdfdca8ab5924e2cb8b0
 2019-07-12 20:46:50 -04:00
Salvatore Sanfilippo
3f1c84751a
Merge pull request #6196 from AngusP/resp3 
[RESP3, Minor] in networking.c double representation for -infiinity leaves out comma
 2019-07-12 13:08:46 +02:00