Oran Agra
ffdd0620d0
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-05 11:41:24 +02:00
Oran Agra
9ac6cb9ce4
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-05 09:42:49 +02:00
Guy Benoish
1c7a2269d6
Add RM_CreateStringFromDouble
2020-02-04 19:28:09 +05:30
antirez
90fae58b49
ACL LOG: make max log entries configurable.
2020-02-04 13:19:40 +01:00
antirez
64a73e9293
ACL LOG: test for AUTH reason.
2020-02-04 12:58:48 +01:00
antirez
0c1a4b5576
ACL LOG: log failed auth attempts.
2020-02-04 12:55:26 +01:00
lifubang
540b917a26
fix ssl flag check for redis-cli
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-04 17:32:30 +08:00
Guy Benoish
6fe55c2f29
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-02-04 10:23:48 +01:00
Leo Murillo
f7a94526dd
Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25
2020-02-04 10:23:48 +01:00
antirez
bbce3ba974
Add more info in the unblockClientFromModule() function.
2020-02-04 10:23:48 +01:00
WuYunlong
eecfa9793e
Fix lua related memory leak.
2020-02-04 10:23:48 +01:00
Guy Benoish
40295fb3fe
Modules: Fix blocked-client-related memory leak
...
If a blocked module client times-out (or disconnects, unblocked
by CLIENT command, etc.) we need to call moduleUnblockClient
in order to free memory allocated by the module sub-system
and blocked-client private data
Other changes:
Made blockedonkeys.tcl tests a bit more aggressive in order
to smoke-out potential memory leaks
2020-02-04 10:23:48 +01:00
WuYunlong
d2509811b7
Add tcl regression test in scripting.tcl to reproduce memory leak.
2020-02-04 10:23:48 +01:00
Yossi Gottlieb
29d4a1502a
TLS: Fix missing initialization in redis-cli.
2020-02-04 10:23:48 +01:00
Oran Agra
ec0c61da05
fix uninitialized info_cb var in module.c
2020-02-04 10:23:48 +01:00
Salvatore Sanfilippo
cfe39b7859
Merge pull request #6818 from leomurillo/zskiplistLevels
...
Set ZSKIPLIST_MAXLEVEL to 32
2020-02-04 10:20:56 +01:00
Salvatore Sanfilippo
6ca1ad1e27
Merge pull request #6825 from trevor211/fixMemoryLeakAboutLuaScript
...
Fix memory leak about lua script
2020-02-04 10:19:16 +01:00
WuYunlong
eb2196f5ce
Fix lua related memory leak.
2020-02-04 16:38:46 +08:00
WuYunlong
01eaf53bb3
Add tcl regression test in scripting.tcl to reproduce memory leak.
2020-02-04 16:34:11 +08:00
John Sully
46506b3e53
module fixes
...
Former-commit-id: ef4e11ecb8a6f1a05bb21f014120b0ef9e771b60
2020-02-04 01:22:25 -05:00
John Sully
c2eb10c322
Fix cluster test failures from Redis 6 merge
...
Former-commit-id: fd702e43f19ac2b8097afef84a73c8e71172979b
2020-02-03 20:00:09 -05:00
Salvatore Sanfilippo
2400f5782e
Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x
...
TLS: Fix missing initialization in redis-cli.
2020-02-03 16:43:56 +01:00
Salvatore Sanfilippo
726abe4deb
Merge pull request #6824 from oranagra/fix_module_c_uninit_var
...
fix uninitialized info_cb var in module.c
2020-02-03 15:46:13 +01:00
Oran Agra
138ed120dd
fix uninitialized info_cb var in module.c
2020-02-03 16:35:39 +02:00
Guy Benoish
2fda5f5c98
Exclude "keymiss" notification from NOTIFY_ALL
...
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)
Also updated redis.conf and module.c docs
2020-02-03 15:43:44 +05:30
Leo Murillo
560e1e6c4b
Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25
2020-02-02 02:48:00 -06:00
John Sully
2c899d7219
addRef memory model too restrictive
...
Former-commit-id: 249e0fdd363853ab7b489314002bdacd2438fa55
2020-02-01 21:52:17 -05:00
John Sully
958b86ddbb
RDB memory leaks
...
Former-commit-id: 6208118b133c7f4209fd0a55d2a75341407e3e2c
2020-01-30 17:57:10 -05:00
John Sully
a7b7040577
replication memory leaks
...
Former-commit-id: 73020b6a939f241ade7512d58a4ddf17f5a803c5
2020-01-30 17:56:24 -05:00
John Sully
4352a26a5b
Fix memory leak in cron
...
Former-commit-id: a9667e84ad44a3f2c08df0d95caeb6364f3f3509
2020-01-30 17:55:48 -05:00
John Sully
0f459fca2e
Merge branch 'redis_merge' into unstable
...
Former-commit-id: ab1524ff1a8290199bc5a88e2bd9623566866d6f
2020-01-30 16:05:40 -05:00
Salvatore Sanfilippo
53ac8c7df2
Merge pull request #6812 from guybe7/str_convert_fix
...
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
Guy Benoish
d72b7ed4fb
DEBUG OBJECT should pass keyname to module when loading
2020-01-30 19:15:12 +05:30
Guy Benoish
2deb55512f
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
antirez
b189a21974
ACL LOG: implement a few basic tests.
2020-01-30 11:14:13 +01:00
antirez
396161765b
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-01-30 10:50:32 +01:00
Yossi Gottlieb
93edb3ff3a
TLS: Fix missing initialization in redis-cli.
2020-01-29 21:40:02 +02:00
antirez
30a466ba38
ACL LOG: implement LOG RESET.
2020-01-29 18:51:04 +01:00
antirez
6671032faf
ACL LOG: group similar entries in a given time delta.
2020-01-29 18:40:32 +01:00
antirez
17ff3173d6
Add more info in the unblockClientFromModule() function.
2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo
bf53f9280a
Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
...
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
John Sully
f31af3bacf
CRON jobs were running half as often as required
...
Former-commit-id: 1069d0b4bf39818cbd72d0bcbd168769244cf18f
2020-01-28 21:40:40 -05:00
John Sully
8e7f3304b2
More threading fixes from merge
...
Former-commit-id: 4a980f4ddbebe3f62703aa3de67c93cdffb6b4b8
2020-01-28 17:54:00 -05:00
antirez
61dffd8669
ACL LOG: actually emit entries.
2020-01-28 18:04:20 +01:00
antirez
e8d0057710
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-01-28 17:30:50 +01:00
John Sully
e3b2ef962b
reenable multithreading after merge
...
Former-commit-id: 9fbb9a551e83ddfc66894fba688dae7c9c3c7ae1
2020-01-27 19:59:04 -05:00
John Sully
8a86276a86
cron reliability
...
Former-commit-id: c24a7c03c207d5e6ad95ef8958c0cfb118c1b593
2020-01-27 18:31:02 -05:00
John Sully
7b9fe2217a
fix expire test failures during overwrite
...
Former-commit-id: 5a8280d5772e5d185b8e4010b86f01752be5c9b5
2020-01-27 18:26:23 -05:00
John Sully
39378f982e
Fix most tests (still some failures)
...
Former-commit-id: da83e841255487efe0e4b13d42b2dcc55a369838
2020-01-27 18:16:19 -05:00
antirez
3e9e27e98f
ACL LOG: data structures and initial functions.
2020-01-27 18:37:52 +01:00