Oran Agra
1333a46b7e
fix maxmemory config warning
...
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.
other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
2020-02-12 14:17:40 +01:00
Oran Agra
8e7282eb3e
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-12 14:17:40 +01:00
Oran Agra
a678390e52
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-12 14:17:40 +01:00
Oran Agra
f42ce57d0f
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-12 14:15:56 +01:00
Oran Agra
919fbf421d
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-12 14:15:56 +01:00
Oran Agra
df096bc96b
add SAVE subcommand to ACL HELP and top comment
2020-02-12 14:15:56 +01:00
Oran Agra
22e45d46fe
freeClientAsync don't lock mutex if there's just one thread
2020-02-12 14:15:56 +01:00
Oran Agra
a55e584706
DEBUG HELP - add PROTOCOL
2020-02-12 14:15:56 +01:00
Oran Agra
ba28924418
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-12 14:15:56 +01:00
Guy Benoish
5a6cfbf4ca
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-12 14:15:56 +01:00
Guy Benoish
fae306b374
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-12 14:15:56 +01:00
Yossi Gottlieb
736309660f
TLS: Some redis.conf clarifications.
2020-02-12 14:15:56 +01:00
Oran Agra
488e194787
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-12 14:15:56 +01:00
Oran Agra
c82ccf0670
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-12 14:15:56 +01:00
antirez
51c1a9f8fb
ACL LOG: make max log entries configurable.
2020-02-12 14:15:35 +01:00
antirez
ea1e1b12c9
ACL LOG: test for AUTH reason.
2020-02-12 14:15:35 +01:00
antirez
7379c78a9b
ACL LOG: log failed auth attempts.
2020-02-12 14:15:35 +01:00
antirez
9f6e84f6be
ACL LOG: implement a few basic tests.
2020-02-12 14:15:35 +01:00
antirez
82790e510f
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-02-12 14:15:35 +01:00
antirez
943008ebac
ACL LOG: implement LOG RESET.
2020-02-12 14:15:35 +01:00
antirez
e271a61103
ACL LOG: group similar entries in a given time delta.
2020-02-12 14:15:35 +01:00
antirez
f1974d5d67
ACL LOG: actually emit entries.
2020-02-12 14:15:35 +01:00
antirez
d9b153c9f6
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-02-12 14:15:35 +01:00
antirez
577fc4388b
ACL LOG: data structures and initial functions.
2020-02-12 14:15:35 +01:00
Salvatore Sanfilippo
8aa0b19d83
Merge pull request #6691 from kraj/fno-common
...
Mark extern definition of SDS_NOINIT in sds.h
2020-02-12 14:04:53 +01:00
Salvatore Sanfilippo
f54bb2a330
Merge pull request #6882 from lifubang/userpass
...
correct help info for --user and --pass
2020-02-12 14:04:15 +01:00
lifubang
dc8f947d7c
correct help info for --user and --pass
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-12 16:34:22 +08:00
antirez
71f3f3f1af
Tracking: BCAST: broadcasting of keys in prefixes implemented.
2020-02-11 18:11:59 +01:00
antirez
3f7ba86255
Tracking: BCAST: registration in the prefix table.
2020-02-11 17:26:29 +01:00
John Sully
d1885547f2
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 329519d4aa230a9f7f2d3b82158f8cafcbbd6952
2020-02-11 03:48:08 -05:00
John Sully
da293758fc
Fix race condition in allocating connections to threads
...
Former-commit-id: 52434a583aa7114ff5658226441ab82ed3110a57
2020-02-11 03:44:28 -05:00
John Sully
ee99605def
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 18a5f46b6138e8a975dda0ed4897d19eed756d24
2020-02-11 02:39:08 -05:00
John Sully
e30630d53b
Implement an error handler so bug #125 can't happen
...
Former-commit-id: 16a019dba053fd0654116ff98a2ad0b66a9ed4e6
2020-02-11 01:41:00 -05:00
John Sully
3282d4114f
Fix higher latency at low load by grouping clients to threads. This fixes slow perf in cluster benchmarks mentioned in issue #102
...
Former-commit-id: 1a4c3224c9848f02fbdb49674045b593cfc41d31
2020-02-11 01:00:21 -05:00
John Sully
47acc74247
Fix cases where duplicate RREPLAY is applied
...
Former-commit-id: c3317686f8b8d94a3b2295def899ae30e208f327
2020-02-11 00:59:07 -05:00
John Sully
3f62860342
Fix issue #119
...
Former-commit-id: 46224721237616c345f6726b721a354d7bda71df
2020-02-10 19:52:57 -05:00
John Sully
5a71721610
Fix memory leak in cron
...
Former-commit-id: f1748f8c7611ad96d7ba4fed66439cd1f043e6f3
2020-02-10 18:26:04 -05:00
John Sully
9dc9707693
Add missing test file
...
Former-commit-id: 0c101dccc825668cb7ff07c23e82db0f5642b786
2020-02-10 18:15:29 -05:00
antirez
dfe126f3e9
Tracking: BCAST: parsing of the options + skeleton.
2020-02-10 17:18:11 +01:00
antirez
f53cc00c09
Tracking: always reply with an array of keys.
2020-02-10 13:42:18 +01:00
meir@redislabs.com
67dbc5f365
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-10 12:10:32 +02:00
Salvatore Sanfilippo
256ec6c52f
Merge pull request #6875 from WOOSEUNGHOON/cve20158080_fix
...
[FIX] revisit CVE-2015-8080 vulnerability
2020-02-10 10:45:52 +01:00
Seunghoon Woo
ef764dde1c
[FIX] revisit CVE-2015-8080 vulnerability
2020-02-10 16:32:46 +09:00
John Sully
66925e9a54
CLANG build fix
...
Former-commit-id: dc78bf1ccbd3dfd2de582d2a0d0be3223de3c7c3
2020-02-10 00:29:26 -05:00
John Sully
9cd3b8253d
Ensure multi-master works for ring topologies
...
Former-commit-id: a7cc3aac28ccec4dadb80aa2cc7279c53982bc28
2020-02-10 00:25:03 -05:00
John Sully
e05f9de395
Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable
...
Former-commit-id: 339631530a5e18af7ad53f1a3df03d24085f9450
2020-02-09 02:25:20 -05:00
John Sully
6d25bd9f47
Addmissing test file
...
Former-commit-id: fb2bdf7d05e27b15dcb53b09d6820416a99a3ba7
2020-02-08 16:49:41 -05:00
John Sully
70cb1df72a
merge 5.0 unstable
...
Former-commit-id: c45f1328ac82fa9ebc8731314b40bd059ea45b6f
2020-02-07 16:45:59 -05:00
antirez
85e4777d5c
Tracking: minor change of names and new INFO field.
2020-02-07 18:12:45 +01:00
antirez
1ea6672430
Rax.c: populate data field after random walk.
2020-02-07 18:12:10 +01:00