Salvatore Sanfilippo
2a5ac7ad88
Merge pull request #5367 from nUl1/fullresync-stopbgsave
...
Prevent RDB autosave from overwriting full resync results
2018-10-31 11:42:04 +01:00
antirez
5789a7ef6d
asyncCloseClientOnOutputBufferLimitReached(): don't free fake clients.
...
Fake clients are used in special situations and are not linked to the
normal clients list, freeing them will always result in Redis crashing
in one way or the other.
It's not common to send replies to fake clients, but we have one usage
in the modules API. When a client is blocked, we associate to the
blocked client object (that is safe to manipulate in a thread), a fake
client that accumulates replies. So because of this bug there was
the problem described in issue #5443 .
The fix was verified to work with the provided example module. To write
a regression is very hard and unlikely to be triggered in the future.
2018-10-30 13:38:41 +01:00
Salvatore Sanfilippo
495e508614
Merge pull request #5489 from devnexen/unstable
...
Fix non Linux build.
2018-10-29 18:25:14 +01:00
David Carlier
977556fa5b
needs it for the global
2018-10-26 14:12:47 +00:00
David Carlier
a2cc07cad4
Fix non Linux build.
...
timezone global is a linux-ism whereas it is a function under BSD.
Here a helper to get the timezone value in a more portable manner.
2018-10-26 14:02:09 +00:00
antirez
efa96f0648
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 13:08:58 +02:00
antirez
75672bff45
Add command fingerprint comment for XSETID.
2018-10-25 13:08:48 +02:00
Salvatore Sanfilippo
50f68bcbdf
Merge pull request #5454 from soloestoy/multi-oom
...
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-25 13:00:19 +02:00
antirez
f37fa5f7d6
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 11:50:15 +02:00
Salvatore Sanfilippo
4aa2ff5840
Merge pull request #5459 from itamarhaber/xpending_count_underflow
...
A fix to XPENDING's count underflow
2018-10-25 11:50:04 +02:00
antirez
c02aeee147
Fix XRANGE COUNT option for value of 0.
2018-10-25 11:36:24 +02:00
antirez
3df187410f
Fix typo in streamReplyWithRange() top comment.
2018-10-24 16:28:44 +02:00
Salvatore Sanfilippo
6f79cc62e6
Merge pull request #5469 from soloestoy/stat-key-miss-if-expired
...
if we read a expired key, misses++
2018-10-24 12:31:28 +02:00
Salvatore Sanfilippo
f588805a52
Merge pull request #5453 from damz/pr/aof-buffer-evict
...
Overhead is the allocated size of the AOF buffer, not its length
2018-10-24 12:28:28 +02:00
antirez
5f8d96699d
Simplify part of the #5470 patch.
2018-10-24 12:26:27 +02:00
Salvatore Sanfilippo
0f4e72fb8d
Merge pull request #5470 from soloestoy/keys-no-trigger-expire
...
do not delete expired keys in KEYS command
2018-10-24 12:23:59 +02:00
antirez
63787d5cbc
Use guide comments to make changes in #5462 more obvious.
2018-10-22 17:43:48 +02:00
antirez
9389de6304
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-22 17:41:43 +02:00
Salvatore Sanfilippo
409ada78c1
Merge pull request #5462 from youjiali1995/fix-migrate-expired-keys
...
migrate: fix mismatch of RESTORE reply when some keys have expired.
2018-10-22 17:40:37 +02:00
antirez
5f9de96d2f
Remove useless complexity from MSET implementation.
2018-10-22 12:24:02 +02:00
Salvatore Sanfilippo
d1e9aa4b56
Merge pull request #5451 from hujiecs/unstable
...
several typos fixed, optimize MSETNX to avoid unnecessary loop
2018-10-22 12:17:08 +02:00
hujie
f96dbdf0ab
fix typo in config.c
2018-10-21 10:37:36 +08:00
hujie
2cf0ab76fd
fix typo
2018-10-20 12:18:56 +08:00
zhaozhao.zz
2906ba5b5c
if we read a expired key, misses++
2018-10-19 18:16:29 +08:00
zhaozhao.zz
357909d7dd
do not delete expired keys in KEYS command
2018-10-19 18:00:57 +08:00
antirez
196555bf26
Fix again stack generation on the Raspberry Pi.
...
The fix was removed by f6627a3e6 attempting to fix the stack generation
on ARM64, without testing if it would still work on ARM32.
Now it should work both sides.
2018-10-19 10:39:57 +02:00
youjiali1995
e29c6573b9
migrate: fix mismatch of RESTORE reply when some keys have expired.
2018-10-18 18:57:51 +08:00
Itamar Haber
fbc22b4d21
Plugs a potential underflow
2018-10-17 19:33:11 +03:00
antirez
fc0e7b5e88
Streams: use bulk replies instead of status replies.
...
They play better with Lua scripting, otherwise Lua will see status
replies as "ok" = "string" which is very odd, and actually as @oranagra
reasoned in issue #5456 in the rest of the Redis code base there was no
such concern as saving a few bytes when the protocol is emitted.
2018-10-17 17:21:09 +02:00
Itamar Haber
ce6c8730a0
Corrects inline documentation of syntax
2018-10-17 16:13:55 +03:00
antirez
60f84c7776
Fix conditional in XGROUP.
2018-10-17 13:00:35 +02:00
antirez
f130bb13f0
Update help.h for redis-cli.
2018-10-17 12:57:21 +02:00
antirez
de887c7e1d
Tests for XGROUP CREATE MKSTREAM.
2018-10-17 12:11:10 +02:00
antirez
182e83b5c7
Fix XGROUP CREATE MKSTREAM handling of .
2018-10-17 12:10:52 +02:00
antirez
9a0cdbd59d
Process MKSTREAM option of XGROUP CREATE at a later time.
...
This avoids issues with having to replicate a command that produced
errors.
2018-10-17 12:04:06 +02:00
antirez
6e6f322ee5
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-17 11:36:03 +02:00
antirez
34a57904f0
XGROUP CREATE: MKSTREAM option for automatic stream creation.
2018-10-17 11:27:27 +02:00
zhaozhao.zz
549b9142f6
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-17 16:40:45 +08:00
Salvatore Sanfilippo
9388517487
Merge pull request #5333 from soloestoy/stream-commands-flag
...
Scripting & Streams: some commands need right flags
2018-10-17 07:50:32 +02:00
Damien Tournoud
8b3154a0ea
Overhead is the allocated size of the AOF buffer, not its length
2018-10-16 11:47:42 -07:00
Salvatore Sanfilippo
eb4c1ab213
Merge pull request #5452 from soloestoy/xsetid-lastid
...
Streams: rewrite empty streams with certain lastid
2018-10-16 18:56:55 +02:00
zhaozhao.zz
340e1b8c96
Streams: Tests modified XSTREAM -> XSETID
2018-10-16 23:56:26 +08:00
zhaozhao.zz
55e3c3680b
Streams: rewrite empty streams with certain lastid
2018-10-16 23:47:27 +08:00
antirez
f501a8367c
Tests modified to use XADD MAXLEN 0 + XSETID.
...
See #5426 .
2018-10-16 17:28:56 +02:00
antirez
fbad47d606
Streams: rewrite empty streams with XADD MAXLEN 0. Use XSETID.
...
Related to #5426 .
2018-10-16 16:48:31 +02:00
antirez
6d174778ab
XSETID: accept IDs based on last entry.
...
Related to #5426 .
2018-10-16 16:46:17 +02:00
antirez
8e399f0e01
Streams: XSTREAM SETID -> XSETID.
...
Keep vanilla stream commands at toplevel, see #5426 .
2018-10-16 13:17:14 +02:00
Salvatore Sanfilippo
ff1b36c825
Merge pull request #5426 from soloestoy/feature-xstream
...
Bugfix data inconsistency after aof rewrite, and add XSTREAM command.
2018-10-16 13:10:36 +02:00
hujiecs
57e64d5e62
several typos fixed, optimize MSETNX to avoid unnecessary loop
2018-10-16 15:48:03 +08:00
Salvatore Sanfilippo
40010dea27
Merge pull request #5416 from halaei/fix-timer-selected-db
...
fix timer context selected database
2018-10-15 13:01:58 +02:00