John Sully
c2eb10c322
Fix cluster test failures from Redis 6 merge
...
Former-commit-id: fd702e43f19ac2b8097afef84a73c8e71172979b
2020-02-03 20:00:09 -05:00
John Sully
2c899d7219
addRef memory model too restrictive
...
Former-commit-id: 249e0fdd363853ab7b489314002bdacd2438fa55
2020-02-01 21:52:17 -05:00
John Sully
958b86ddbb
RDB memory leaks
...
Former-commit-id: 6208118b133c7f4209fd0a55d2a75341407e3e2c
2020-01-30 17:57:10 -05:00
John Sully
a7b7040577
replication memory leaks
...
Former-commit-id: 73020b6a939f241ade7512d58a4ddf17f5a803c5
2020-01-30 17:56:24 -05:00
John Sully
4352a26a5b
Fix memory leak in cron
...
Former-commit-id: a9667e84ad44a3f2c08df0d95caeb6364f3f3509
2020-01-30 17:55:48 -05:00
John Sully
0f459fca2e
Merge branch 'redis_merge' into unstable
...
Former-commit-id: ab1524ff1a8290199bc5a88e2bd9623566866d6f
2020-01-30 16:05:40 -05:00
John Sully
f31af3bacf
CRON jobs were running half as often as required
...
Former-commit-id: 1069d0b4bf39818cbd72d0bcbd168769244cf18f
2020-01-28 21:40:40 -05:00
John Sully
8e7f3304b2
More threading fixes from merge
...
Former-commit-id: 4a980f4ddbebe3f62703aa3de67c93cdffb6b4b8
2020-01-28 17:54:00 -05:00
John Sully
e3b2ef962b
reenable multithreading after merge
...
Former-commit-id: 9fbb9a551e83ddfc66894fba688dae7c9c3c7ae1
2020-01-27 19:59:04 -05:00
John Sully
7b9fe2217a
fix expire test failures during overwrite
...
Former-commit-id: 5a8280d5772e5d185b8e4010b86f01752be5c9b5
2020-01-27 18:26:23 -05:00
John Sully
39378f982e
Fix most tests (still some failures)
...
Former-commit-id: da83e841255487efe0e4b13d42b2dcc55a369838
2020-01-27 18:16:19 -05:00
John Sully
8e5fe97525
Merge remote-tracking branch 'redis/6.0' into redis_merge
...
Former-commit-id: ef9a3cadcf94326bf2f163db7698aad9a3c01690
2020-01-27 02:55:48 -05:00
John Sully
b7b8eb2ecb
Missing cron files
...
Former-commit-id: c983d57f739cc9b4b8271a6d069fad1b5a9d3dad
2020-01-21 19:51:16 -05:00
John Sully
262b9a5d92
Initial implementation of the CRON command
...
Former-commit-id: 3204a39ada15ec33ac7926dc8b8f0e1875b99acb
2020-01-21 19:50:28 -05:00
John Sully
7f8cb3600b
Bump version
...
Former-commit-id: f4319c12803f27a93150178f8b61f10aea09ce01
2020-01-20 19:20:50 -05:00
antirez
cbabf779c2
Simplify #6379 changes.
2020-01-17 10:47:38 +01:00
antirez
8e9d19bc65
Change error message for #6775 .
2020-01-17 10:47:38 +01:00
WuYunlong
658749cc54
Free allocated sds in pfdebugCommand() to avoid memory leak.
2020-01-17 10:47:38 +01:00
Vasyl Melnychuk
ba146d4c09
Make error when submitting command in incorrect context more explicit
...
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
2020-01-17 10:47:38 +01:00
WuYunlong
47988c9666
Fix potential memory leak of clusterLoadConfig().
2020-01-17 10:47:38 +01:00
WuYunlong
cc90f79baf
Fix potential memory leak of rioWriteBulkStreamID().
2020-01-17 10:47:38 +01:00
antirez
5be3a15a82
Setting N I/O threads should mean N-1 additional + 1 main thread.
2020-01-17 10:47:38 +01:00
antirez
ecd17e819c
Jump to right label on AOF parsing error.
...
Related to #6054 .
2020-01-17 10:47:38 +01:00
antirez
1927932b43
Port PR #6110 to new connection object code.
2020-01-17 10:47:38 +01:00
antirez
f2df5773b1
A few comments about main thread serving I/O as well.
...
Related to #6110 .
2020-01-17 10:47:38 +01:00
zhaozhao.zz
b3ff8a4b6d
Threaded IO: use main thread to handle read work
2020-01-17 10:47:38 +01:00
zhaozhao.zz
b1f2c51037
Threaded IO: use main thread to handle write work
2020-01-17 10:47:38 +01:00
John Sully
ac55fe6dac
Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable
...
Former-commit-id: 762396d997b4e155778ba62346376b37b4673154
2020-01-11 16:35:06 -05:00
John Sully
e942999159
Avoid crash due to excessive posted functions for AOF rewrite
...
Former-commit-id: c575e7df9408ad7bd66ac7a104a38e841d525681
2020-01-11 16:34:30 -05:00
John Sully
74fcfc0b7f
Avoid crash due to excessive posted functions for AOF rewrite
...
Former-commit-id: aa6409f2e8a37288eb4953fbcf3a82e02545348b
2020-01-11 16:34:09 -05:00
John Sully
6c0f148468
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: e603e57588d040f96876d6b281a3867a8db53f6a
2020-01-10 17:46:23 -05:00
John Sully
831528e8e4
Ignore other flags after pro is enabled since we won't understand them
...
Former-commit-id: 049b48ef79fdde4c9b1c9f227a329bd9223e2b1d
2020-01-10 17:46:02 -05:00
ShooterIT
7bbafc5639
Rename rdb asynchronously
2020-01-10 13:16:25 +01:00
Leo Murillo
c7f752667e
Fix bug on KEYS command where pattern starts with * followed by \x00 (null char).
2020-01-10 13:16:25 +01:00
antirez
3be7762388
Free fakeclient argv on AOF error.
...
We exit later, so no bug fixed, but it is more correct.
See #6054 , thanks to @ShooterIT for finding the issue.
2020-01-10 13:16:25 +01:00
Guy Benoish
1b5bf40c20
Blocking XREAD[GROUP] should always reply with valid data (or timeout)
...
This commit solves the following bug:
127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM
OK
127.0.0.1:6379> XADD x 666 f v
"666-0"
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
2) 1) 1) "666-0"
2) 1) "f"
2) "v"
127.0.0.1:6379> XADD x 667 f v
"667-0"
127.0.0.1:6379> XDEL x 667
(integer) 1
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
2) (empty array)
The root cause is that we use s->last_id in streamCompareID
while we should use the last *valid* ID
2020-01-10 13:16:14 +01:00
John Sully
954c20edd9
Add support for incremental build with header files
2020-01-10 13:16:14 +01:00
WuYunlong
11c3afd711
Fix petential cluster link error.
...
Funcion adjustOpenFilesLimit() has an implicit parameter, which is server.maxclients.
This function aims to ajust maximum file descriptor number according to server.maxclients
by best effort, which is "bestlimit" could be lower than "maxfiles" but greater than "oldlimit".
When we try to increase "maxclients" using CONFIG SET command, we could increase maximum
file descriptor number to a bigger value without calling aeResizeSetSize the same time.
When later more and more clients connect to server, the allocated fd could be bigger and bigger,
and eventually exceeds events size of aeEventLoop.events. When new nodes joins the cluster,
new link is created, together with new fd, but when calling aeCreateFileEvent, we did not
check the return value. In this case, we have a non-null "link" but the associated fd is not
registered.
So when we dynamically set "maxclients" we could reach an inconsistency between maximum file
descriptor number of the process and server.maxclients. And later could cause cluster link and link
fd inconsistency.
While setting "maxclients" dynamically, we consider it as failed when resulting "maxclients" is not
the same as expected. We try to restore back the maximum file descriptor number when we failed to set
"maxclients" to the specified value, so that server.maxclients could act as a guard as before.
2020-01-10 13:16:14 +01:00
Yossi Gottlieb
b752e83db5
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2020-01-10 13:16:03 +01:00
hwware
e16eb87465
typo fix in acl.c
2020-01-10 13:16:03 +01:00
Itamar Haber
35ea9d231b
Adjusts 'io_threads_num' max to 128
...
Instead of 512, use the defined max from networking.c
2020-01-10 13:16:03 +01:00
antirez
3872912679
XCLAIM: Create the consumer only on successful claims.
...
Fixes #6744 .
2020-01-08 12:31:39 +01:00
yz1509
b9a1530345
avoid sentinel changes promoted_slave to be its own replica.
2020-01-08 12:31:25 +01:00
John Sully
47673dd992
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: d0654af74f2090060a74aa25b26637a197a6179f
2020-01-06 14:24:49 -05:00
John Sully
48c3ecc739
pro launch should respect KEYDB_PRO_DIRECTORY
...
Former-commit-id: d5f8df59977194ee0cfce798364eb5620435e6f3
2020-01-06 14:24:37 -05:00
John Sully
7e596c9703
Bump version
...
Former-commit-id: 39acb312efbb06f38e98c3ebbb98d17a556b050a
2020-01-06 12:07:57 -05:00
John Sully
6331131256
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: b643c3820485886d2a1911af7bc1cd8419e21f99
2020-01-06 12:07:11 -05:00
John Sully
6370309b58
Drop severity of master disconnect log when multimaster is enabled
...
Former-commit-id: edb993d52b25c30392c6eb1e60896498f991a223
2020-01-02 15:36:02 -05:00
John Sully
da917c4de5
Fix issue where expire is lost when performing a defrag
...
Former-commit-id: aea333bb78fafabbddb340dfd4c232c2e207cfba
2020-01-01 20:41:17 -05:00
John Sully
20e529c441
C++ wrapper classes for SDS
...
Former-commit-id: 45817db8c3a86815945359113dcbccfde4257ce5
2020-01-01 19:13:48 -05:00