Guy Benoish
1b5bf40c20
Blocking XREAD[GROUP] should always reply with valid data (or timeout)
...
This commit solves the following bug:
127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM
OK
127.0.0.1:6379> XADD x 666 f v
"666-0"
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
2) 1) 1) "666-0"
2) 1) "f"
2) "v"
127.0.0.1:6379> XADD x 667 f v
"667-0"
127.0.0.1:6379> XDEL x 667
(integer) 1
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
2) (empty array)
The root cause is that we use s->last_id in streamCompareID
while we should use the last *valid* ID
2020-01-10 13:16:14 +01:00
..
2019-12-17 07:15:04 +00:00
2020-01-10 13:16:03 +01:00
2019-11-13 10:14:45 +08:00
2019-10-07 21:06:30 +03:00
2019-10-15 17:21:51 +03:00
2019-10-15 17:21:51 +03:00
2019-10-07 21:06:13 +03:00
2019-10-07 21:06:13 +03:00
2019-11-19 11:40:34 +01:00
2018-10-16 15:48:03 +08:00
2018-10-05 18:29:23 +02:00
2019-11-20 20:39:04 -05:00
2019-12-18 11:58:02 +01:00
2019-12-29 15:46:31 +01:00
2019-07-17 16:40:24 +03:00
2019-12-17 09:19:47 +01:00
2019-12-16 23:34:37 -08:00
2020-01-10 13:16:14 +01:00
2018-11-25 08:10:26 +00:00
2019-10-15 17:21:51 +03:00
2019-10-07 21:06:30 +03:00
2019-10-15 17:21:51 +03:00
2019-03-01 17:53:14 +01:00
2019-12-18 11:58:02 +01:00
2019-10-29 17:59:09 +02:00
2019-11-12 15:05:29 +02:00
2019-02-19 17:27:42 +01:00
2019-02-18 18:27:18 +01:00
2019-10-07 09:09:32 +03:00
2020-01-01 18:10:39 +01:00
2014-12-05 12:41:59 +11:00
2019-12-18 12:57:32 +01:00
2015-07-26 15:17:18 +02:00
2018-09-02 00:06:20 -07:00
2019-02-24 21:38:15 +01:00
2018-10-17 12:57:21 +02:00
2019-09-17 06:18:01 +09:00
2018-10-16 15:48:03 +08:00
2019-10-24 14:24:55 +03:00
2019-10-24 14:24:55 +03:00
2018-07-31 12:07:57 +08:00
2018-10-02 19:37:36 +02:00
2018-09-18 17:04:00 +08:00
2019-10-07 18:24:34 +02:00
2019-10-28 11:10:58 +01:00
2019-10-07 18:24:34 +02:00
2019-10-07 18:24:34 +02:00
2018-09-28 13:00:44 +02:00
2020-01-10 13:16:14 +01:00
2019-11-19 17:23:47 +08:00
2020-01-10 13:16:03 +01:00
2019-11-22 15:42:49 +08:00
2019-12-29 15:46:31 +01:00
2019-03-21 11:47:14 +02:00
2019-11-21 10:06:15 +01:00
2019-01-09 17:00:30 +01:00
2018-10-16 15:48:03 +08:00
2019-11-14 12:48:54 +01:00
2018-10-13 14:17:38 +02:00
2019-11-19 11:58:07 +01:00
2019-10-29 17:59:09 +02:00
2019-07-22 18:45:47 +02:00
2019-05-08 12:13:45 +01:00
2019-10-29 17:59:09 +02:00
2019-12-12 09:40:36 +01:00
2020-01-10 13:16:03 +01:00
2019-10-02 11:30:20 +02:00
2019-11-19 18:55:44 +02:00
2019-10-07 21:06:30 +03:00
2019-10-07 21:06:30 +03:00
2019-12-19 09:24:52 +01:00
2019-10-02 11:30:20 +02:00
2020-01-08 12:31:25 +01:00
2019-12-19 09:24:52 +01:00
2019-12-19 09:24:52 +01:00
2018-11-11 18:49:55 +00:00
2019-09-12 12:21:37 +02:00
2019-09-12 12:21:37 +02:00
2019-09-04 12:14:25 +00:00
2019-01-09 17:00:29 +01:00
2019-12-02 00:28:41 -05:00
2019-12-18 11:58:02 +01:00
2019-12-29 15:46:31 +01:00
2019-11-03 16:42:31 +02:00
2019-11-22 16:38:49 +08:00
2019-09-02 12:50:47 +02:00
2020-01-10 13:16:14 +01:00
2019-12-18 11:58:02 +01:00
2019-09-02 12:50:47 +02:00
2019-10-08 17:58:50 +03:00
2019-12-05 13:37:11 +00:00
2019-11-21 10:06:15 +01:00
2019-11-21 10:06:15 +01:00
2019-12-19 17:27:29 +01:00
2019-05-08 12:53:56 +08:00
2019-12-02 09:13:29 +01:00
2019-12-02 09:13:29 +01:00