zhaozhao.zz
0da0f59614
Streams: propagate lastid in XCLAIM when it has effect
2018-10-11 21:44:20 +08:00
zhaozhao.zz
5c93403720
Streams: XCLAIM ignore minidle if NACK is created by FORCE
...
Because the NACK->consumer is NULL, if idletime < minidle
the NACK does not belong to any consumer, then redis will crash
in XPENDING.
2018-10-11 21:20:49 +08:00
zhaozhao.zz
fe09dc35de
Streams: bugfix XCLAIM should propagate group name not consumer name
2018-10-11 21:12:09 +08:00
antirez
d27bd9b3a3
LOLWUT: capitalize Nees.
2018-10-11 13:00:55 +02:00
antirez
b43c423a81
Test: cgroup propagation test also for NOACK variant.
...
Related to #5433 .
2018-10-10 17:37:41 +02:00
antirez
d2fa12b96a
Test: consumer group last ID slave propagation test.
...
This is a regression for #5433 .
2018-10-10 17:32:17 +02:00
antirez
468d9eb027
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-10 12:51:39 +02:00
antirez
b10d99a13b
Fix propagation of consumer groups last ID.
...
Issue #5433 .
2018-10-10 12:51:02 +02:00
antirez
8249ef2cc1
changelog.tcl: get optional argument for number of commits.
2018-10-10 11:03:36 +02:00
Salvatore Sanfilippo
218454ea08
Merge pull request #5428 from soloestoy/client-protected
...
Avoid recreate write handler for protected client.
2018-10-09 18:02:56 +02:00
zhaozhao.zz
138e48f940
Avoid recreate write handler for protected client.
2018-10-09 20:34:11 +08:00
antirez
b6b7304f00
Free protected clients asynchronously.
...
Related to #4840 .
Note that when we re-enter the event loop with aeProcessEvents() we
don't process timers, nor before/after sleep callbacks, so we should
never end calling freeClientsInAsyncFreeQueue() when re-entering the
loop.
2018-10-09 13:28:51 +02:00
antirez
8401773272
Actually use the protectClient() API where needed.
...
Related to #4804 .
2018-10-09 13:18:52 +02:00
antirez
4e851f8044
Introduce protectClient() + some refactoring.
...
The idea is to have an API for the cases like -BUSY state and DEBUG
RELOAD where we have to manually deinstall the read handler.
See #4804 .
2018-10-09 13:15:41 +02:00
Salvatore Sanfilippo
1b7bab98b8
Merge pull request #4804 from soloestoy/fix-debug-load
...
debug: avoid free client unexpectedly when reload & loadaof
2018-10-09 12:56:08 +02:00
antirez
a09ffe6c25
aof.c: improve indentation and change warning message.
...
Related to #5201 .
I removed the !!! Warning part since compared to the other errors, a
missing EXEC is in theory a normal happening in the AOF file, at least
in theory: may happen in a differnet number of situations, and it's
probably better to don't give the user the feeling that something really
bad happened.
2018-10-09 11:51:04 +02:00
Salvatore Sanfilippo
12fd6fb75f
Merge pull request #5201 from soloestoy/abort-if-lost-exec-aof-load
...
AOF: discard if we lost EXEC when loading aof
2018-10-09 11:47:04 +02:00
antirez
306407c6a5
Refactoring of XADD / XTRIM MAXLEN rewriting.
...
See #5141 .
2018-10-08 12:05:22 +02:00
Salvatore Sanfilippo
06219d42d9
Merge pull request #5141 from soloestoy/fix-xtrim-inconsistency
...
Fix XTRIM and XADD with MAXLEN inconsistency
2018-10-08 12:00:00 +02:00
Salvatore Sanfilippo
8704dfd7b1
Merge pull request #5422 from ziyasal/patch-1
...
Fix typo in the comment of raxSeekGreatest function
2018-10-08 11:34:42 +02:00
O(ʒ)
aa137f5498
Fix typo
2018-10-07 13:37:58 +02:00
antirez
a6e595c778
Fix typo in replicationCron() comment.
2018-10-05 18:30:45 +02:00
antirez
7a7996b71f
Fix typo in design comment of bio.c.
2018-10-05 18:29:23 +02:00
antirez
8c7dcff7e8
xclaimCommand(): fix comment typos.
2018-10-04 17:34:06 +02:00
antirez
c8d9906fe6
streamAppendItem(): Update the radix tree pointer only if changed.
2018-10-02 19:45:33 +02:00
antirez
450d0be206
Listpack: optionally force reallocation on inserts.
...
This is useful in order to spot bugs where we fail
at updating the pointer returned by the insertion
function. Normally often the same pointer is returned,
making it harder than needed to spot bugs.
Related to #5210 .
2018-10-02 19:37:36 +02:00
antirez
c58c884484
Fix printf type mismatch in genRedisInfoString().
2018-10-02 16:26:30 +02:00
antirez
74f1b91282
streamIteratorRemoveEntry(): set back lp only if pointer changed.
...
Most of the times the pointer will remain the same since integers of
similar size don't take more space in listpacks.
Related to #5210 .
2018-10-02 16:20:40 +02:00
Salvatore Sanfilippo
ba1d382d42
Merge pull request #5210 from soloestoy/raxinsert-in-xdel
...
Streams: update listpack with new pointer in XDEL
2018-10-02 16:18:55 +02:00
Salvatore Sanfilippo
50d06ebb29
Merge pull request #5392 from soloestoy/bugfix-brpoplpush
...
bugfix: replace lastcmd with cmd when rewrite BRPOPLPUSH as RPOPLPUSH
2018-10-02 16:09:22 +02:00
Salvatore Sanfilippo
159531c1c9
Merge pull request #5242 from oranagra/script_mem
...
script cache memory in INFO and MEMORY includes both script code and overheads
2018-10-02 16:03:05 +02:00
Salvatore Sanfilippo
01f020a72f
Merge pull request #5397 from bmerry/fix-bad-zmalloc-size
...
Fix invalid use of sdsZmallocSize on an embedded string
2018-10-01 13:30:42 +02:00
Salvatore Sanfilippo
b111d8c5f9
Merge pull request #5398 from bmerry/fix-zrealloc-accounting
...
Fix incorrect memory usage accounting in zrealloc
2018-10-01 13:28:53 +02:00
Salvatore Sanfilippo
78e9bc067a
Merge pull request #5396 from oranagra/cmdstats_exec
...
fix #5024 - commandstats for multi-exec were logged as EXEC.
2018-10-01 13:24:49 +02:00
Salvatore Sanfilippo
87b54ff9c1
Merge pull request #5400 from halaei/fix-dict-get-on-not-found
...
fix dict get on not found
2018-10-01 13:22:33 +02:00
Hamid Alaei
95cc968672
fix dict get on not found
2018-10-01 13:57:25 +03:30
antirez
4813183c5b
Fix XINFO comment for consistency.
2018-10-01 11:38:58 +02:00
Bruce Merry
84f851719b
Fix incorrect memory usage accounting in zrealloc
...
When HAVE_MALLOC_SIZE is false, each call to zrealloc causes used_memory
to increase by PREFIX_SIZE more than it should, due to mis-matched
accounting between the original zmalloc (which includes PREFIX size in
its increment) and zrealloc (which misses it from its decrement).
I've also supplied a command-line test to easily demonstrate the
problem. It's not wired into the test framework, because I don't know
TCL so I'm not sure how to automate it.
2018-09-30 11:49:03 +02:00
Oran Agra
65590b2c5c
fix #5024 - commandstats for multi-exec were logged as EXEC.
...
this was broken a while back by ba9154d7e7bf959b002533384319a1e90545447b
the purpose of which was to fix commandstats for GEOADD
2018-09-30 12:43:11 +03:00
Bruce Merry
fb91859c09
Fix invalid use of sdsZmallocSize on an embedded string
...
sdsZmallocSize assumes a dynamically allocated SDS. When given a string
object created by createEmbeddedStringObject, it calls zmalloc_size on a
pointer that isn't the one returned by zmalloc
2018-09-30 11:32:48 +02:00
antirez
205c90c72c
Try to avoid issues with GCC pragmas and older compilers.
...
See issue #5394 .
2018-09-28 13:00:44 +02:00
zhaozhao.zz
0c82d7285d
bugfix: replace lastcmd with cmd when rewrite BRPOPLPUSH as RPOPLPUSH
...
There are two problems if we use lastcmd:
1. BRPOPLPUSH cannot be rewrited as RPOPLPUSH in multi/exec
In mulit/exec context, the lastcmd is exec.
2. Redis will crash when execute RPOPLPUSH loading from AOF
In fakeClient, the lastcmd is NULL.
2018-09-28 12:06:48 +08:00
antirez
f32daa117d
Modules: hellodict example WIP #3 : KEYRANGE.
2018-09-27 17:01:35 +02:00
antirez
cda734caff
Modules: Modules: dictionary API WIP #13 : Compare API exported.
2018-09-27 11:46:22 +02:00
antirez
c50d4543cd
Modules: Modules: dictionary API WIP #12 : DictCompare API.
2018-09-27 11:44:25 +02:00
antirez
9b6124ab33
Modules: Modules: dictionary API WIP #11 : DictCompareC API.
2018-09-27 11:44:16 +02:00
antirez
6174c05b4d
Modules: hellodict example WIP #1 : GET command.
2018-09-27 11:22:43 +02:00
antirez
f0b362b933
Modules: hellodict example WIP #1 : SET command.
2018-09-26 17:52:12 +02:00
antirez
bcd42235b5
Modules: remove useless defines in hellotimer.c
2018-09-26 17:42:00 +02:00
antirez
203f8f239e
Modules: fix top comment of hellotimer.c
2018-09-26 17:41:08 +02:00