gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Add epoch information to failover auth denied logs (#816)

Browse Source 
When failover deny to vote, sometimes due to network or
some blocking operations, the time of FAILOVER_AUTH_REQUEST
packet arrival is very uncertain. Since there is no epoch
information in these logs, it is hard to associate the log
with other logs.

Signed-off-by: Binbin <binloveplay1314@qq.com>
This commit is contained in:
Binbin 2024-08-24 18:03:24 +08:00 committed by Madelyn Olson
parent b7b2c595c1
commit 7d27a7cffd
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cluster_legacy.c
View File

@ -4260,14 +4260,14 @@ void clusterSendFailoverAuthIfNeeded(clusterNode *node, clusterMsg *request) {
* with CLUSTERMSG_FLAG0_FORCEACK (manual failover). */
if (clusterNodeIsPrimary(node) || primary == NULL || (!nodeFailed(primary) && !force_ack)) {
if (clusterNodeIsPrimary(node)) {
serverLog(LL_WARNING, "Failover auth denied to %.40s (%s): it is a primary node", node->name,
node->human_nodename);
serverLog(LL_WARNING, "Failover auth denied to %.40s (%s) for epoch %llu: it is a primary node", node->name,
node->human_nodename, (unsigned long long)requestCurrentEpoch);
} else if (primary == NULL) {
serverLog(LL_WARNING, "Failover auth denied to %.40s (%s): I don't know its primary", node->name,
node->human_nodename);
serverLog(LL_WARNING, "Failover auth denied to %.40s (%s) for epoch %llu: I don't know its primary",
node->name, node->human_nodename, (unsigned long long)requestCurrentEpoch);
} else if (!nodeFailed(primary)) {
serverLog(LL_WARNING, "Failover auth denied to %.40s (%s): its primary is up", node->name,
node->human_nodename);
serverLog(LL_WARNING, "Failover auth denied to %.40s (%s) for epoch %llu: its primary is up", node->name,
node->human_nodename, (unsigned long long)requestCurrentEpoch);
}
return;
}