From 7d27a7cffd2006ec073aa8e7c3ec0885804101fd Mon Sep 17 00:00:00 2001 From: Binbin Date: Sat, 24 Aug 2024 18:03:24 +0800 Subject: [PATCH] Add epoch information to failover auth denied logs (#816) When failover deny to vote, sometimes due to network or some blocking operations, the time of FAILOVER_AUTH_REQUEST packet arrival is very uncertain. Since there is no epoch information in these logs, it is hard to associate the log with other logs. Signed-off-by: Binbin --- src/cluster_legacy.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c index 33ef7054e..4f1e09d4e 100644 --- a/src/cluster_legacy.c +++ b/src/cluster_legacy.c @@ -4260,14 +4260,14 @@ void clusterSendFailoverAuthIfNeeded(clusterNode *node, clusterMsg *request) { * with CLUSTERMSG_FLAG0_FORCEACK (manual failover). */ if (clusterNodeIsPrimary(node) || primary == NULL || (!nodeFailed(primary) && !force_ack)) { if (clusterNodeIsPrimary(node)) { - serverLog(LL_WARNING, "Failover auth denied to %.40s (%s): it is a primary node", node->name, - node->human_nodename); + serverLog(LL_WARNING, "Failover auth denied to %.40s (%s) for epoch %llu: it is a primary node", node->name, + node->human_nodename, (unsigned long long)requestCurrentEpoch); } else if (primary == NULL) { - serverLog(LL_WARNING, "Failover auth denied to %.40s (%s): I don't know its primary", node->name, - node->human_nodename); + serverLog(LL_WARNING, "Failover auth denied to %.40s (%s) for epoch %llu: I don't know its primary", + node->name, node->human_nodename, (unsigned long long)requestCurrentEpoch); } else if (!nodeFailed(primary)) { - serverLog(LL_WARNING, "Failover auth denied to %.40s (%s): its primary is up", node->name, - node->human_nodename); + serverLog(LL_WARNING, "Failover auth denied to %.40s (%s) for epoch %llu: its primary is up", node->name, + node->human_nodename, (unsigned long long)requestCurrentEpoch); } return; }