gvsafronov/tile38
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add deprecation warning for depricated threads flag

Browse Source
This commit is contained in:
Sepehr Rafiee 2021-05-09 07:48:56 +04:30 committed by tidwall
parent 552236f9f9
commit 2b6e7159d1
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/tile38-server/main.go
View File

@ -100,7 +100,6 @@ Advanced Options:
--queuefilename path : Event queue path (default:data/queue.db) --queuefilename path : Event queue path (default:data/queue.db)
--http-transport yes/no : HTTP transport (default: yes) --http-transport yes/no : HTTP transport (default: yes)
--protected-mode yes/no : protected mode (default: yes) --protected-mode yes/no : protected mode (default: yes)
--threads num : number of network threads (default: num cores)
--nohup : do not exit on SIGHUP --nohup : do not exit on SIGHUP
Developer Options: Developer Options:
@ -153,6 +152,7 @@ Developer Options:
} }
var showEvioDisabled bool var showEvioDisabled bool
var showThreadsDisabled bool
// parse non standard args. // parse non standard args.
nargs := []string{os.Args[0]} nargs := []string{os.Args[0]}
@ -230,15 +230,15 @@ Developer Options:
case "--threads", "-threads": case "--threads", "-threads":
i++ i++
if i < len(os.Args) { if i < len(os.Args) {
n, err := strconv.ParseUint(os.Args[i], 10, 16) _, err := strconv.ParseUint(os.Args[i], 10, 16)
if err != nil { if err != nil {
fmt.Fprintf(os.Stderr, "threads must be a valid number\n") fmt.Fprintf(os.Stderr, "threads must be a valid number\n")
os.Exit(1) os.Exit(1)
} }
core.NumThreads = int(n) showThreadsDisabled = true
continue continue
} }
fmt.Fprintf(os.Stderr, "http-transport must be 'yes' or 'no'\n") fmt.Fprintf(os.Stderr, "threads must be a valid number \n")
os.Exit(1) os.Exit(1)
case "--evio", "-evio": case "--evio", "-evio":
i++ i++
@ -410,6 +410,9 @@ Developer Options:
// we don't currently support evio in Tile38 // we don't currently support evio in Tile38
log.Warnf("evio is not currently supported") log.Warnf("evio is not currently supported")
} }
if showThreadsDisabled {
log.Warnf("thread flag is deprecated use GOMAXPROCS to set number of threads instead")
}
if err := server.Serve(host, port, dir, httpTransport); err != nil { if err := server.Serve(host, port, dir, httpTransport); err != nil {
log.Fatal(err) log.Fatal(err)
} }