From ef22ca17321933eb2bd54ff7975657babab18cdd Mon Sep 17 00:00:00 2001 From: Ted Lyngmo Date: Wed, 8 Mar 2017 06:25:41 +0100 Subject: [PATCH] Fix -Werror=effc++ errors with GNU 6.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix "'MyHandler::type’ should be initialized in the member initialization list [-Werror=effc++]" errors. https://github.com/miloyip/rapidjson/issues/874 --- example/simplepullreader/simplepullreader.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/example/simplepullreader/simplepullreader.cpp b/example/simplepullreader/simplepullreader.cpp index 1401829..a4fb116 100644 --- a/example/simplepullreader/simplepullreader.cpp +++ b/example/simplepullreader/simplepullreader.cpp @@ -16,13 +16,7 @@ struct MyHandler { const char* type; std::string data; - MyHandler() : type(), data() { Null(); } - MyHandler(const MyHandler& cpy) : type(cpy.type),data(cpy.data) {} - MyHandler& operator=(const MyHandler& cpy) { - type = cpy.type; - data = cpy.data; - return *this; - } + MyHandler() : type(), data() {} bool Null() { type = "Null"; data.clear(); return true; } bool Bool(bool b) { type = "Bool:"; data = b? "true": "false"; return true; } @@ -38,6 +32,9 @@ struct MyHandler { bool EndObject(SizeType memberCount) { type = "EndObject:"; data = stringify(memberCount); return true; } bool StartArray() { type = "StartArray"; data.clear(); return true; } bool EndArray(SizeType elementCount) { type = "EndArray:"; data = stringify(elementCount); return true; } +private: + MyHandler(const MyHandler& noCopyConstruction); + MyHandler& operator=(const MyHandler& noAssignment); }; int main() {