From a77b49dcb83e8bb2aac3c41a18a30a3e5749fede Mon Sep 17 00:00:00 2001 From: Yuval Hager Date: Fri, 26 Oct 2018 14:58:57 -0700 Subject: [PATCH 1/2] silence clang-7 self-assign-overloaded warning --- test/unittest/pointertest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unittest/pointertest.cpp b/test/unittest/pointertest.cpp index 8168d6b..a26723c 100644 --- a/test/unittest/pointertest.cpp +++ b/test/unittest/pointertest.cpp @@ -503,7 +503,7 @@ TEST(Pointer, Assignment) { EXPECT_STREQ("0", q.GetTokens()[1].name); EXPECT_EQ(0u, q.GetTokens()[1].index); EXPECT_NE(&p.GetAllocator(), &q.GetAllocator()); - q = q; + q = static_cast(q); EXPECT_TRUE(q.IsValid()); EXPECT_EQ(2u, q.GetTokenCount()); EXPECT_EQ(3u, q.GetTokens()[0].length); From 0cc44c82c98f72590ae99ac5cce765c9d73598cc Mon Sep 17 00:00:00 2001 From: "Philipp A. Hartmann" Date: Wed, 31 Oct 2018 20:31:04 -0700 Subject: [PATCH 2/2] Update test/unittest/pointertest.cpp Co-Authored-By: yhager --- test/unittest/pointertest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unittest/pointertest.cpp b/test/unittest/pointertest.cpp index a26723c..1280c86 100644 --- a/test/unittest/pointertest.cpp +++ b/test/unittest/pointertest.cpp @@ -503,7 +503,7 @@ TEST(Pointer, Assignment) { EXPECT_STREQ("0", q.GetTokens()[1].name); EXPECT_EQ(0u, q.GetTokens()[1].index); EXPECT_NE(&p.GetAllocator(), &q.GetAllocator()); - q = static_cast(q); + q = static_cast(q); EXPECT_TRUE(q.IsValid()); EXPECT_EQ(2u, q.GetTokenCount()); EXPECT_EQ(3u, q.GetTokens()[0].length);