gvsafronov/rapidjson
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing printf format warning

Browse Source 
In the BigNestedObject test case of valuetest.c, a dynamically
defined format is used that depends on the signedness of the
'SizeType' type. This allows the 'sprintf' function to use the correct
format for 'SizeType'.

Change-Id: I97222b699bda6c0ccfc9abbc5977c79e16605f2c
This commit is contained in:
Albert Hung 2023-08-14 13:21:46 +08:00 committed by Milo Yip
parent 30f54566ad
commit 956063dbc1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/unittest/valuetest.cpp
View File

@ -1649,10 +1649,11 @@ TEST(Value, BigNestedObject) {
MemoryPoolAllocator<> allocator; MemoryPoolAllocator<> allocator;
Value x(kObjectType); Value x(kObjectType);
static const SizeType n = 200; static const SizeType n = 200;
const char* format = std::numeric_limits<SizeType>::is_signed ? "%d" : "%u";
for (SizeType i = 0; i < n; i++) { for (SizeType i = 0; i < n; i++) {
char name1[10]; char name1[10];
sprintf(name1, "%d", i); sprintf(name1, format, i);
// Value name(name1); // should not compile // Value name(name1); // should not compile
Value name(name1, static_cast<SizeType>(strlen(name1)), allocator); Value name(name1, static_cast<SizeType>(strlen(name1)), allocator);
@ -1660,7 +1661,7 @@ TEST(Value, BigNestedObject) {
for (SizeType j = 0; j < n; j++) { for (SizeType j = 0; j < n; j++) {
char name2[10]; char name2[10];
sprintf(name2, "%d", j); sprintf(name2, format, j);
Value name3(name2, static_cast<SizeType>(strlen(name2)), allocator); Value name3(name2, static_cast<SizeType>(strlen(name2)), allocator);
Value number(static_cast<int>(i * n + j)); Value number(static_cast<int>(i * n + j));
@ -1673,11 +1674,11 @@ TEST(Value, BigNestedObject) {
for (SizeType i = 0; i < n; i++) { for (SizeType i = 0; i < n; i++) {
char name1[10]; char name1[10];
sprintf(name1, "%d", i); sprintf(name1, format, i);
for (SizeType j = 0; j < n; j++) { for (SizeType j = 0; j < n; j++) {
char name2[10]; char name2[10];
sprintf(name2, "%d", j); sprintf(name2, format, j);
x[name1]; x[name1];
EXPECT_EQ(static_cast<int>(i * n + j), x[name1][name2].GetInt()); EXPECT_EQ(static_cast<int>(i * n + j), x[name1][name2].GetInt());
} }