gvsafronov/rapidjson
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixup #964 by forwarding copyConstStrings recursively

Browse Source 
As reported by @Llerd in #962, the `copyConstStrings` parameter
has not been forwarded recursively to the constructors of
object members and array elements.
This commit is contained in:
Philipp A. Hartmann 2017-05-27 10:26:35 +02:00
parent 33443e63a9
commit 68c96e987b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/rapidjson/document.h
View File

@ -626,8 +626,8 @@ public:
Member* lm = reinterpret_cast<Member*>(allocator.Malloc(count * sizeof(Member))); Member* lm = reinterpret_cast<Member*>(allocator.Malloc(count * sizeof(Member)));
const typename GenericValue<Encoding,SourceAllocator>::Member* rm = rhs.GetMembersPointer(); const typename GenericValue<Encoding,SourceAllocator>::Member* rm = rhs.GetMembersPointer();
for (SizeType i = 0; i < count; i++) { for (SizeType i = 0; i < count; i++) {
new (&lm[i].name) GenericValue(rm[i].name, allocator); new (&lm[i].name) GenericValue(rm[i].name, allocator, copyConstStrings);
new (&lm[i].value) GenericValue(rm[i].value, allocator); new (&lm[i].value) GenericValue(rm[i].value, allocator, copyConstStrings);
} }
data_.f.flags = kObjectFlag; data_.f.flags = kObjectFlag;
data_.o.size = data_.o.capacity = count; data_.o.size = data_.o.capacity = count;
@ -639,7 +639,7 @@ public:
GenericValue* le = reinterpret_cast<GenericValue*>(allocator.Malloc(count * sizeof(GenericValue))); GenericValue* le = reinterpret_cast<GenericValue*>(allocator.Malloc(count * sizeof(GenericValue)));
const GenericValue<Encoding,SourceAllocator>* re = rhs.GetElementsPointer(); const GenericValue<Encoding,SourceAllocator>* re = rhs.GetElementsPointer();
for (SizeType i = 0; i < count; i++) for (SizeType i = 0; i < count; i++)
new (&le[i]) GenericValue(re[i], allocator); new (&le[i]) GenericValue(re[i], allocator, copyConstStrings);
data_.f.flags = kArrayFlag; data_.f.flags = kArrayFlag;
data_.a.size = data_.a.capacity = count; data_.a.size = data_.a.capacity = count;
SetElementsPointer(le); SetElementsPointer(le);