From 26c24d0bd91e0f060af83555d83d91e27ebd77b5 Mon Sep 17 00:00:00 2001 From: "Philipp A. Hartmann" Date: Thu, 21 Aug 2014 10:45:23 +0200 Subject: [PATCH] GenericMemberIterator: allow mixed-constness comparisons and differences --- include/rapidjson/document.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/rapidjson/document.h b/include/rapidjson/document.h index 983a363..965cefe 100644 --- a/include/rapidjson/document.h +++ b/include/rapidjson/document.h @@ -118,9 +118,9 @@ public: //! Iterator type itself typedef GenericMemberIterator Iterator; //! Constant iterator type - typedef GenericMemberIterator ConstType; + typedef GenericMemberIterator ConstIterator; //! Non-constant iterator type - typedef GenericMemberIterator NonConstType; + typedef GenericMemberIterator NonConstIterator; //! Pointer to (const) GenericMember typedef typename BaseType::pointer Pointer; @@ -151,7 +151,7 @@ public: constructor effectively defines a regular copy-constructor. Otherwise, the copy constructor is implicitly defined. */ - GenericMemberIterator(const NonConstType & it) : ptr_( it.ptr_ ) {} + GenericMemberIterator(const NonConstIterator & it) : ptr_(it.ptr_) {} //! @name stepping //@{ @@ -172,12 +172,12 @@ public: //! @name relations //@{ - bool operator==(Iterator that) const { return ptr_ == that.ptr_; } - bool operator!=(Iterator that) const { return ptr_ != that.ptr_; } - bool operator<=(Iterator that) const { return ptr_ <= that.ptr_; } - bool operator>=(Iterator that) const { return ptr_ >= that.ptr_; } - bool operator< (Iterator that) const { return ptr_ < that.ptr_; } - bool operator> (Iterator that) const { return ptr_ > that.ptr_; } + bool operator==(ConstIterator that) const { return ptr_ == that.ptr_; } + bool operator!=(ConstIterator that) const { return ptr_ != that.ptr_; } + bool operator<=(ConstIterator that) const { return ptr_ <= that.ptr_; } + bool operator>=(ConstIterator that) const { return ptr_ >= that.ptr_; } + bool operator< (ConstIterator that) const { return ptr_ < that.ptr_; } + bool operator> (ConstIterator that) const { return ptr_ > that.ptr_; } //@} //! @name dereference @@ -188,7 +188,7 @@ public: //@} //! Distance - DifferenceType operator-(Iterator that) const { return ptr_-that.ptr_; } + DifferenceType operator-(ConstIterator that) const { return ptr_-that.ptr_; } private: //! Internal constructor from plain pointer