f0c5052aa8
This commit enables tracking time of the background tasks and on replies, opening the door for properly tracking commands that rely on blocking / background work via the slowlog, latency history, and commandstats. Some notes: - The time spent blocked waiting for key changes, or blocked on synchronous replication is not accounted for. - **This commit does not affect latency tracking of commands that are non-blocking or do not have background work.** ( meaning that it all stays the same with exception to `BZPOPMIN`,`BZPOPMAX`,`BRPOP`,`BLPOP`, etc... and module's commands that rely on background threads ). - Specifically for latency history command we've added a new event class named `command-unblocking` that will enable latency monitoring on commands that spawn background threads to do the work. - For blocking commands we're now considering the total time of a command as the time spent on call() + the time spent on replying when unblocked. - For Modules commands that rely on background threads we're now considering the total time of a command as the time spent on call (main thread) + the time spent on the background thread ( if marked within `RedisModule_MeasureTimeStart()` and `RedisModule_MeasureTimeEnd()` ) + the time spent on replying (main thread) To test for this feature we've added a `unit/moduleapi/blockonbackground` test that relies on a module that blocks the client and sleeps on the background for a given time. - check blocked command that uses RedisModule_MeasureTimeStart() is tracking background time - check blocked command that uses RedisModule_MeasureTimeStart() is tracking background time even in timeout - check blocked command with multiple calls RedisModule_MeasureTimeStart() is tracking the total background time - check blocked command without calling RedisModule_MeasureTimeStart() is not reporting background time
68 lines
2.6 KiB
Tcl
68 lines
2.6 KiB
Tcl
set testmodule [file normalize tests/modules/blockonbackground.so]
|
|
|
|
source tests/support/util.tcl
|
|
|
|
start_server {tags {"modules"}} {
|
|
r module load $testmodule
|
|
|
|
test { blocked clients time tracking - check blocked command that uses RedisModule_BlockedClientMeasureTimeStart() is tracking background time} {
|
|
r slowlog reset
|
|
r config set slowlog-log-slower-than 200000
|
|
assert_equal [r slowlog len] 0
|
|
r block.debug 0 10000
|
|
assert_equal [r slowlog len] 0
|
|
r config resetstat
|
|
r block.debug 200 10000
|
|
assert_equal [r slowlog len] 1
|
|
|
|
set cmdstatline [cmdrstat block.debug r]
|
|
|
|
regexp "calls=1,usec=(.*?),usec_per_call=(.*?),rejected_calls=0,failed_calls=0" $cmdstatline usec usec_per_call
|
|
assert {$usec >= 100000}
|
|
assert {$usec_per_call >= 100000}
|
|
}
|
|
|
|
test { blocked clients time tracking - check blocked command that uses RedisModule_BlockedClientMeasureTimeStart() is tracking background time even in timeout } {
|
|
r slowlog reset
|
|
r config set slowlog-log-slower-than 200000
|
|
assert_equal [r slowlog len] 0
|
|
r block.debug 0 20000
|
|
assert_equal [r slowlog len] 0
|
|
r config resetstat
|
|
r block.debug 20000 200
|
|
assert_equal [r slowlog len] 1
|
|
|
|
set cmdstatline [cmdrstat block.debug r]
|
|
|
|
regexp "calls=1,usec=(.*?),usec_per_call=(.*?),rejected_calls=0,failed_calls=0" $cmdstatline usec usec_per_call
|
|
assert {$usec >= 100000}
|
|
assert {$usec_per_call >= 100000}
|
|
}
|
|
|
|
test { blocked clients time tracking - check blocked command with multiple calls RedisModule_BlockedClientMeasureTimeStart() is tracking the total background time } {
|
|
r slowlog reset
|
|
r config set slowlog-log-slower-than 200000
|
|
assert_equal [r slowlog len] 0
|
|
r block.double_debug 0
|
|
assert_equal [r slowlog len] 0
|
|
r config resetstat
|
|
r block.double_debug 100
|
|
assert_equal [r slowlog len] 1
|
|
|
|
set cmdstatline [cmdrstat block.double_debug r]
|
|
|
|
regexp "calls=1,usec=(.*?),usec_per_call=(.*?),rejected_calls=0,failed_calls=0" $cmdstatline usec usec_per_call
|
|
assert {$usec >= 60000}
|
|
assert {$usec_per_call >= 60000}
|
|
}
|
|
|
|
test { blocked clients time tracking - check blocked command without calling RedisModule_BlockedClientMeasureTimeStart() is not reporting background time } {
|
|
r slowlog reset
|
|
r config set slowlog-log-slower-than 200000
|
|
assert_equal [r slowlog len] 0
|
|
r block.debug_no_track 200 1000
|
|
# ensure slowlog is still empty
|
|
assert_equal [r slowlog len] 0
|
|
}
|
|
}
|