gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity
futriix/src
History
Binbin ecbfb6a7ec
Fix reconfiguring sub-replica causing data loss when myself change shard_id (#944) 
When reconfiguring sub-replica, there may a case that the sub-replica will
use the old offset and win the election and cause the data loss if the old
primary went down.

In this case, sender is myself's primary, when executing updateShardId,
not only the sender's shard_id is updated, but also the shard_id of
myself is updated, casuing the subsequent areInSameShard check, that is,
the full_sync_required check to fail.

As part of the recent fix of #885, the sub-replica needs to decide whether
a full sync is required or not when switching shards. This shard membership
check is supposed to be done against sub-replica's current shard_id, which
however was lost in this code path. This then leads to sub-replica joining
the other shard with a completely different and incorrect replication history.

This is the only place where replicaof state can be updated on this path
so the most natural fix would be to pull the chain replication reduction
logic into this code block and before the updateShardId call.

This one follow #885 and closes #942.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Co-authored-by: Ping Xie <pingxie@outlook.com>
2024-08-29 22:39:53 +08:00
..
commands
Add 4 commands for sentinel and update most test cases and json files (#789)
2024-08-16 09:46:36 -04:00
modules
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
unit
Remove unused valDup (#443)
2024-06-03 12:22:06 -07:00
.clang-format
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.clang-format-ignore
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.gitignore
Rename redis.info to valkey.info in LCOV (#259)
2024-04-10 08:59:45 +02:00
acl.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
adlist.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
adlist.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
ae_epoll.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
ae_evport.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_kqueue.c
Combine events to eliminate redundant kevent(2) calls (#638)
2024-06-16 21:18:20 -07:00
ae_select.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
ae.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
ae.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
anet.c
Add support for setting the group on a unix domain socket (#901)
2024-08-23 11:52:08 -07:00
anet.h
Add support for setting the group on a unix domain socket (#901)
2024-08-23 11:52:08 -07:00
aof.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
asciilogo.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
atomicvar.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
bio.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
bio.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
bitops.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
blocked.c
Make use of a single listNode pointer for blocking utility lists (#919)
2024-08-20 18:54:53 +08:00
call_reply.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
call_reply.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
childinfo.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
cli_commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_common.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
cli_common.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cluster_legacy.c
Fix reconfiguring sub-replica causing data loss when myself change shard_id (#944)
2024-08-29 22:39:53 +08:00
cluster_legacy.h
Improve cluster cant failover log conditions (#780)
2024-08-06 21:14:18 +08:00
cluster_slot_stats.c
Assert network bytes out for replication slot stat computation is only allowed on primary (#847)
2024-08-07 16:14:16 -07:00
cluster_slot_stats.h
Handle underflow condition of network out slot stats metric (#840)
2024-07-29 21:50:46 -07:00
cluster.c
Exclude '.' and ':' from isValidAuxChar's banned charset (#963)
2024-08-28 23:35:31 -07:00
cluster.h
Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)
2024-07-22 18:03:28 -07:00
commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
commands.def
Add 4 commands for sentinel and update most test cases and json files (#789)
2024-08-16 09:46:36 -04:00
commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
config.c
Remove dual-channel-replication Feature Flag's Protection (#908)
2024-08-27 10:18:48 -07:00
config.h
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
connection.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connection.h
Add support for setting the group on a unix domain socket (#901)
2024-08-23 11:52:08 -07:00
connhelpers.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
crc16_slottable.h
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
crc16.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
crc64.c
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crc64.h
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crccombine.c
Update serverpanic output based on 'extended-redis-compatibility' config. (#415)
2024-05-08 12:17:32 -07:00
crccombine.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.c
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
db.c
Revert make KEYS to be an exact match if there is no pattern (#964)
2024-08-29 10:58:19 +08:00
debug.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-08-27 14:43:01 -07:00
debugmacro.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
defrag.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
dict.c
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
dict.h
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
endianconv.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
endianconv.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
eval.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-08-27 14:43:01 -07:00
evict.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
expire.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
fmacros.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
fmtargs.h
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
function_lua.c
More rebranding (#606)
2024-06-07 01:40:55 +02:00
functions.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-08-27 14:43:01 -07:00
functions.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geo.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
geo.h
…
geohash_helper.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
geohash_helper.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
geohash.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
geohash.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
hyperloglog.c
Using intrinsics to optimize counting HyperLogLog trailing bits (#846)
2024-08-27 20:44:32 -07:00
intrinsics.h
Using intrinsics to optimize counting HyperLogLog trailing bits (#846)
2024-08-27 20:44:32 -07:00
intset.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
intset.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
io_threads.c
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
io_threads.h
Io thread work offload (#763)
2024-07-18 19:21:45 -07:00
kvstore.c
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
kvstore.h
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
latency.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
latency.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
lazyfree.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
listpack_malloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
listpack.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
listpack.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
localtime.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
logreqres.c
Replace client flags to bitfield (#614)
2024-06-30 11:33:10 -07:00
lolwut5.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
lolwut6.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
lolwut.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
lolwut.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
lzf_c.c
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzf_d.c
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzf.h
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzfP.h
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
Makefile
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
memory_prefetch.c
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
memory_prefetch.h
Improve multithreaded performance with memory prefetching (#861)
2024-08-26 21:10:44 -07:00
memtest.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
mkreleasehdr.sh
Update Server version to valkey version (#232)
2024-04-05 21:15:57 -07:00
module.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
monotonic.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
monotonic.h
Remove prototypes with empty declarations (#12020)
2023-05-02 17:31:32 -07:00
mt19937-64.c
Fix random element selection for large hash tables. (#8133)
2020-12-23 15:52:07 +02:00
mt19937-64.h
Fix random element selection for large hash tables. (#8133)
2020-12-23 15:52:07 +02:00
multi.c
free client's multi state when it becomes dirty (#961)
2024-08-29 19:20:53 +08:00
networking.c
Move prepareClientToWrite out of loop for lrange command to reduce the redundant call. (#860)
2024-08-27 19:11:09 -07:00
notify.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
object.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-08-27 14:43:01 -07:00
pqsort.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
pqsort.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
pubsub.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
quicklist.c
Replacing REDIS_STATIC with static (#691)
2024-06-26 09:47:59 -07:00
quicklist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rand.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rand.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rax_malloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rax.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rax.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rdb.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rdb.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rdma.c
Add support for setting the group on a unix domain socket (#901)
2024-08-23 11:52:08 -07:00
redismodule.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
release.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
replication.c
Fix data loss when replica do a failover with a old history repl offset (#885)
2024-08-21 13:11:21 +08:00
resp_parser.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
resp_parser.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rio.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
rio.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
script_lua.c
Limit tracking custom errors (e.g. from LUA) while allowing non custom errors to be tracked normally (#500)
2024-07-14 20:04:47 -07:00
script_lua.h
More rebranding (#606)
2024-06-07 01:40:55 +02:00
script.c
Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)
2024-07-22 18:03:28 -07:00
script.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sds.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-08-27 14:43:01 -07:00
sds.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
sdsalloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
sentinel.c
Add 4 commands for sentinel and update most test cases and json files (#789)
2024-08-16 09:46:36 -04:00
server.c
Add comment explaining log file reopening for rotation support (#956)
2024-08-27 21:00:17 -07:00
server.h
Move prepareClientToWrite out of loop for lrange command to reduce the redundant call. (#860)
2024-08-27 19:11:09 -07:00
serverassert.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
serverassert.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
setcpuaffinity.c
cpu affinity: DragonFlyBSD support (#7956)
2020-10-25 14:14:05 +02:00
setproctitle.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
sha1.c
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha1.h
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha256.c
Add sanitizer support and clean up sanitizer findings (#9601)
2021-11-11 13:51:33 +02:00
sha256.h
fix explanation of sha256 (#9220)
2021-07-10 10:04:54 -05:00
siphash.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
slowlog.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
slowlog.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
socket.c
Connection minor fixes (#953)
2024-08-27 16:11:33 +02:00
solarisfixes.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
sort.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
sparkline.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
sparkline.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
stream.h
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
strl.c
Change strlcat function name from redis to valkey (#440)
2024-05-06 00:09:01 -07:00
syncio.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
syscheck.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
syscheck.h
Add warning for suspected slow system clocksource setting (#10636)
2022-05-22 17:10:31 +03:00
t_hash.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
t_list.c
Move prepareClientToWrite out of loop for lrange command to reduce the redundant call. (#860)
2024-08-27 19:11:09 -07:00
t_set.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
t_stream.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
t_string.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
t_zset.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
testhelp.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
threads_mngr.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
threads_mngr.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
timeout.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
tls.c
Connection minor fixes (#953)
2024-08-27 16:11:33 +02:00
tracking.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
unix.c
Add support for setting the group on a unix domain socket (#901)
2024-08-23 11:52:08 -07:00
util.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
util.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
valgrind.sup
Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed
2020-12-06 14:54:34 +02:00
valkey-benchmark.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
valkey-check-aof.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
valkey-check-rdb.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
valkey-cli.c
valkey-cli make source node ignores NOREPLICAS when doing the last CLUSTER SETSLOT (#928)
2024-08-23 16:22:30 +08:00
valkeymodule.h
Dual stack and client-specific IPs in cluster (#736)
2024-07-10 13:53:52 +02:00
version.h
Change Redis to Valkey in log messages (#226)
2024-04-17 14:38:21 +02:00
ziplist.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
ziplist.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
zipmap.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
zipmap.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
zmalloc.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00
zmalloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-08-14 09:20:36 -07:00