d616925835
SET is a R+W command, because it can also do `GET` on the data. SET without GET is a write-only command. SET with GET is a read+write command. In #9974, we added ACL to let users define write-only access. So when the user uses SET with GET option, and the user doesn't have the READ permission on the key, we need to reject it, but we rather not reject users with write-only permissions from using the SET command when they don't use GET. In this commit, we add a `getkeys_proc` function to control key flags in SET command. We also add a new key spec flag (VARIABLE_FLAGS) means that some keys might have different flags depending on arguments. We also handle BITFIELD command, add a `bitfieldGetKeys` function. BITFIELD GET is a READ ONLY command. BITFIELD SET or BITFIELD INCR are READ WRITE commands. Other changes: 1. SET GET was added in 6.2, add the missing since in set.json 2. Added tests to cover the changes in acl-v2.tcl 3. Fix some typos in server.h and cleanups in acl-v2.tcl Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Oran Agra <oran@redislabs.com>
127 lines
3.6 KiB
JSON
127 lines
3.6 KiB
JSON
{
|
|
"BITFIELD": {
|
|
"summary": "Perform arbitrary bitfield integer operations on strings",
|
|
"complexity": "O(1) for each subcommand specified",
|
|
"group": "bitmap",
|
|
"since": "3.2.0",
|
|
"arity": -2,
|
|
"function": "bitfieldCommand",
|
|
"get_keys_function": "bitfieldGetKeys",
|
|
"command_flags": [
|
|
"WRITE",
|
|
"DENYOOM"
|
|
],
|
|
"acl_categories": [
|
|
"BITMAP"
|
|
],
|
|
"key_specs": [
|
|
{
|
|
"flags": [
|
|
"RW",
|
|
"UPDATE",
|
|
"ACCESS",
|
|
"VARIABLE_FLAGS"
|
|
],
|
|
"begin_search": {
|
|
"index": {
|
|
"pos": 1
|
|
}
|
|
},
|
|
"find_keys": {
|
|
"range": {
|
|
"lastkey": 0,
|
|
"step": 1,
|
|
"limit": 0
|
|
}
|
|
}
|
|
}
|
|
],
|
|
"arguments": [
|
|
{
|
|
"name": "key",
|
|
"type": "key",
|
|
"key_spec_index": 0
|
|
},
|
|
{
|
|
"token": "GET",
|
|
"name": "encoding_offset",
|
|
"type": "block",
|
|
"optional": true,
|
|
"arguments": [
|
|
{
|
|
"name": "encoding",
|
|
"type": "string"
|
|
},
|
|
{
|
|
"name": "offset",
|
|
"type": "integer"
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"token": "SET",
|
|
"name": "encoding_offset_value",
|
|
"type": "block",
|
|
"optional": true,
|
|
"arguments": [
|
|
{
|
|
"name": "encoding",
|
|
"type": "string"
|
|
},
|
|
{
|
|
"name": "offset",
|
|
"type": "integer"
|
|
},
|
|
{
|
|
"name": "value",
|
|
"type": "integer"
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"token": "INCRBY",
|
|
"name": "encoding_offset_increment",
|
|
"type": "block",
|
|
"optional": true,
|
|
"arguments": [
|
|
{
|
|
"name": "encoding",
|
|
"type": "string"
|
|
},
|
|
{
|
|
"name": "offset",
|
|
"type": "integer"
|
|
},
|
|
{
|
|
"name": "increment",
|
|
"type": "integer"
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"token": "OVERFLOW",
|
|
"name": "wrap_sat_fail",
|
|
"type": "oneof",
|
|
"optional": true,
|
|
"arguments": [
|
|
{
|
|
"name": "wrap",
|
|
"type": "pure-token",
|
|
"token": "WRAP"
|
|
},
|
|
{
|
|
"name": "sat",
|
|
"type": "pure-token",
|
|
"token": "SAT"
|
|
},
|
|
{
|
|
"name": "fail",
|
|
"type": "pure-token",
|
|
"token": "FAIL"
|
|
}
|
|
]
|
|
}
|
|
]
|
|
}
|
|
}
|