gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
futriix/src
History
Binbin d309b9b235
Make configs dir/dbfilename/cluster-config-file reject empty string (#636) 
Until now, these configuration items allowed typing empty strings,
but empty strings behave strangely.

Empty dir will fail in chdir with No such file or directory:
```
./src/valkey-server --dir ""

*** FATAL CONFIG FILE ERROR (Version 255.255.255) ***
Reading the configuration file, at line 2
>>> 'dir ""'
No such file or directory
```

Empty dbfilename will cause shutdown to fail since it will
always fail in rdb save:
```
./src/valkey-server --dbfilename ""

 * User requested shutdown...
 * Saving the final RDB snapshot before exiting.
 # Error moving temp DB file temp-19530.rdb on the final destination  (in server root dir /xxx/xxx/valkey): No such file or directory
 # Error trying to save the DB, can't exit.
 # Errors trying to shut down the server. Check the logs for more information.
```

Empty cluster-config-file will fail in clusterLockConfig:
```
./src/valkey-server --cluster-enabled yes --cluster-config-file ""

 Can't open  in order to acquire a lock: No such file or directory
```

With this patch, now we will just reject it in config set like:
```
*** FATAL CONFIG FILE ERROR (Version 255.255.255) ***
Reading the configuration file, at line 2
>>> 'xxx ""'
xxx can't be empty
```

Signed-off-by: Binbin <binloveplay1314@qq.com>
2024-06-14 01:47:20 +02:00
..
commands
Allow CLUSTER NODES/INFO/MYID/MYSHARDID during loading state (#596)
2024-06-13 06:09:01 +02:00
modules
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
unit
Remove unused valDup (#443)
2024-06-03 12:22:06 -07:00
.clang-format
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.clang-format-ignore
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.gitignore
Rename redis.info to valkey.info in LCOV (#259)
2024-04-10 08:59:45 +02:00
acl.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
adlist.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
adlist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_epoll.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_evport.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_kqueue.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_select.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
anet.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
anet.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
aof.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
asciilogo.h
Prevent clang-format in certain places (#468)
2024-05-08 20:58:53 +02:00
atomicvar.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
bio.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
bio.h
Implementing the WAITAOF command (issue #10505) (#11713)
2023-03-14 20:26:21 +02:00
bitops.c
Fix bitops.c clang-format properly (#570)
2024-05-28 21:49:50 -07:00
blocked.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
call_reply.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
call_reply.h
Remove REDISMODULE_ prefixes and introduce compatibility header (#194)
2024-04-05 16:59:55 -07:00
childinfo.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_common.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_common.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cluster_legacy.c
Fix misuse of safe iterators (#612)
2024-06-10 12:30:57 -07:00
cluster_legacy.h
represent cluster node flags with bitwise shift value (#642)
2024-06-14 00:58:03 +02:00
cluster.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
cluster.h
Replicate slot migration states via RDB aux fields (#586)
2024-06-07 20:32:27 -07:00
commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
commands.def
Allow CLUSTER NODES/INFO/MYID/MYSHARDID during loading state (#596)
2024-06-13 06:09:01 +02:00
commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
config.c
Make configs dir/dbfilename/cluster-config-file reject empty string (#636)
2024-06-14 01:47:20 +02:00
config.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connection.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connection.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connhelpers.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
crc16_slottable.h
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
crc16.c
RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.
2015-07-26 15:17:18 +02:00
crc64.c
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crc64.h
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crccombine.c
Update serverpanic output based on 'extended-redis-compatibility' config. (#415)
2024-05-08 12:17:32 -07:00
crccombine.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.c
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
db.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
debug.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
debugmacro.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
defrag.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
dict.c
Fix misuse of safe iterators (#612)
2024-06-10 12:30:57 -07:00
dict.h
Remove unused valDup (#443)
2024-06-03 12:22:06 -07:00
endianconv.c
Migrate endianconv.c unit tests to new test framework (#458)
2024-05-12 16:58:50 -07:00
endianconv.h
Migrate endianconv.c unit tests to new test framework (#458)
2024-05-12 16:58:50 -07:00
eval.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
evict.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
expire.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
fmacros.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
fmtargs.h
Rewrite huge printf calls to smaller ones for readability (#12257)
2023-09-28 09:21:23 +03:00
function_lua.c
More rebranding (#606)
2024-06-07 01:40:55 +02:00
functions.c
Remove unused valDup (#443)
2024-06-03 12:22:06 -07:00
functions.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geo.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geo.h
RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.
2015-07-26 15:17:18 +02:00
geohash_helper.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geohash_helper.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geohash.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geohash.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
hyperloglog.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
intset.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
intset.h
Remove intsettest declaration from intset.h (#471)
2024-05-08 12:38:50 -07:00
kvstore.c
Fix misuse of safe iterators (#612)
2024-06-10 12:30:57 -07:00
kvstore.h
Fix misuse of safe iterators (#612)
2024-06-10 12:30:57 -07:00
latency.c
Replicate slot migration states via RDB aux fields (#586)
2024-06-07 20:32:27 -07:00
latency.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lazyfree.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
listpack_malloc.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
listpack.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
listpack.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
localtime.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
logreqres.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
lolwut5.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut6.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut.h
add include guard for lolwut.h
2020-05-05 23:35:08 -04:00
lzf_c.c
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzf_d.c
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzf.h
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzfP.h
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
Makefile
src/Makefile: Link libatomic on POWER systems (#607)
2024-06-09 15:09:08 -07:00
memtest.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
mkreleasehdr.sh
Update Server version to valkey version (#232)
2024-04-05 21:15:57 -07:00
module.c
Moving client->authenticated to a flag instead of an int (#592)
2024-06-09 11:49:05 -07:00
monotonic.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
monotonic.h
Remove prototypes with empty declarations (#12020)
2023-05-02 17:31:32 -07:00
mt19937-64.c
Fix random element selection for large hash tables. (#8133)
2020-12-23 15:52:07 +02:00
mt19937-64.h
Fix random element selection for large hash tables. (#8133)
2020-12-23 15:52:07 +02:00
multi.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
networking.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
notify.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
object.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
pqsort.c
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
pqsort.h
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
pubsub.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
quicklist.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
quicklist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rand.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rand.h
Rename 'redis' to 'server' and redisNodeFlags to clusterNodeFlags (#191)
2024-04-03 18:45:23 -07:00
rax_malloc.h
Cluster: hash slots tracking using a radix tree.
2017-03-27 16:37:22 +02:00
rax.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rax.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rdb.c
Replicate slot migration states via RDB aux fields (#586)
2024-06-07 20:32:27 -07:00
rdb.h
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
redismodule.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
release.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
replication.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
resp_parser.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
resp_parser.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rio.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rio.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
script_lua.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
script_lua.h
More rebranding (#606)
2024-06-07 01:40:55 +02:00
script.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
script.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sds.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
sds.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sdsalloc.h
Adjust sds types (#502)
2024-06-02 20:55:54 -07:00
sentinel.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
server.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
server.h
Moving client->authenticated to a flag instead of an int (#592)
2024-06-09 11:49:05 -07:00
serverassert.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
serverassert.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
setcpuaffinity.c
cpu affinity: DragonFlyBSD support (#7956)
2020-10-25 14:14:05 +02:00
setproctitle.c
Fix failed tests on Linux Alpine and add a CI job. (#8532)
2021-02-23 12:57:45 +02:00
sha1.c
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha1.h
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha256.c
Add sanitizer support and clean up sanitizer findings (#9601)
2021-11-11 13:51:33 +02:00
sha256.h
fix explanation of sha256 (#9220)
2021-07-10 10:04:54 -05:00
siphash.c
Better standardize around assertions (#12539)
2023-10-02 18:58:44 -07:00
slowlog.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
slowlog.h
[Fix] move deps from slowlog.c into slowlog.h (#465)
2024-05-09 14:29:18 -07:00
socket.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
solarisfixes.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sort.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sparkline.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sparkline.h
LATENCY GRAPH implemented.
2014-07-02 16:31:22 +02:00
stream.h
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
strl.c
Change strlcat function name from redis to valkey (#440)
2024-05-06 00:09:01 -07:00
syncio.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
syscheck.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
syscheck.h
Add warning for suspected slow system clocksource setting (#10636)
2022-05-22 17:10:31 +03:00
t_hash.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_list.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_set.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_stream.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
t_string.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_zset.c
Remove unused valDup (#443)
2024-06-03 12:22:06 -07:00
testhelp.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
threads_mngr.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
threads_mngr.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
timeout.c
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
tls.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
tracking.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
unix.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
util.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
util.h
Implement REPLCONF VERSION (#554)
2024-05-27 23:03:34 +02:00
valgrind.sup
Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed
2020-12-06 14:54:34 +02:00
valkey-benchmark.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
valkey-check-aof.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
valkey-check-rdb.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
valkey-cli.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
valkeymodule.h
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
version.h
Change Redis to Valkey in log messages (#226)
2024-04-17 14:38:21 +02:00
ziplist.c
Remove unnecessary clang-format off annotations (#628)
2024-06-12 12:52:18 +02:00
ziplist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
zipmap.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
zipmap.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
zmalloc.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
zmalloc.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00