b099889a3a
This PR handles several aspects 1. Calls to RM_ReplyWithError from thread safe contexts don't violate thread safety. 2. Errors returning from RM_Call to the module aren't counted in the statistics (they might be handled silently by the module) 3. When a module propagates a reply it got from RM_Call to it's client, then the error statistics are counted. This is done by: 1. When appending an error reply to the output buffer, we avoid updating the global error statistics, instead we cache that error in a deferred list in the client struct. 2. When creating a RedisModuleCallReply object, the deferred error list is moved from the client into that object. 3. when a module calls RM_ReplyWithCallReply we copy the deferred replies to the dest client (if that's a real client, then that's when the error statistics are updated to the server) Note about RM_ReplyWithCallReply: if the original reply had an array with errors, and the module replied with just a portion of the original reply, and not the entire reply, the errors are currently not propagated and the errors stats will not get propagated. Fix #10180
58 lines
2.8 KiB
C
58 lines
2.8 KiB
C
/*
|
|
* Copyright (c) 2009-2021, Redis Labs Ltd.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of Redis nor the names of its contributors may be used
|
|
* to endorse or promote products derived from this software without
|
|
* specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SRC_CALL_REPLY_H_
|
|
#define SRC_CALL_REPLY_H_
|
|
|
|
#include "resp_parser.h"
|
|
|
|
typedef struct CallReply CallReply;
|
|
|
|
CallReply *callReplyCreate(sds reply, list *deferred_error_list, void *private_data);
|
|
int callReplyType(CallReply *rep);
|
|
const char *callReplyGetString(CallReply *rep, size_t *len);
|
|
long long callReplyGetLongLong(CallReply *rep);
|
|
double callReplyGetDouble(CallReply *rep);
|
|
int callReplyGetBool(CallReply *rep);
|
|
size_t callReplyGetLen(CallReply *rep);
|
|
CallReply *callReplyGetArrayElement(CallReply *rep, size_t idx);
|
|
CallReply *callReplyGetSetElement(CallReply *rep, size_t idx);
|
|
int callReplyGetMapElement(CallReply *rep, size_t idx, CallReply **key, CallReply **val);
|
|
CallReply *callReplyGetAttribute(CallReply *rep);
|
|
int callReplyGetAttributeElement(CallReply *rep, size_t idx, CallReply **key, CallReply **val);
|
|
const char *callReplyGetBigNumber(CallReply *rep, size_t *len);
|
|
const char *callReplyGetVerbatim(CallReply *rep, size_t *len, const char **format);
|
|
const char *callReplyGetProto(CallReply *rep, size_t *len);
|
|
void *callReplyGetPrivateData(CallReply *rep);
|
|
int callReplyIsResp3(CallReply *rep);
|
|
list *callReplyDeferredErrorList(CallReply *rep);
|
|
void freeCallReply(CallReply *rep);
|
|
|
|
#endif /* SRC_CALL_REPLY_H_ */
|