gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
futriix/src
History
poiuj 417660449f
Adjust sds types (#502) 
sds type should be determined based on the size of the underlying
buffer, not the logical length of the sds. Currently we truncate the
alloc field in case buffer is larger than we can handle. It leads to a
mismatch between alloc field and the actual size of the buffer. Even
considering that alloc doesn't include header size and the null
terminator.

It also leads to a waste of memory with jemalloc. For example, let's
consider creation of sds of length 253. According to the length, the
appropriate type is SDS_TYPE_8. But we allocate `253 + sizeof(struct
sdshdr8) + 1` bytes, which sums to 257 bytes. In this case jemalloc
allocates buffer from the next size bucket. With current configuration
on Linux it's 320 bytes. So we end up with 320 bytes buffer, while we
can't address more than 255.

The same happens with other types and length close enough to the
appropriate powers of 2.

The downside of the adjustment is that with allocators that do not
allocate larger than requested chunks (like GNU allocator), we switch to
a larger type "too early". It leads to small waste of memory.
Specifically: sds of length 31 takes 35 bytes instead of 33 (2 bytes
wasted) sds of length 255 takes 261 bytes instead of 259 (2 bytes
wasted) sds of length 65,535 takes 65,545 bytes instead of 65,541 (4
bytes wasted) sds of length 4,294,967,295 takes 4,294,967,313 bytes
instead of 4,294,967,305 (8 bytes wasted)

---------

Signed-off-by: Vadym Khoptynets <vadymkh@amazon.com>
2024-06-02 20:55:54 -07:00
..
commands
Change BITCOUNT 'end' as optional like BITPOS (#118)
2024-05-28 15:01:28 -04:00
modules
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
unit
Adjust sds types (#502)
2024-06-02 20:55:54 -07:00
.clang-format
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.clang-format-ignore
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.gitignore
Rename redis.info to valkey.info in LCOV (#259)
2024-04-10 08:59:45 +02:00
acl.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
adlist.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
adlist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_epoll.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_evport.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_kqueue.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_select.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
anet.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
anet.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
aof.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
asciilogo.h
Prevent clang-format in certain places (#468)
2024-05-08 20:58:53 +02:00
atomicvar.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
bio.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
bio.h
Implementing the WAITAOF command (issue #10505) (#11713)
2023-03-14 20:26:21 +02:00
bitops.c
Fix bitops.c clang-format properly (#570)
2024-05-28 21:49:50 -07:00
blocked.c
Consolidate various BLOCKED_WAIT* states (#562)
2024-05-30 23:45:47 -07:00
call_reply.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
call_reply.h
Remove REDISMODULE_ prefixes and introduce compatibility header (#194)
2024-04-05 16:59:55 -07:00
childinfo.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_common.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_common.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cluster_legacy.c
Consolidate various BLOCKED_WAIT* states (#562)
2024-05-30 23:45:47 -07:00
cluster_legacy.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cluster.c
Make cluster replicas return ASK and TRYAGAIN (#495)
2024-05-24 17:58:03 +02:00
cluster.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
commands.def
Change BITCOUNT 'end' as optional like BITPOS (#118)
2024-05-28 15:01:28 -04:00
commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
config.c
Enable debug asserts for cluster and sentinel tests (#588)
2024-06-02 13:15:08 -07:00
config.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connection.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connection.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connhelpers.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
crc16_slottable.h
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
crc16.c
…
crc64.c
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crc64.h
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crccombine.c
Update serverpanic output based on 'extended-redis-compatibility' config. (#415)
2024-05-08 12:17:32 -07:00
crccombine.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.c
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
db.c
Unshare object to avoid LRU/LFU being messed up (#250)
2024-06-01 10:09:20 +02:00
debug.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
debugmacro.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
defrag.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
dict.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
dict.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
endianconv.c
Migrate endianconv.c unit tests to new test framework (#458)
2024-05-12 16:58:50 -07:00
endianconv.h
Migrate endianconv.c unit tests to new test framework (#458)
2024-05-12 16:58:50 -07:00
eval.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
evict.c
Require C11 atomics (#490)
2024-05-26 18:41:11 +02:00
expire.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
fmacros.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
fmtargs.h
Rewrite huge printf calls to smaller ones for readability (#12257)
2023-09-28 09:21:23 +03:00
function_lua.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
functions.c
Require C11 atomics (#490)
2024-05-26 18:41:11 +02:00
functions.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geo.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geo.h
…
geohash_helper.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geohash_helper.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geohash.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geohash.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
hyperloglog.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
intset.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
intset.h
Remove intsettest declaration from intset.h (#471)
2024-05-08 12:38:50 -07:00
kvstore.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
kvstore.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
latency.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
latency.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lazyfree.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
listpack_malloc.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
listpack.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
listpack.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
localtime.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
logreqres.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut5.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut6.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
lolwut.h
…
lzf_c.c
…
lzf_d.c
…
lzf.h
…
lzfP.h
…
Makefile
Fix build error for unit test (#473)
2024-05-08 14:52:21 -04:00
memtest.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
mkreleasehdr.sh
Update Server version to valkey version (#232)
2024-04-05 21:15:57 -07:00
module.c
Require C11 atomics (#490)
2024-05-26 18:41:11 +02:00
monotonic.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
monotonic.h
Remove prototypes with empty declarations (#12020)
2023-05-02 17:31:32 -07:00
mt19937-64.c
…
mt19937-64.h
…
multi.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
networking.c
Consolidate various BLOCKED_WAIT* states (#562)
2024-05-30 23:45:47 -07:00
notify.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
object.c
Enable debug asserts for cluster and sentinel tests (#588)
2024-06-02 13:15:08 -07:00
pqsort.c
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
pqsort.h
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
pubsub.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
quicklist.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
quicklist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rand.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rand.h
Rename 'redis' to 'server' and redisNodeFlags to clusterNodeFlags (#191)
2024-04-03 18:45:23 -07:00
rax_malloc.h
…
rax.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rax.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rdb.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
rdb.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
redismodule.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
release.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
replication.c
Consolidate various BLOCKED_WAIT* states (#562)
2024-05-30 23:45:47 -07:00
resp_parser.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
resp_parser.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rio.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rio.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
script_lua.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
script_lua.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
script.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
script.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sds.c
Adjust sds types (#502)
2024-06-02 20:55:54 -07:00
sds.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sdsalloc.h
Adjust sds types (#502)
2024-06-02 20:55:54 -07:00
sentinel.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
server.c
Fix crash where command duration is not reset when client is blocked … (#526)
2024-05-30 12:55:00 -07:00
server.h
Enable debug asserts for cluster and sentinel tests (#588)
2024-06-02 13:15:08 -07:00
serverassert.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
serverassert.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
setcpuaffinity.c
…
setproctitle.c
…
sha1.c
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha1.h
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha256.c
…
sha256.h
…
siphash.c
Better standardize around assertions (#12539)
2023-10-02 18:58:44 -07:00
slowlog.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
slowlog.h
[Fix] move deps from slowlog.c into slowlog.h (#465)
2024-05-09 14:29:18 -07:00
socket.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
solarisfixes.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sort.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sparkline.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sparkline.h
…
stream.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
strl.c
Change strlcat function name from redis to valkey (#440)
2024-05-06 00:09:01 -07:00
syncio.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
syscheck.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
syscheck.h
Add warning for suspected slow system clocksource setting (#10636)
2022-05-22 17:10:31 +03:00
t_hash.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_list.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_set.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_stream.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_string.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
t_zset.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
testhelp.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
threads_mngr.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
threads_mngr.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
timeout.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
tls.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
tracking.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
unix.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
util.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
util.h
Implement REPLCONF VERSION (#554)
2024-05-27 23:03:34 +02:00
valgrind.sup
…
valkey-benchmark.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
valkey-check-aof.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
valkey-check-rdb.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
valkey-cli.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
valkeymodule.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
version.h
Change Redis to Valkey in log messages (#226)
2024-04-17 14:38:21 +02:00
ziplist.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ziplist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
zipmap.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
zipmap.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
zmalloc.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
zmalloc.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00