42c8c61813
This PR is to fix the compilation warnings and errors generated by the latest
complier toolchain, and to add a new runner of the latest toolchain for daily CI.
## Fix various compilation warnings and errors
1) jemalloc.c
COMPILER: clang-14 with FORTIFY_SOURCE
WARNING:
```
src/jemalloc.c:1028:7: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]
"/etc/malloc.conf",
^
src/jemalloc.c:1027:3: note: place parentheses around the string literal to silence warning
"\"name\" of the file referenced by the symbolic link named "
^
```
REASON: the compiler to alert developers to potential issues with string concatenation
that may miss a comma,
just like #9534 which misses a comma.
SOLUTION: use `()` to tell the compiler that these two line strings are continuous.
2) config.h
COMPILER: clang-14 with FORTIFY_SOURCE
WARNING:
```
In file included from quicklist.c:36:
./config.h:319:76: warning: attribute declaration must precede definition [-Wignored-attributes]
char *strcat(char *restrict dest, const char *restrict src) __attribute__((deprecated("please avoid use of unsafe C functions. prefer use of redis_strlcat instead")));
```
REASON: Enabling _FORTIFY_SOURCE will cause the compiler to use `strcpy()` with check,
it results in a deprecated attribute declaration after including <features.h>.
SOLUTION: move the deprecated attribute declaration from config.h to fmacro.h before "#include <features.h>".
3) networking.c
COMPILER: GCC-12
WARNING:
```
networking.c: In function ‘addReplyDouble.part.0’:
networking.c:876:21: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
876 | dbuf[start] = '$';
| ^
networking.c:868:14: note: at offset -5 into destination object ‘dbuf’ of size 5152
868 | char dbuf[MAX_LONG_DOUBLE_CHARS+32];
| ^
networking.c:876:21: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
876 | dbuf[start] = '$';
| ^
networking.c:868:14: note: at offset -6 into destination object ‘dbuf’ of size 5152
868 | char dbuf[MAX_LONG_DOUBLE_CHARS+32];
```
REASON: GCC-12 predicts that digits10() may return 9 or 10 through `return 9 + (v >= 1000000000UL)`.
SOLUTION: add an assert to let the compiler know the possible length;
4) redis-cli.c & redis-benchmark.c
COMPILER: clang-14 with FORTIFY_SOURCE
WARNING:
```
redis-benchmark.c:1621:2: warning: embedding a directive within macro arguments has undefined behavior [-Wembedded-directive] #ifdef USE_OPENSSL
redis-cli.c:3015:2: warning: embedding a directive within macro arguments has undefined behavior [-Wembedded-directive] #ifdef USE_OPENSSL
```
REASON: when _FORTIFY_SOURCE is enabled, the compiler will use the print() with
check, which is a macro. this may result in the use of directives within the macro, which
is undefined behavior.
SOLUTION: move the directives-related code out of `print()`.
5) server.c
COMPILER: gcc-13 with FORTIFY_SOURCE
WARNING:
```
In function 'lookupCommandLogic',
inlined from 'lookupCommandBySdsLogic' at server.c:3139:32:
server.c:3102:66: error: '*(robj **)argv' may be used uninitialized [-Werror=maybe-uninitialized]
3102 | struct redisCommand *base_cmd = dictFetchValue(commands, argv[0]->ptr);
| ~~~~^~~
```
REASON: The compiler thinks that the `argc` returned by `sdssplitlen()` could be 0,
resulting in an empty array of size 0 being passed to lookupCommandLogic.
this should be a false positive, `argc` can't be 0 when strings are not NULL.
SOLUTION: add an assert to let the compiler know that `argc` is positive.
6) sha1.c
COMPILER: gcc-12
WARNING:
```
In function ‘SHA1Update’,
inlined from ‘SHA1Final’ at sha1.c:195:5:
sha1.c:152:13: warning: ‘SHA1Transform’ reading 64 bytes from a region of size 0 [-Wstringop-overread]
152 | SHA1Transform(context->state, &data[i]);
| ^
sha1.c:152:13: note: referencing argument 2 of type ‘const unsigned char[64]’
sha1.c: In function ‘SHA1Final’:
sha1.c:56:6: note: in a call to function ‘SHA1Transform’
56 | void SHA1Transform(uint32_t state[5], const unsigned char buffer[64])
| ^
In function ‘SHA1Update’,
inlined from ‘SHA1Final’ at sha1.c:198:9:
sha1.c:152:13: warning: ‘SHA1Transform’ reading 64 bytes from a region of size 0 [-Wstringop-overread]
152 | SHA1Transform(context->state, &data[i]);
| ^
sha1.c:152:13: note: referencing argument 2 of type ‘const unsigned char[64]’
sha1.c: In function ‘SHA1Final’:
sha1.c:56:6: note: in a call to function ‘SHA1Transform’
56 | void SHA1Transform(uint32_t state[5], const unsigned char buffer[64])
```
REASON: due to the bug[https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80922], when
enable LTO, gcc-12 will not see `diagnostic ignored "-Wstringop-overread"`, resulting in a warning.
SOLUTION: temporarily set SHA1Update to noinline to avoid compiler warnings due
to LTO being enabled until the above gcc bug is fixed.
7) zmalloc.h
COMPILER: GCC-12
WARNING:
```
In function ‘memset’,
inlined from ‘moduleCreateContext’ at module.c:877:5,
inlined from ‘RM_GetDetachedThreadSafeContext’ at module.c:8410:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:59:10: warning: ‘__builtin_memset’ writing 104 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
59 | return __builtin___memset_chk (__dest, __ch, __len,
```
REASON: due to the GCC-12 bug [https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96503],
GCC-12 cannot see alloc_size, which causes GCC to think that the actual size of memory
is 0 when checking with __glibc_objsize0().
SOLUTION: temporarily set malloc-related interfaces to `noinline` to avoid compiler warnings
due to LTO being enabled until the above gcc bug is fixed.
## Other changes
1) Fixed `ps -p [pid]` doesn't output `<defunct>` when using procps 4.x causing `replication
child dies when parent is killed - diskless` test to fail.
2) Add a new fortify CI with GCC-13 and ubuntu-lunar docker image.
318 lines
9.4 KiB
C
318 lines
9.4 KiB
C
/*
|
|
* Copyright (c) 2009-2012, Salvatore Sanfilippo <antirez at gmail dot com>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of Redis nor the names of its contributors may be used
|
|
* to endorse or promote products derived from this software without
|
|
* specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef __CONFIG_H
|
|
#define __CONFIG_H
|
|
|
|
#ifdef __APPLE__
|
|
#include <fcntl.h> // for fcntl(fd, F_FULLFSYNC)
|
|
#include <AvailabilityMacros.h>
|
|
#endif
|
|
|
|
#ifdef __linux__
|
|
#include <features.h>
|
|
#include <fcntl.h>
|
|
#endif
|
|
|
|
/* Define redis_fstat to fstat or fstat64() */
|
|
#if defined(__APPLE__) && !defined(MAC_OS_X_VERSION_10_6)
|
|
#define redis_fstat fstat64
|
|
#define redis_stat stat64
|
|
#else
|
|
#define redis_fstat fstat
|
|
#define redis_stat stat
|
|
#endif
|
|
|
|
/* Test for proc filesystem */
|
|
#ifdef __linux__
|
|
#define HAVE_PROC_STAT 1
|
|
#define HAVE_PROC_MAPS 1
|
|
#define HAVE_PROC_SMAPS 1
|
|
#define HAVE_PROC_SOMAXCONN 1
|
|
#define HAVE_PROC_OOM_SCORE_ADJ 1
|
|
#endif
|
|
|
|
/* Test for task_info() */
|
|
#if defined(__APPLE__)
|
|
#define HAVE_TASKINFO 1
|
|
#endif
|
|
|
|
/* Test for somaxconn check */
|
|
#if defined(__APPLE__) || defined(__FreeBSD__)
|
|
#define HAVE_SYSCTL_KIPC_SOMAXCONN 1
|
|
#elif defined(__OpenBSD__)
|
|
#define HAVE_SYSCTL_KERN_SOMAXCONN 1
|
|
#endif
|
|
|
|
/* Test for backtrace() */
|
|
#if defined(__APPLE__) || (defined(__linux__) && defined(__GLIBC__)) || \
|
|
defined(__FreeBSD__) || ((defined(__OpenBSD__) || defined(__NetBSD__) || defined(__sun)) && defined(USE_BACKTRACE))\
|
|
|| defined(__DragonFly__) || (defined(__UCLIBC__) && defined(__UCLIBC_HAS_BACKTRACE__))
|
|
#define HAVE_BACKTRACE 1
|
|
#endif
|
|
|
|
/* MSG_NOSIGNAL. */
|
|
#ifdef __linux__
|
|
#define HAVE_MSG_NOSIGNAL 1
|
|
#if defined(SO_MARK)
|
|
#define HAVE_SOCKOPTMARKID 1
|
|
#define SOCKOPTMARKID SO_MARK
|
|
#endif
|
|
#endif
|
|
|
|
/* Test for polling API */
|
|
#ifdef __linux__
|
|
#define HAVE_EPOLL 1
|
|
#endif
|
|
|
|
/* Test for accept4() */
|
|
#ifdef __linux__
|
|
#define HAVE_ACCEPT4 1
|
|
#endif
|
|
|
|
#if (defined(__APPLE__) && defined(MAC_OS_X_VERSION_10_6)) || defined(__FreeBSD__) || defined(__OpenBSD__) || defined (__NetBSD__)
|
|
#define HAVE_KQUEUE 1
|
|
#endif
|
|
|
|
#ifdef __sun
|
|
#include <sys/feature_tests.h>
|
|
#ifdef _DTRACE_VERSION
|
|
#define HAVE_EVPORT 1
|
|
#define HAVE_PSINFO 1
|
|
#endif
|
|
#endif
|
|
|
|
/* Define redis_fsync to fdatasync() in Linux and fsync() for all the rest */
|
|
#if defined(__linux__)
|
|
#define redis_fsync(fd) fdatasync(fd)
|
|
#elif defined(__APPLE__)
|
|
#define redis_fsync(fd) fcntl(fd, F_FULLFSYNC)
|
|
#else
|
|
#define redis_fsync(fd) fsync(fd)
|
|
#endif
|
|
|
|
#if defined(__FreeBSD__)
|
|
#if defined(SO_USER_COOKIE)
|
|
#define HAVE_SOCKOPTMARKID 1
|
|
#define SOCKOPTMARKID SO_USER_COOKIE
|
|
#endif
|
|
#endif
|
|
|
|
#if defined(__OpenBSD__)
|
|
#if defined(SO_RTABLE)
|
|
#define HAVE_SOCKOPTMARKID 1
|
|
#define SOCKOPTMARKID SO_RTABLE
|
|
#endif
|
|
#endif
|
|
|
|
#if __GNUC__ >= 5 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)
|
|
#define redis_unreachable __builtin_unreachable
|
|
#else
|
|
#define redis_unreachable abort
|
|
#endif
|
|
|
|
#if __GNUC__ >= 3
|
|
#define likely(x) __builtin_expect(!!(x), 1)
|
|
#define unlikely(x) __builtin_expect(!!(x), 0)
|
|
#else
|
|
#define likely(x) (x)
|
|
#define unlikely(x) (x)
|
|
#endif
|
|
|
|
#if defined(__has_attribute)
|
|
#if __has_attribute(no_sanitize)
|
|
#define REDIS_NO_SANITIZE(sanitizer) __attribute__((no_sanitize(sanitizer)))
|
|
#endif
|
|
#endif
|
|
#if !defined(REDIS_NO_SANITIZE)
|
|
#define REDIS_NO_SANITIZE(sanitizer)
|
|
#endif
|
|
|
|
/* Define rdb_fsync_range to sync_file_range() on Linux, otherwise we use
|
|
* the plain fsync() call. */
|
|
#if (defined(__linux__) && defined(SYNC_FILE_RANGE_WAIT_BEFORE))
|
|
#define HAVE_SYNC_FILE_RANGE 1
|
|
#define rdb_fsync_range(fd,off,size) sync_file_range(fd,off,size,SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE)
|
|
#elif defined(__APPLE__)
|
|
#define rdb_fsync_range(fd,off,size) fcntl(fd, F_FULLFSYNC)
|
|
#else
|
|
#define rdb_fsync_range(fd,off,size) fsync(fd)
|
|
#endif
|
|
|
|
/* Check if we can use setproctitle().
|
|
* BSD systems have support for it, we provide an implementation for
|
|
* Linux and osx. */
|
|
#if (defined __NetBSD__ || defined __FreeBSD__ || defined __OpenBSD__)
|
|
#define USE_SETPROCTITLE
|
|
#endif
|
|
|
|
#if defined(__HAIKU__)
|
|
#define ESOCKTNOSUPPORT 0
|
|
#endif
|
|
|
|
#if (defined __linux || defined __APPLE__)
|
|
#define USE_SETPROCTITLE
|
|
#define INIT_SETPROCTITLE_REPLACEMENT
|
|
void spt_init(int argc, char *argv[]);
|
|
void setproctitle(const char *fmt, ...);
|
|
#endif
|
|
|
|
/* Byte ordering detection */
|
|
#include <sys/types.h> /* This will likely define BYTE_ORDER */
|
|
|
|
#ifndef BYTE_ORDER
|
|
#if (BSD >= 199103)
|
|
# include <machine/endian.h>
|
|
#else
|
|
#if defined(linux) || defined(__linux__)
|
|
# include <endian.h>
|
|
#else
|
|
#define LITTLE_ENDIAN 1234 /* least-significant byte first (vax, pc) */
|
|
#define BIG_ENDIAN 4321 /* most-significant byte first (IBM, net) */
|
|
#define PDP_ENDIAN 3412 /* LSB first in word, MSW first in long (pdp)*/
|
|
|
|
#if defined(__i386__) || defined(__x86_64__) || defined(__amd64__) || \
|
|
defined(vax) || defined(ns32000) || defined(sun386) || \
|
|
defined(MIPSEL) || defined(_MIPSEL) || defined(BIT_ZERO_ON_RIGHT) || \
|
|
defined(__alpha__) || defined(__alpha)
|
|
#define BYTE_ORDER LITTLE_ENDIAN
|
|
#endif
|
|
|
|
#if defined(sel) || defined(pyr) || defined(mc68000) || defined(sparc) || \
|
|
defined(is68k) || defined(tahoe) || defined(ibm032) || defined(ibm370) || \
|
|
defined(MIPSEB) || defined(_MIPSEB) || defined(_IBMR2) || defined(DGUX) ||\
|
|
defined(apollo) || defined(__convex__) || defined(_CRAY) || \
|
|
defined(__hppa) || defined(__hp9000) || \
|
|
defined(__hp9000s300) || defined(__hp9000s700) || \
|
|
defined (BIT_ZERO_ON_LEFT) || defined(m68k) || defined(__sparc)
|
|
#define BYTE_ORDER BIG_ENDIAN
|
|
#endif
|
|
#endif /* linux */
|
|
#endif /* BSD */
|
|
#endif /* BYTE_ORDER */
|
|
|
|
/* Sometimes after including an OS-specific header that defines the
|
|
* endianness we end with __BYTE_ORDER but not with BYTE_ORDER that is what
|
|
* the Redis code uses. In this case let's define everything without the
|
|
* underscores. */
|
|
#ifndef BYTE_ORDER
|
|
#ifdef __BYTE_ORDER
|
|
#if defined(__LITTLE_ENDIAN) && defined(__BIG_ENDIAN)
|
|
#ifndef LITTLE_ENDIAN
|
|
#define LITTLE_ENDIAN __LITTLE_ENDIAN
|
|
#endif
|
|
#ifndef BIG_ENDIAN
|
|
#define BIG_ENDIAN __BIG_ENDIAN
|
|
#endif
|
|
#if (__BYTE_ORDER == __LITTLE_ENDIAN)
|
|
#define BYTE_ORDER LITTLE_ENDIAN
|
|
#else
|
|
#define BYTE_ORDER BIG_ENDIAN
|
|
#endif
|
|
#endif
|
|
#endif
|
|
#endif
|
|
|
|
#if !defined(BYTE_ORDER) || \
|
|
(BYTE_ORDER != BIG_ENDIAN && BYTE_ORDER != LITTLE_ENDIAN)
|
|
/* you must determine what the correct bit order is for
|
|
* your compiler - the next line is an intentional error
|
|
* which will force your compiles to bomb until you fix
|
|
* the above macros.
|
|
*/
|
|
#error "Undefined or invalid BYTE_ORDER"
|
|
#endif
|
|
|
|
#if (__i386 || __amd64 || __powerpc__) && __GNUC__
|
|
#define GNUC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)
|
|
#if defined(__clang__)
|
|
#define HAVE_ATOMIC
|
|
#endif
|
|
#if (defined(__GLIBC__) && defined(__GLIBC_PREREQ))
|
|
#if (GNUC_VERSION >= 40100 && __GLIBC_PREREQ(2, 6))
|
|
#define HAVE_ATOMIC
|
|
#endif
|
|
#endif
|
|
#endif
|
|
|
|
/* Make sure we can test for ARM just checking for __arm__, since sometimes
|
|
* __arm is defined but __arm__ is not. */
|
|
#if defined(__arm) && !defined(__arm__)
|
|
#define __arm__
|
|
#endif
|
|
#if defined (__aarch64__) && !defined(__arm64__)
|
|
#define __arm64__
|
|
#endif
|
|
|
|
/* Make sure we can test for SPARC just checking for __sparc__. */
|
|
#if defined(__sparc) && !defined(__sparc__)
|
|
#define __sparc__
|
|
#endif
|
|
|
|
#if defined(__sparc__) || defined(__arm__)
|
|
#define USE_ALIGNED_ACCESS
|
|
#endif
|
|
|
|
/* Define for redis_set_thread_title */
|
|
#ifdef __linux__
|
|
#define redis_set_thread_title(name) pthread_setname_np(pthread_self(), name)
|
|
#else
|
|
#if (defined __FreeBSD__ || defined __OpenBSD__)
|
|
#include <pthread_np.h>
|
|
#define redis_set_thread_title(name) pthread_set_name_np(pthread_self(), name)
|
|
#elif defined __NetBSD__
|
|
#include <pthread.h>
|
|
#define redis_set_thread_title(name) pthread_setname_np(pthread_self(), "%s", name)
|
|
#elif defined __HAIKU__
|
|
#include <kernel/OS.h>
|
|
#define redis_set_thread_title(name) rename_thread(find_thread(0), name)
|
|
#else
|
|
#if (defined __APPLE__ && defined(MAC_OS_X_VERSION_10_7))
|
|
int pthread_setname_np(const char *name);
|
|
#include <pthread.h>
|
|
#define redis_set_thread_title(name) pthread_setname_np(name)
|
|
#else
|
|
#define redis_set_thread_title(name)
|
|
#endif
|
|
#endif
|
|
#endif
|
|
|
|
/* Check if we can use setcpuaffinity(). */
|
|
#if (defined __linux || defined __NetBSD__ || defined __FreeBSD__ || defined __DragonFly__)
|
|
#define USE_SETCPUAFFINITY
|
|
void setcpuaffinity(const char *cpulist);
|
|
#endif
|
|
|
|
/* Test for posix_fadvise() */
|
|
#if defined(__linux__) || __FreeBSD__ >= 10
|
|
#define HAVE_FADVISE
|
|
#endif
|
|
|
|
#endif
|