2e854bccc6
see discussion from after https://github.com/redis/redis/pull/12453 was merged ---- This PR replaces signals that are not considered async-signal-safe (AS-safe) with safe calls. #### **1. serverLog() and serverLogFromHandler()** `serverLog` uses unsafe calls. It was decided that we will **avoid** `serverLog` calls by the signal handlers when: * The signal is not fatal, such as SIGALRM. In these cases, we prefer using `serverLogFromHandler` which is the safe version of `serverLog`. Note they have different prompts: `serverLog`: `62220:M 26 Oct 2023 14:39:04.526 # <msg>` `serverLogFromHandler`: `62220:signal-handler (1698331136) <msg>` * The code was added recently. Calls to `serverLog` by the signal handler have been there ever since Redis exists and it hasn't caused problems so far. To avoid regression, from now we should use `serverLogFromHandler` #### **2. `snprintf` `fgets` and `strtoul`(base = 16) --------> `_safe_snprintf`, `fgets_async_signal_safe`, `string_to_hex`** The safe version of `snprintf` was taken from [here](8cfc4ca5e7/src/mc_util.c (L754)) #### **3. fopen(), fgets(), fclose() --------> open(), read(), close()** #### **4. opendir(), readdir(), closedir() --------> open(), syscall(SYS_getdents64), close()** #### **5. Threads_mngr sync mechanisms** * waiting for the thread to generate stack trace: semaphore --------> busy-wait * `globals_rw_lock` was removed: as we are not using malloc and the semaphore anymore we don't need to protect `ThreadsManager_cleanups`. #### **6. Stacktraces buffer** The initial problem was that we were not able to safely call malloc within the signal handler. To solve that we created a buffer on the stack of `writeStacktraces` and saved it in a global pointer, assuming that under normal circumstances, the function `writeStacktraces` would complete before any thread attempted to write to it. However, **if threads lag behind, they might access this global pointer after it no longer belongs to the `writeStacktraces` stack, potentially corrupting memory.** To address this, various solutions were discussed [here](https://github.com/redis/redis/pull/12658#discussion_r1390442896) Eventually, we decided to **create a pipe** at server startup that will remain valid as long as the process is alive. We chose this solution due to its minimal memory usage, and since `write()` and `read()` are atomic operations. It ensures that stack traces from different threads won't mix. **The stacktraces collection process is now as follows:** * Cleaning the pipe to eliminate writes of late threads from previous runs. * Each thread writes to the pipe its stacktrace * Waiting for all the threads to mark completion or until a timeout (2 sec) is reached * Reading from the pipe to print the stacktraces. #### **7. Changes that were considered and eventually were dropped** * replace watchdog timer with a POSIX timer: according to [settimer man](https://linux.die.net/man/2/setitimer) > POSIX.1-2008 marks getitimer() and setitimer() obsolete, recommending the use of the POSIX timers API ([timer_gettime](https://linux.die.net/man/2/timer_gettime)(2), [timer_settime](https://linux.die.net/man/2/timer_settime)(2), etc.) instead. However, although it is supposed to conform to POSIX std, POSIX timers API is not supported on Mac. You can take a look here at the Linux implementation: [here](c7562ee135) To avoid messing up the code, and uncertainty regarding compatibility, it was decided to drop it for now. * avoid using sds (uses malloc) in logConfigDebugInfo It was considered to print config info instead of using sds, however apparently, `logConfigDebugInfo` does more than just print the sds, so it was decided this fix is out of this issue scope. #### **8. fix Signal mask check** The check `signum & sig_mask` intended to indicate whether the signal is blocked by the thread was incorrect. Actually, the bit position in the signal mask corresponds to the signal number. We fixed this by changing the condition to: `sig_mask & (1L << (sig_num - 1))` #### **9. Unrelated changes** both `fork.tcl `and `util.tcl` implemented a function called `count_log_message` expecting different parameters. This caused confusion when trying to run daily tests with additional test parameters to run a specific test. The `count_log_message` in `fork.tcl` was removed and the calls were replaced with calls to `count_log_message` located in `util.tcl` --------- Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com> Co-authored-by: Oran Agra <oran@redislabs.com>
108 lines
4.8 KiB
C
108 lines
4.8 KiB
C
/*
|
|
* Copyright (c) 2009-2012, Salvatore Sanfilippo <antirez at gmail dot com>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of Redis nor the names of its contributors may be used
|
|
* to endorse or promote products derived from this software without
|
|
* specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef __REDIS_UTIL_H
|
|
#define __REDIS_UTIL_H
|
|
|
|
#include <stdint.h>
|
|
#include "sds.h"
|
|
|
|
/* The maximum number of characters needed to represent a long double
|
|
* as a string (long double has a huge range of some 4952 chars, see LDBL_MAX).
|
|
* This should be the size of the buffer given to ld2string */
|
|
#define MAX_LONG_DOUBLE_CHARS 5*1024
|
|
|
|
/* The maximum number of characters needed to represent a double
|
|
* as a string (double has a huge range of some 328 chars, see DBL_MAX).
|
|
* This should be the size of the buffer for sprintf with %f */
|
|
#define MAX_DOUBLE_CHARS 400
|
|
|
|
/* The maximum number of characters needed to for d2string/fpconv_dtoa call.
|
|
* Since it uses %g and not %f, some 40 chars should be enough. */
|
|
#define MAX_D2STRING_CHARS 128
|
|
|
|
/* Bytes needed for long -> str + '\0' */
|
|
#define LONG_STR_SIZE 21
|
|
|
|
/* long double to string conversion options */
|
|
typedef enum {
|
|
LD_STR_AUTO, /* %.17Lg */
|
|
LD_STR_HUMAN, /* %.17Lf + Trimming of trailing zeros */
|
|
LD_STR_HEX /* %La */
|
|
} ld2string_mode;
|
|
|
|
int stringmatchlen(const char *p, int plen, const char *s, int slen, int nocase);
|
|
int stringmatch(const char *p, const char *s, int nocase);
|
|
int stringmatchlen_fuzz_test(void);
|
|
unsigned long long memtoull(const char *p, int *err);
|
|
const char *mempbrk(const char *s, size_t len, const char *chars, size_t charslen);
|
|
char *memmapchars(char *s, size_t len, const char *from, const char *to, size_t setlen);
|
|
uint32_t digits10(uint64_t v);
|
|
uint32_t sdigits10(int64_t v);
|
|
int ll2string(char *s, size_t len, long long value);
|
|
int ull2string(char *s, size_t len, unsigned long long value);
|
|
int string2ll(const char *s, size_t slen, long long *value);
|
|
int string2ull(const char *s, unsigned long long *value);
|
|
int string2l(const char *s, size_t slen, long *value);
|
|
int string2ul_base16_async_signal_safe(const char *src, size_t slen, unsigned long *result_output);
|
|
int string2ld(const char *s, size_t slen, long double *dp);
|
|
int string2d(const char *s, size_t slen, double *dp);
|
|
int trimDoubleString(char *buf, size_t len);
|
|
int d2string(char *buf, size_t len, double value);
|
|
int fixedpoint_d2string(char *dst, size_t dstlen, double dvalue, int fractional_digits);
|
|
int ld2string(char *buf, size_t len, long double value, ld2string_mode mode);
|
|
int double2ll(double d, long long *out);
|
|
int yesnotoi(char *s);
|
|
sds getAbsolutePath(char *filename);
|
|
long getTimeZone(void);
|
|
int pathIsBaseName(char *path);
|
|
int dirCreateIfMissing(char *dname);
|
|
int dirExists(char *dname);
|
|
int dirRemove(char *dname);
|
|
int fileExist(char *filename);
|
|
sds makePath(char *path, char *filename);
|
|
int fsyncFileDir(const char *filename);
|
|
int reclaimFilePageCache(int fd, size_t offset, size_t length);
|
|
char *fgets_async_signal_safe(char *dest, int buff_size, int fd);
|
|
int vsnprintf_async_signal_safe(char *to, size_t size, const char *format, va_list ap);
|
|
#ifdef __GNUC__
|
|
int snprintf_async_signal_safe(char *to, size_t n, const char *fmt, ...)
|
|
__attribute__((format(printf, 3, 4)));
|
|
#else
|
|
int snprintf_async_signal_safe(char *to, size_t n, const char *fmt, ...);
|
|
#endif
|
|
size_t redis_strlcpy(char *dst, const char *src, size_t dsize);
|
|
size_t redis_strlcat(char *dst, const char *src, size_t dsize);
|
|
|
|
#ifdef REDIS_TEST
|
|
int utilTest(int argc, char **argv, int flags);
|
|
#endif
|
|
|
|
#endif
|