uriyage 1d18842074

Fix bug in writeToClient (#834) ...

Fix bug in writeToClient
In https://github.com/valkey-io/valkey/pull/758, a major refactor was
done to `networking.c`.

As part of this refactor, a new bug was introduced: we don't advance the
`c->buf` pointer in repeated writes.

This bug should be very unlikely to manifest, as it requires the
client's TCP buffer to be filled in the first try and then released
immediately after in the second try.

Despite all my efforts to reproduce this scenario, I was unable to do
so.

Signed-off-by: Uri Yagelnik <uriy@amazon.com>

2024-07-30 21:54:18 -07:00

..

commands

Add network-bytes-in and network-bytes-out metric support under CLUSTER SLOT-STATS command (#20) (#720)

2024-07-26 16:06:16 -07:00

modules

Remove master and slave from source code (#591)

2024-06-07 14:21:33 -07:00

unit

Remove unused valDup (#443)

2024-06-03 12:22:06 -07:00

.clang-format

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

.clang-format-ignore

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

.gitignore

Rename redis.info to valkey.info in LCOV (#259)

2024-04-10 08:59:45 +02:00

acl.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

adlist.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

adlist.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

ae_epoll.c

Calculate the actual mask to be removed in the eventloop before aeApiDelEvent (#725)

2024-07-09 11:29:44 +08:00

ae_evport.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

ae_kqueue.c

Combine events to eliminate redundant kevent(2) calls (#638)

2024-06-16 21:18:20 -07:00

ae_select.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

ae.c

Io thread work offload (#763)

2024-07-18 19:21:45 -07:00

ae.h

Io thread work offload (#763)

2024-07-18 19:21:45 -07:00

anet.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

anet.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

aof.c

Fix unexpected behavior when turning appendonly on and off within a transaction (#826)

2024-07-27 18:38:23 +08:00

asciilogo.h

Prevent clang-format in certain places (#468)

2024-05-08 20:58:53 +02:00

atomicvar.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

bio.c

Set up clang-format github action (#538)

2024-05-28 09:27:51 -07:00

bio.h

Implementing the WAITAOF command (issue #10505) (#11713)

2023-03-14 20:26:21 +02:00

bitops.c

Fix bitops.c clang-format properly (#570)

2024-05-28 21:49:50 -07:00

blocked.c

Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)

2024-07-22 18:03:28 -07:00

call_reply.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

call_reply.h

Remove REDISMODULE_ prefixes and introduce compatibility header (#194)

2024-04-05 16:59:55 -07:00

childinfo.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

cli_commands.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

cli_commands.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

cli_common.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

cli_common.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

cluster_legacy.c

Remove static to avoid compiler warning (#836)

2024-07-28 13:08:09 -07:00

cluster_legacy.h

Add network-bytes-in and network-bytes-out metric support under CLUSTER SLOT-STATS command (#20) (#720)

2024-07-26 16:06:16 -07:00

cluster_slot_stats.c

Handle underflow condition of network out slot stats metric (#840)

2024-07-29 21:50:46 -07:00

cluster_slot_stats.h

Handle underflow condition of network out slot stats metric (#840)

2024-07-29 21:50:46 -07:00

cluster.c

Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)

2024-07-22 18:03:28 -07:00

cluster.h

Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)

2024-07-22 18:03:28 -07:00

commands.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

commands.def

Nested MULTI or WATCH in MULTI now will abort the transaction (#723)

2024-07-03 21:27:45 +02:00

commands.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

config.c

Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)

2024-07-22 18:03:28 -07:00

config.h

Async IO threads (#758)

2024-07-08 20:01:39 -07:00

connection.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

connection.h

Dual stack and client-specific IPs in cluster (#736)

2024-07-10 13:53:52 +02:00

connhelpers.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

crc16_slottable.h

Remove trademarked language in code comments (#223)

2024-04-09 10:24:03 +02:00

crc16.c

RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.

2015-07-26 15:17:18 +02:00

crc64.c

An initial simple unit test framework (#344)

2024-05-02 20:00:04 -07:00

crc64.h

An initial simple unit test framework (#344)

2024-05-02 20:00:04 -07:00

crccombine.c

Update serverpanic output based on 'extended-redis-compatibility' config. (#415)

2024-05-08 12:17:32 -07:00

crccombine.h

CRC64 perf improvements from Redis patches (#350)

2024-04-30 19:32:01 -07:00

crcspeed.c

CRC64 perf improvements from Redis patches (#350)

2024-04-30 19:32:01 -07:00

crcspeed.h

CRC64 perf improvements from Redis patches (#350)

2024-04-30 19:32:01 -07:00

db.c

Add network-bytes-in and network-bytes-out metric support under CLUSTER SLOT-STATS command (#20) (#720)

2024-07-26 16:06:16 -07:00

debug.c

Improve dual channel replication stability and fix compatibility issues (#804)

2024-07-25 09:34:39 -07:00

debugmacro.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

defrag.c

Embed key into dict entry (#541)

2024-07-02 15:45:37 -07:00

dict.c

Io thread work offload (#763)

2024-07-18 19:21:45 -07:00

dict.h

Io thread work offload (#763)

2024-07-18 19:21:45 -07:00

endianconv.c

Migrate endianconv.c unit tests to new test framework (#458)

2024-05-12 16:58:50 -07:00

endianconv.h

Migrate endianconv.c unit tests to new test framework (#458)

2024-05-12 16:58:50 -07:00

eval.c

Async IO threads (#758)

2024-07-08 20:01:39 -07:00

evict.c

Remove master and slave from source code (#591)

2024-06-07 14:21:33 -07:00

expire.c

Remove master and slave from source code (#591)

2024-06-07 14:21:33 -07:00

fmacros.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

fmtargs.h

Rewrite huge printf calls to smaller ones for readability (#12257)

2023-09-28 09:21:23 +03:00

function_lua.c

More rebranding (#606)

2024-06-07 01:40:55 +02:00

functions.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

functions.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

geo.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

geo.h

RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.

2015-07-26 15:17:18 +02:00

geohash_helper.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

geohash_helper.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

geohash.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

geohash.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

hyperloglog.c

Typo fix in hyperloglog.c (#807)

2024-07-20 23:48:00 +02:00

intset.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

intset.h

Remove intsettest declaration from intset.h (#471)

2024-05-08 12:38:50 -07:00

io_threads.c

Improve CPU usage in tests with IO threads (#823)

2024-07-23 22:24:41 -07:00

io_threads.h

Io thread work offload (#763)

2024-07-18 19:21:45 -07:00

kvstore.c

Embed key into dict entry (#541)

2024-07-02 15:45:37 -07:00

kvstore.h

Embed key into dict entry (#541)

2024-07-02 15:45:37 -07:00

latency.c

Latency report: Rebranding and refine Dave dialog (#644)

2024-06-14 12:56:59 +02:00

latency.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

lazyfree.c

Set up clang-format github action (#538)

2024-05-28 09:27:51 -07:00

listpack_malloc.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

listpack.c

Remove unnecessary clang-format off annotations (#628)

2024-06-12 12:52:18 +02:00

listpack.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

localtime.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

logreqres.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

lolwut5.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

lolwut6.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

lolwut.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

lolwut.h

add include guard for lolwut.h

2020-05-05 23:35:08 -04:00

lzf_c.c

Change lzf to handle values larger than UINT32_MAX (#9776)

2021-11-16 13:12:25 +02:00

lzf_d.c

Change lzf to handle values larger than UINT32_MAX (#9776)

2021-11-16 13:12:25 +02:00

lzf.h

Change lzf to handle values larger than UINT32_MAX (#9776)

2021-11-16 13:12:25 +02:00

lzfP.h

Change lzf to handle values larger than UINT32_MAX (#9776)

2021-11-16 13:12:25 +02:00

Makefile

Introduce Valkey Over RDMA transport (experimental) (#477)

2024-07-15 14:04:22 +02:00

memtest.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

mkreleasehdr.sh

Update Server version to valkey version (#232)

2024-04-05 21:15:57 -07:00

module.c

Io thread work offload (#763)

2024-07-18 19:21:45 -07:00

monotonic.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

monotonic.h

Remove prototypes with empty declarations (#12020)

2023-05-02 17:31:32 -07:00

mt19937-64.c

Fix random element selection for large hash tables. (#8133)

2020-12-23 15:52:07 +02:00

mt19937-64.h

Fix random element selection for large hash tables. (#8133)

2020-12-23 15:52:07 +02:00

multi.c

Nested MULTI or WATCH in MULTI now will abort the transaction (#723)

2024-07-03 21:27:45 +02:00

networking.c

Fix bug in writeToClient (#834)

2024-07-30 21:54:18 -07:00

notify.c

Remove unnecessary clang-format off annotations (#628)

2024-06-12 12:52:18 +02:00

object.c

Embed key into dict entry (#541)

2024-07-02 15:45:37 -07:00

pqsort.c

Remove trademarked language in code comments (#223)

2024-04-09 10:24:03 +02:00

pqsort.h

Remove trademarked language in code comments (#223)

2024-04-09 10:24:03 +02:00

pubsub.c

Add network-bytes-in and network-bytes-out metric support under CLUSTER SLOT-STATS command (#20) (#720)

2024-07-26 16:06:16 -07:00

quicklist.c

Replacing REDIS_STATIC with static (#691)

2024-06-26 09:47:59 -07:00

quicklist.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

rand.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

rand.h

Rename 'redis' to 'server' and redisNodeFlags to clusterNodeFlags (#191)

2024-04-03 18:45:23 -07:00

rax_malloc.h

Cluster: hash slots tracking using a radix tree.

2017-03-27 16:37:22 +02:00

rax.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

rax.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

rdb.c

Fix rdb_child_exit_pipe incorrect close call (#801)

2024-07-17 22:47:08 -07:00

rdb.h

Support RDB compatability with Redis 7.2.4 RDB format (#665)

2024-06-18 12:04:06 -07:00

rdma.c

Introduce Valkey Over RDMA transport (experimental) (#477)

2024-07-15 14:04:22 +02:00

redismodule.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

release.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

replication.c

Handle underflow condition of network out slot stats metric (#840)

2024-07-29 21:50:46 -07:00

resp_parser.c

Remove unnecessary clang-format off annotations (#628)

2024-06-12 12:52:18 +02:00

resp_parser.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

rio.c

Increase rioConnsetWrite max chunk size to 16K (#817)

2024-07-24 08:23:06 -07:00

rio.h

Dual channel replication (#60)

2024-07-17 13:59:33 -07:00

script_lua.c

Limit tracking custom errors (e.g. from LUA) while allowing non custom errors to be tracked normally (#500)

2024-07-14 20:04:47 -07:00

script_lua.h

More rebranding (#606)

2024-06-07 01:40:55 +02:00

script.c

Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)

2024-07-22 18:03:28 -07:00

script.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

sds.c

Embed key into dict entry (#541)

2024-07-02 15:45:37 -07:00

sds.h

Embed key into dict entry (#541)

2024-07-02 15:45:37 -07:00

sdsalloc.h

Fix bad memory accounting for sds when no malloc_size available (#694)

2024-06-25 08:18:07 -07:00

sentinel.c

Replace master-reboot-down-after-period with primary-reboot-down-after-period in sentinel.conf (#647)

2024-07-15 13:45:40 -04:00

server.c

Add network-bytes-in and network-bytes-out metric support under CLUSTER SLOT-STATS command (#20) (#720)

2024-07-26 16:06:16 -07:00

server.h

Add network-bytes-in and network-bytes-out metric support under CLUSTER SLOT-STATS command (#20) (#720)

2024-07-26 16:06:16 -07:00

serverassert.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

serverassert.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

setcpuaffinity.c

cpu affinity: DragonFlyBSD support (#7956)

2020-10-25 14:14:05 +02:00

setproctitle.c

Fix failed tests on Linux Alpine and add a CI job. (#8532)

2021-02-23 12:57:45 +02:00

sha1.c

Migrate sha1 unit test to new framework (#470)

2024-05-09 19:44:40 -07:00

sha1.h

Migrate sha1 unit test to new framework (#470)

2024-05-09 19:44:40 -07:00

sha256.c

Add sanitizer support and clean up sanitizer findings (#9601)

2021-11-11 13:51:33 +02:00

sha256.h

fix explanation of sha256 (#9220)

2021-07-10 10:04:54 -05:00

siphash.c

Better standardize around assertions (#12539)

2023-10-02 18:58:44 -07:00

slowlog.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

slowlog.h

[Fix] move deps from slowlog.c into slowlog.h (#465)

2024-05-09 14:29:18 -07:00

socket.c

Async IO threads (#758)

2024-07-08 20:01:39 -07:00

solarisfixes.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

sort.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

sparkline.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

sparkline.h

LATENCY GRAPH implemented.

2014-07-02 16:31:22 +02:00

stream.h

Remove master and slave from source code (#591)

2024-06-07 14:21:33 -07:00

strl.c

Change strlcat function name from redis to valkey (#440)

2024-05-06 00:09:01 -07:00

syncio.c

Remove master and slave from source code (#591)

2024-06-07 14:21:33 -07:00

syscheck.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

syscheck.h

Add warning for suspected slow system clocksource setting (#10636)

2022-05-22 17:10:31 +03:00

t_hash.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

t_list.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

t_set.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

t_stream.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

t_string.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

t_zset.c

Optimize the logic for checking the conversion of zset from listpack to skiplist during the ZADD operation. (#806)

2024-07-25 17:46:00 +08:00

testhelp.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

threads_mngr.c

Set up clang-format github action (#538)

2024-05-28 09:27:51 -07:00

threads_mngr.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

timeout.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

tls.c

Async IO threads (#758)

2024-07-08 20:01:39 -07:00

tracking.c

Replace client flags to bitfield (#614)

2024-06-30 11:33:10 -07:00

unix.c

Async IO threads (#758)

2024-07-08 20:01:39 -07:00

util.c

Remove unnecessary clang-format off annotations (#628)

2024-06-12 12:52:18 +02:00

util.h

Implement REPLCONF VERSION (#554)

2024-05-27 23:03:34 +02:00

valgrind.sup

Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed

2020-12-06 14:54:34 +02:00

valkey-benchmark.c

Update remaining master references to primary (#660)

2024-06-17 20:31:15 -07:00

valkey-check-aof.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

valkey-check-rdb.c

Support RDB compatability with Redis 7.2.4 RDB format (#665)

2024-06-18 12:04:06 -07:00

valkey-cli.c

Avoid compilation error oin valkey-cli (#721)

2024-07-01 19:47:45 +08:00

valkeymodule.h

Dual stack and client-specific IPs in cluster (#736)

2024-07-10 13:53:52 +02:00

version.h

Change Redis to Valkey in log messages (#226)

2024-04-17 14:38:21 +02:00

ziplist.c

Remove unnecessary clang-format off annotations (#628)

2024-06-12 12:52:18 +02:00

ziplist.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

zipmap.c

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

zipmap.h

Add clang-format configs (#323)

2024-05-22 23:24:12 -07:00

zmalloc.c

Introduce thread-local storage variable to update thread's own used_memory and sum when reading to reduce atomic contention. (#674)

2024-07-01 21:52:43 -07:00

zmalloc.h

Add zfree_with_size to optimize sdsfree since we can get zmalloc_size from the header (#453)

2024-06-19 16:13:55 -07:00