gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
futriix/src
History
Madelyn Olson 13f2b61fff Optimize the per slot dictionary by checking for cluster mode earlier (#995) 
While doing some profiling, I noticed that getKeySlot() was a fairly
large part (~0.7%) of samples doing perf with high pipeline during
standalone. I think this is because we do a very late check for
server.cluster_mode, we first call getKeySlot() and then call
calculateKeySlot(). (calculateKeySlot was surprisingly not automatically
inlined, we were doing a jump into it and then immediately returning
zero). We then also do useless work in the form of caching zero in
client->slot, which will further mess with cache lines.

So, this PR tries to accomplish a few things things.
1) The usage of the `slot` name made a lot more sense before the
introduction of the kvstore. Now with kvstore, we call this the database
index, so all the references to slot in standalone are no longer really
accurate.
2) Pull the cluster mode check all the way out of getKeySlot(), so
hopefully a bit more performant.
3) Remove calculateKeySlot() as independent from getKeySlot().
calculateKeySlot used to have 3 call sites outside of db.c, which
warranted it's own function. It's now only called in two places,
pubsub.c and networking.c.

I ran some profiling, and saw about ~0.3% improvement, but don't really
trust it because you'll see a much higher (~2%) variance in test runs
just by how the branch predictions will get changed with a new memory
layout. Running perf again showed no samples in getKeySlot() and a
reduction in samples in lookupKey(), so maybe this will help a little
bit.

---------

Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Ping Xie <pingxie@google.com>
2024-09-15 11:49:49 -07:00
..
commands
Add 4 commands for sentinel and update most test cases and json files (#789)
2024-09-03 09:00:45 -07:00
modules
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
unit
Migrate dict.c unit tests to new framework (#946)
2024-09-15 11:49:49 -07:00
.clang-format
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.clang-format-ignore
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
.gitignore
Rename redis.info to valkey.info in LCOV (#259)
2024-04-10 08:59:45 +02:00
acl.c
Add configuration hide-user-data-from-log to hide user data from server logs (#877)
2024-09-03 09:00:45 -07:00
adlist.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
adlist.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
ae_epoll.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
ae_evport.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
ae_kqueue.c
Combine events to eliminate redundant kevent(2) calls (#638)
2024-06-16 21:18:20 -07:00
ae_select.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
ae.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
ae.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
anet.c
Add support for setting the group on a unix domain socket (#901)
2024-09-03 09:00:45 -07:00
anet.h
Add support for setting the group on a unix domain socket (#901)
2024-09-03 09:00:45 -07:00
aof.c
Fix aof base suffix when modifying aof-use-rdb-preamble during rewrite (#886)
2024-09-15 11:49:49 -07:00
asciilogo.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
atomicvar.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
bio.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
bio.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
bitops.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
blocked.c
Make use of a single listNode pointer for blocking utility lists (#919)
2024-09-03 09:00:45 -07:00
call_reply.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
call_reply.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
childinfo.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
cli_commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cli_common.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
cli_common.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
cluster_legacy.c
For MEETs, save the extensions support flag immediately during MEET processing (#778)
2024-09-15 11:49:49 -07:00
cluster_legacy.h
Improve cluster cant failover log conditions (#780)
2024-09-03 09:00:45 -07:00
cluster_slot_stats.c
Assert network bytes out for replication slot stat computation is only allowed on primary (#847)
2024-09-03 09:00:45 -07:00
cluster_slot_stats.h
Handle underflow condition of network out slot stats metric (#840)
2024-07-29 21:50:46 -07:00
cluster.c
Add SLOT-STATS under CLUSTER HELP string. (#988)
2024-09-15 11:49:49 -07:00
cluster.h
Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)
2024-07-22 18:03:28 -07:00
commands.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
commands.def
Add 4 commands for sentinel and update most test cases and json files (#789)
2024-09-03 09:00:45 -07:00
commands.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
config.c
Add configuration hide-user-data-from-log to hide user data from server logs (#877)
2024-09-03 09:00:45 -07:00
config.h
Improve multithreaded performance with memory prefetching (#861)
2024-09-03 09:00:45 -07:00
connection.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
connection.h
Add support for setting the group on a unix domain socket (#901)
2024-09-03 09:00:45 -07:00
connhelpers.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
crc16_slottable.h
Remove trademarked language in code comments (#223)
2024-04-09 10:24:03 +02:00
crc16.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
crc64.c
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crc64.h
An initial simple unit test framework (#344)
2024-05-02 20:00:04 -07:00
crccombine.c
Update serverpanic output based on 'extended-redis-compatibility' config. (#415)
2024-05-08 12:17:32 -07:00
crccombine.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.c
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
crcspeed.h
CRC64 perf improvements from Redis patches (#350)
2024-04-30 19:32:01 -07:00
db.c
Optimize the per slot dictionary by checking for cluster mode earlier (#995)
2024-09-15 11:49:49 -07:00
debug.c
Add client info to SHUTDOWN / CLUSTER FAILOVER logs (#875)
2024-09-15 11:49:49 -07:00
debugmacro.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
defrag.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
dict.c
Migrate dict.c unit tests to new framework (#946)
2024-09-15 11:49:49 -07:00
dict.h
Migrate dict.c unit tests to new framework (#946)
2024-09-15 11:49:49 -07:00
endianconv.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
endianconv.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
eval.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-09-03 09:00:45 -07:00
evict.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
expire.c
Fast path in SET if the expiration time is expired (#865)
2024-09-03 09:00:45 -07:00
fmacros.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
fmtargs.h
Improve multithreaded performance with memory prefetching (#861)
2024-09-03 09:00:45 -07:00
function_lua.c
More rebranding (#606)
2024-06-07 01:40:55 +02:00
functions.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-09-03 09:00:45 -07:00
functions.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
geo.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
geo.h
RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.
2015-07-26 15:17:18 +02:00
geohash_helper.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
geohash_helper.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
geohash.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
geohash.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
hyperloglog.c
Using intrinsics to optimize counting HyperLogLog trailing bits (#846)
2024-09-03 09:00:45 -07:00
intrinsics.h
Using intrinsics to optimize counting HyperLogLog trailing bits (#846)
2024-09-03 09:00:45 -07:00
intset.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
intset.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
io_threads.c
Improve multithreaded performance with memory prefetching (#861)
2024-09-03 09:00:45 -07:00
io_threads.h
Io thread work offload (#763)
2024-07-18 19:21:45 -07:00
kvstore.c
add assertion for kvstore's dictType (#1004)
2024-09-15 11:49:49 -07:00
kvstore.h
Use metadata to handle the reference relationship between kvstore and dict (#966)
2024-09-03 09:00:45 -07:00
latency.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
latency.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
lazyfree.c
Use metadata to handle the reference relationship between kvstore and dict (#966)
2024-09-03 09:00:45 -07:00
listpack_malloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
listpack.c
Migrate listpack.c unit tests to new framework (#949)
2024-09-15 11:49:49 -07:00
listpack.h
Migrate listpack.c unit tests to new framework (#949)
2024-09-15 11:49:49 -07:00
localtime.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
logreqres.c
Replace client flags to bitfield (#614)
2024-06-30 11:33:10 -07:00
lolwut5.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
lolwut6.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
lolwut.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
lolwut.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
lzf_c.c
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzf_d.c
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzf.h
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
lzfP.h
Change lzf to handle values larger than UINT32_MAX (#9776)
2021-11-16 13:12:25 +02:00
Makefile
Improve multithreaded performance with memory prefetching (#861)
2024-09-03 09:00:45 -07:00
memory_prefetch.c
Improve multithreaded performance with memory prefetching (#861)
2024-09-03 09:00:45 -07:00
memory_prefetch.h
Improve multithreaded performance with memory prefetching (#861)
2024-09-03 09:00:45 -07:00
memtest.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
mkreleasehdr.sh
Update Server version to valkey version (#232)
2024-04-05 21:15:57 -07:00
module.c
Fix module RdbLoad wrongly disable the AOF (#1001)
2024-09-15 11:49:49 -07:00
monotonic.c
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
monotonic.h
Remove prototypes with empty declarations (#12020)
2023-05-02 17:31:32 -07:00
mt19937-64.c
Fix random element selection for large hash tables. (#8133)
2020-12-23 15:52:07 +02:00
mt19937-64.h
Fix random element selection for large hash tables. (#8133)
2020-12-23 15:52:07 +02:00
multi.c
free client's multi state when it becomes dirty (#961)
2024-09-03 09:00:45 -07:00
networking.c
Optimize the per slot dictionary by checking for cluster mode earlier (#995)
2024-09-15 11:49:49 -07:00
notify.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
object.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-09-03 09:00:45 -07:00
pqsort.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
pqsort.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
pubsub.c
Optimize the per slot dictionary by checking for cluster mode earlier (#995)
2024-09-15 11:49:49 -07:00
quicklist.c
Replacing REDIS_STATIC with static (#691)
2024-06-26 09:47:59 -07:00
quicklist.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
rand.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rand.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rax_malloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rax.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rax.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rdb.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rdb.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rdma.c
Add support for setting the group on a unix domain socket (#901)
2024-09-03 09:00:45 -07:00
redismodule.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
release.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
replication.c
Dual Channel Replication - Verify Replica Local Buffer Limit Configuration (#989)
2024-09-15 11:49:49 -07:00
resp_parser.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
resp_parser.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rio.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
rio.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
script_lua.c
Limit tracking custom errors (e.g. from LUA) while allowing non custom errors to be tracked normally (#500)
2024-07-14 20:04:47 -07:00
script_lua.h
More rebranding (#606)
2024-06-07 01:40:55 +02:00
script.c
Add cpu-usec metric support under CLUSTER SLOT-STATS command (#20). (#712)
2024-07-22 18:03:28 -07:00
script.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
sds.c
Use sdsAllocSize instead of sdsZmallocSize (#923)
2024-09-03 09:00:45 -07:00
sds.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
sdsalloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
sentinel.c
Add 4 commands for sentinel and update most test cases and json files (#789)
2024-09-03 09:00:45 -07:00
server.c
Migrate dict.c unit tests to new framework (#946)
2024-09-15 11:49:49 -07:00
server.h
Add client info to SHUTDOWN / CLUSTER FAILOVER logs (#875)
2024-09-15 11:49:49 -07:00
serverassert.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
serverassert.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
setcpuaffinity.c
cpu affinity: DragonFlyBSD support (#7956)
2020-10-25 14:14:05 +02:00
setproctitle.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
sha1.c
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha1.h
Migrate sha1 unit test to new framework (#470)
2024-05-09 19:44:40 -07:00
sha256.c
Add sanitizer support and clean up sanitizer findings (#9601)
2021-11-11 13:51:33 +02:00
sha256.h
fix explanation of sha256 (#9220)
2021-07-10 10:04:54 -05:00
siphash.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
slowlog.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
slowlog.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
socket.c
Connection minor fixes (#953)
2024-09-03 09:00:45 -07:00
solarisfixes.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
sort.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
sparkline.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
sparkline.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
stream.h
Remove master and slave from source code (#591)
2024-06-07 14:21:33 -07:00
strl.c
Change strlcat function name from redis to valkey (#440)
2024-05-06 00:09:01 -07:00
syncio.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
syscheck.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
syscheck.h
Add warning for suspected slow system clocksource setting (#10636)
2022-05-22 17:10:31 +03:00
t_hash.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
t_list.c
Move prepareClientToWrite out of loop for lrange command to reduce the redundant call. (#860)
2024-09-03 09:00:45 -07:00
t_set.c
Use hashtable as the default type of temp set object during sunion/sdiff (#996)
2024-09-15 11:49:49 -07:00
t_stream.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
t_string.c
Fast path in SET if the expiration time is expired (#865)
2024-09-03 09:00:45 -07:00
t_zset.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
testhelp.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
threads_mngr.c
Set up clang-format github action (#538)
2024-05-28 09:27:51 -07:00
threads_mngr.h
Add clang-format configs (#323)
2024-05-22 23:24:12 -07:00
timeout.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
tls.c
Connection minor fixes (#953)
2024-09-03 09:00:45 -07:00
tracking.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
unix.c
Add support for setting the group on a unix domain socket (#901)
2024-09-03 09:00:45 -07:00
util.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
util.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
valgrind.sup
Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed
2020-12-06 14:54:34 +02:00
valkey-benchmark.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
valkey-check-aof.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
valkey-check-rdb.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
valkey-cli.c
Fix typo in valkey-cli.c (#979)
2024-09-15 11:49:49 -07:00
valkeymodule.h
Dual stack and client-specific IPs in cluster (#736)
2024-07-10 13:53:52 +02:00
version.h
Valkey 8.0 RC1 release notes (#850)
2024-08-01 08:59:43 -07:00
ziplist.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
ziplist.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
zipmap.c
Delete unused parts of zipmap (#973)
2024-09-03 09:00:45 -07:00
zipmap.h
Delete unused parts of zipmap (#973)
2024-09-03 09:00:45 -07:00
zmalloc.c
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00
zmalloc.h
Copyright update to reflect IP transfer from salvatore to Redis (#740)
2024-09-03 09:00:45 -07:00