27273 Commits

Author SHA1 Message Date
antirez
231c9db1b5 Now that SPOP can be called by scripts use BLPOP on 's' flag test. 2016-05-31 16:43:23 +02:00
antirez
58b3a27b6d Avoid undefined behavior in BITFIELD implementation.
Probably there is no compiler that will actaully break the code or raise
a signal for unsigned -> signed overflowing conversion, still it was
apparently possible to write it in a more correct way.

All tests passing.
2016-05-31 11:52:07 +02:00
antirez
2503acfc83 Avoid undefined behavior in BITFIELD implementation.
Probably there is no compiler that will actaully break the code or raise
a signal for unsigned -> signed overflowing conversion, still it was
apparently possible to write it in a more correct way.

All tests passing.
2016-05-31 11:52:07 +02:00
Salvatore Sanfilippo
574ebbbc41 Merge pull request #3278 from itamarhaber/patch-8
Allow SPOP from Lua scripts
2016-05-30 17:47:23 +02:00
Salvatore Sanfilippo
9200312ab6 Merge pull request #3278 from itamarhaber/patch-8
Allow SPOP from Lua scripts
2016-05-30 17:47:23 +02:00
antirez
fecf92d530 Geo: fix typo in geohashEstimateStepsByRadius().
I'm the author of this line but I can't see a good reason for it to
don't be a typo, a step of 26 should be valid with 52 bits per
coordinate, moreover the line was:

    if (step > 26) step = 25;

So a step of 26 was actually already used, except when one of 27 was
computed (which is invalid) only then it was trimmed to 25 instead of
26.

All tests passing after the change.
2016-05-30 15:31:19 +02:00
antirez
5d4b5fbd6f Geo: fix typo in geohashEstimateStepsByRadius().
I'm the author of this line but I can't see a good reason for it to
don't be a typo, a step of 26 should be valid with 52 bits per
coordinate, moreover the line was:

    if (step > 26) step = 25;

So a step of 26 was actually already used, except when one of 27 was
computed (which is invalid) only then it was trimmed to 25 instead of
26.

All tests passing after the change.
2016-05-30 15:31:19 +02:00
antirez
120d372e53 Merge branch 'unstable' of github.com:/antirez/redis into unstable 2016-05-30 12:47:28 +02:00
antirez
18a513f86d Merge branch 'unstable' of github.com:/antirez/redis into unstable 2016-05-30 12:47:28 +02:00
antirez
881a40e09d Fix GEORADIUS wrong output with radius > Earth radius.
Close #3266
2016-05-30 12:45:54 +02:00
antirez
4eff3dc4e4 Fix GEORADIUS wrong output with radius > Earth radius.
Close #3266
2016-05-30 12:45:54 +02:00
ideal
641f8c1c2c fix mistake comment in object.c 2016-05-30 16:57:36 +08:00
ideal
4067132092 fix mistake comment in object.c 2016-05-30 16:57:36 +08:00
wenduo
386f7f5ae0 bitcount bug:return non-zero value when start > end (both negative) 2016-05-30 16:21:08 +08:00
wenduo
41dacdbcbe bitcount bug:return non-zero value when start > end (both negative) 2016-05-30 16:21:08 +08:00
jamespedwards42
3a1c815a6a Fix modules intro typos. 2016-05-29 15:53:24 -07:00
jamespedwards42
3432061cbb
Fix modules intro typos. 2016-05-29 15:53:24 -07:00
jamespedwards42
1bd8a08435 Fix modules intro typos. 2016-05-29 15:53:24 -07:00
Itamar Haber
54ad58ee4d Allow SPOP from Lua scripts
The existing `R` flag appears to be sufficient and there's no apparent reason why the command should be blocked.
2016-05-28 20:01:46 +03:00
Itamar Haber
2866e023f8 Allow SPOP from Lua scripts
The existing `R` flag appears to be sufficient and there's no apparent reason why the command should be blocked.
2016-05-28 20:01:46 +03:00
MOON_CLJ
972dc80547 fix check when can't send the command to the promoted slave 2016-05-26 13:10:12 +08:00
MOON_CLJ
aa578446ba fix check when can't send the command to the promoted slave 2016-05-26 13:10:12 +08:00
oranagra
170f9dbc22 check WRONGTYPE in BITFIELD before looping on the operations.
optimization: lookup key only once, and grow at once to the max need
fixes #3259 and #3221, and also an early return if wrongtype is discovered by SET
2016-05-24 23:31:36 +03:00
oranagra
5d96b7ed4f check WRONGTYPE in BITFIELD before looping on the operations.
optimization: lookup key only once, and grow at once to the max need
fixes #3259 and #3221, and also an early return if wrongtype is discovered by SET
2016-05-24 23:31:36 +03:00
oranagra
63b1eb3729 fix crash in BITFIELD GET on non existing key or wrong type see #3259
this was a bug in the recent refactoring: cbcee71ccba6766d58d729070ede73d808296193
2016-05-24 14:52:43 +03:00
oranagra
c4433d2a6a fix crash in BITFIELD GET on non existing key or wrong type see #3259
this was a bug in the recent refactoring: bee963c4459223d874e3294a0d8638a588d33c8e
2016-05-24 14:52:43 +03:00
oranagra
295f9eba16 fix georadius returns multiple replies 2016-05-23 13:58:50 +03:00
oranagra
f3e81de176 fix georadius returns multiple replies 2016-05-23 13:58:50 +03:00
oranagra
178dffefa6 CLIENT error message was out of date 2016-05-23 11:42:21 +03:00
oranagra
8d9d8d16e4 CLIENT error message was out of date 2016-05-23 11:42:21 +03:00
Salvatore Sanfilippo
26630a6fb1 Merge pull request #3249 from badboy/rcli-debug-printing
Remove debug printing
2016-05-22 23:32:03 +02:00
Salvatore Sanfilippo
8c4f4d12d8 Merge pull request #3249 from badboy/rcli-debug-printing
Remove debug printing
2016-05-22 23:32:03 +02:00
oranagra
e8a3b3682e config set list-max-ziplist-size didn't support negative values, unlike config file 2016-05-22 20:35:14 +03:00
oranagra
5fa711fa37 config set list-max-ziplist-size didn't support negative values, unlike config file 2016-05-22 20:35:14 +03:00
Jan-Erik Rediger
766eeb5459 Remove debug printing 2016-05-21 13:50:01 +02:00
Jan-Erik Rediger
892565f924 Remove debug printing 2016-05-21 13:50:01 +02:00
Dvir Volk
f4c86ac7a0 optimized amFree even further 2016-05-19 13:51:55 +03:00
Dvir Volk
137fd86a61 optimized amFree even further 2016-05-19 13:51:55 +03:00
Dvir Volk
e10b9ca1ca Optimized autoMemoryFreed loop 2016-05-19 12:16:14 +03:00
Dvir Volk
46b07cbb5c Optimized autoMemoryFreed loop 2016-05-19 12:16:14 +03:00
antirez
0b69884559 Fix modules compilation when libc malloc is used.
Compiling Redis worked as a side effect of jemalloc target specifying
-ldl as needed linker options, otherwise it is not provided during
linking and dlopen() API will remain unresolved symbols.
2016-05-18 17:48:06 +02:00
antirez
b09a6b6a5d Fix modules compilation when libc malloc is used.
Compiling Redis worked as a side effect of jemalloc target specifying
-ldl as needed linker options, otherwise it is not provided during
linking and dlopen() API will remain unresolved symbols.
2016-05-18 17:48:06 +02:00
Salvatore Sanfilippo
bfe127ac88 Merge pull request #3222 from oranagra/more_minir_fixes
minor fixes - mainly signalModifiedKey, and GEORADIUS
2016-05-18 07:50:53 -07:00
Salvatore Sanfilippo
bafed3ddd6 Merge pull request #3222 from oranagra/more_minir_fixes
minor fixes - mainly signalModifiedKey, and GEORADIUS
2016-05-18 07:50:53 -07:00
antirez
75c4d79ad6 Modules: RM_HashSet() SDS ownership business clarified in comments.
Related to #3239.
2016-05-18 16:30:20 +02:00
antirez
e3edae957b Modules: RM_HashSet() SDS ownership business clarified in comments.
Related to #3239.
2016-05-18 16:30:20 +02:00
Salvatore Sanfilippo
64a225a31a Merge pull request #3239 from dvirsky/fix_hashset_crash
fixed bad transfer of ownership in HashSet causing a potential crash
2016-05-18 07:15:15 -07:00
Salvatore Sanfilippo
01a83d0a2a Merge pull request #3239 from dvirsky/fix_hashset_crash
fixed bad transfer of ownership in HashSet causing a potential crash
2016-05-18 07:15:15 -07:00
antirez
cbcee71ccb Code to access object string bytes repeated 3x refactored into 1 function. 2016-05-18 15:35:19 +02:00
antirez
bee963c445 Code to access object string bytes repeated 3x refactored into 1 function. 2016-05-18 15:35:19 +02:00