Guy Benoish
444dd1075c
Stream: Handle streamID-related edge cases
...
This commit solves several edge cases that are related to
exhausting the streamID limits: We should correctly calculate
the succeeding streamID instead of blindly incrementing 'seq'
This affects both XREAD and XADD.
Other (unrelated) changes:
Reply with a better error message when trying to add an entry
to a stream that has exhausted last_id
2019-12-29 15:46:31 +01:00
Oran Agra
f866b31a74
config.c adjust config limits and mutable
...
- make lua-replicate-commands mutable (it never was, but i don't see why)
- make tcp-backlog immutable (fix a recent refactory mistake)
- increase the max limit of a few configs to match what they were before
the recent refactory
2019-12-29 15:46:31 +01:00
antirez
1b56a873d5
Inline protocol: handle empty strings well.
...
This bug is from the first version of Redis. Probably the problem here
is that before we used an SDS split function that created empty strings
for additional spaces, like in "SET foo bar".
AFAIK later we replaced it with the curretn sdssplitarg() API that has
no such a problem. As a result, we introduced a bug, where it is no
longer possible to do something like:
SET foo ""
Using the inline protocol. Now it is fixed.
2019-12-29 15:46:31 +01:00
antirez
a640d1bb5c
Fix ip and missing mode in RM_GetClusterNodeInfo().
2019-12-29 15:46:31 +01:00
antirez
2df099e36b
Redis 6.0 RC1.
2019-12-19 17:27:29 +01:00
Salvatore Sanfilippo
95a43c2178
Merge pull request #6615 from soloestoy/wrap-also-propagate-as-multi
...
Wrap also propagate as multi
2019-12-19 09:24:52 +01:00
Salvatore Sanfilippo
e8c964fc2f
Merge pull request #5780 from soloestoy/lua-multi-more-clear
...
scripting: flag lua_client as CLIENT_MULTI after redis.replicate_command() immediately
2019-12-19 09:06:28 +01:00
Salvatore Sanfilippo
3d344f9467
Merge pull request #6052 from jtru/better-systemd-integration-v2
...
Better systemd integration v2
2019-12-19 08:54:22 +01:00
antirez
15e2c2b2f1
Modules: rewrite top function doc of AvoidReplicaTraffic().
2019-12-18 17:11:03 +01:00
Salvatore Sanfilippo
f9644f1903
Merge pull request #6497 from oranagra/avoid_replica_traffic
...
Add config and module API for AvoidReplicaTraffic
2019-12-18 17:06:05 +01:00
antirez
b40973731b
Fix GEOHASH negative shifting in a more compatible way.
2019-12-18 12:57:32 +01:00
antirez
e7ddea016d
Revert "Geo: output 10 chars of geohash, not 11."
...
This reverts commit bdca9e882d1619bde19cbad78549f3167ddc3d41.
2019-12-18 12:54:46 +01:00
antirez
75687fcf17
Avoid changing setKey() API after #6679 fix.
2019-12-18 11:58:02 +01:00
Salvatore Sanfilippo
9ad318fffd
Merge pull request #6679 from soloestoy/keepttl
...
Add a new SET option KEEPTTL and fix issue #5256
2019-12-18 11:52:08 +01:00
zhaozhao.zz
5c56f82bc3
incrbyfloat: fix issue #5256 ttl lost after propagate
2019-12-18 15:44:51 +08:00
zhaozhao.zz
746c23419f
add a new SET option KEEPTTL that doesn't remove expire time
2019-12-18 15:20:36 +08:00
Salvatore Sanfilippo
8912e70042
Merge pull request #5916 from madolson/dev-unstable-acl-module-pr
...
Add module APIs for custom authentication
2019-12-17 09:58:26 +01:00
antirez
4eae0cdba7
Add some comment to PR #6144 changes.
2019-12-17 09:19:47 +01:00
Salvatore Sanfilippo
2c534a56e8
Merge pull request #6144 from madolson/dev-unstable-cluster-down
...
Add configuration option for allowing reads on cluster down
2019-12-17 09:15:20 +01:00
Madelyn Olson
db84e486b6
Removed old auth context reference
2019-12-17 07:51:19 +00:00
Madelyn Olson
a48e2b721a
Fixed some documentation
2019-12-17 07:49:21 +00:00
Madelyn Olson
2d2f4ee475
Resolved merge miss
2019-12-16 23:40:19 -08:00
Madelyn Olson
c5b20f96c2
Added a missed space in lua errors
2019-12-16 23:38:31 -08:00
Madelyn Olson
1ce271b9b4
Split error message so dependandent callers give a useful result
2019-12-16 23:34:37 -08:00
Madelyn Olson
35aed09f95
Added better exception handling around scripting and module
2019-12-16 23:33:53 -08:00
Madelyn Olson
d9c79ff75c
Add configuration option for allowing reads on cluster down
2019-12-16 23:33:16 -08:00
Madelyn Olson
783831bb10
Tweaking the documentation
2019-12-17 07:28:55 +00:00
Madelyn Olson
f71437d391
Added some documentation and fixed a test
2019-12-17 07:15:04 +00:00
Madelyn Olson
05b7628687
Add module APIs for custom authentication
2019-12-17 06:59:59 +00:00
Salvatore Sanfilippo
41a4fde4cc
Merge pull request #6649 from chaten/unstable
...
Fix outdated information on max memory policies
2019-12-16 11:25:53 +01:00
antirez
56694f09f2
Clarify change in #6662 .
2019-12-16 11:24:19 +01:00
antirez
caba0f876e
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-16 11:18:20 +01:00
Salvatore Sanfilippo
448b259548
Merge pull request #6662 from oranagra/fix_hz_div0
...
init server.hz early to avoid div by 0 during config file loading
2019-12-16 11:18:08 +01:00
antirez
c600118cfb
Modules: allow to execute RM_Call() from the module init function.
2019-12-13 17:34:37 +01:00
Salvatore Sanfilippo
d8f7bed924
Merge pull request #6663 from yossigo/fix-replace-value
...
Improve RM_ModuleTypeReplaceValue() API.
2019-12-12 18:00:07 +01:00
Yossi Gottlieb
937a32d84c
Improve RM_ModuleTypeReplaceValue() API.
...
With the previous API, a NULL return value was ambiguous and could
represent either an old value of NULL or an error condition. The new API
returns a status code and allows the old value to be returned
by-reference.
This commit also includes test coverage based on
tests/modules/datatype.c which did not exist at the time of the original
commit.
2019-12-12 18:50:11 +02:00
Oran Agra
d290b9ca58
init server.hz early to avoid div by 0 during config file loading
...
since the refactory of config.c, it was initialized from config_hz in initServer
but apparently that's too late since the config file loading creates objects
which call LRU_CLOCK
2019-12-12 17:56:02 +02:00
Salvatore Sanfilippo
96eb0b2b88
Merge pull request #6516 from IAmATeaPot418/patch-2
...
Add no-slowlog to acl command to prevent passwords
2019-12-12 09:41:19 +01:00
antirez
11e6e5dd85
redis-cli: some refactoring about not logging AUTH & co.
2019-12-12 09:40:36 +01:00
Salvatore Sanfilippo
aba958ab98
Merge pull request #6524 from itamarhaber/acl-cli
...
Omits `ACL SETUSER` from redis-cli's history
2019-12-12 09:33:48 +01:00
antirez
22552a5794
Remove useless space from moduleLoad().
2019-12-12 09:29:10 +01:00
Salvatore Sanfilippo
297c40cd54
Merge pull request #6257 from JohnSully/ModuleSecurity
...
Modules must have execute permissions to load
2019-12-12 09:27:47 +01:00
Salvatore Sanfilippo
f1f0548419
Merge branch 'unstable' into ModuleSecurity
2019-12-12 09:27:14 +01:00
Oran Agra
f4a1d066a6
Add module API for AvoidReplicaTraffic
...
This is useful to tell redis and modules to try to avoid doing things that may
increment the replication offset, and should be used when draining a master
and waiting for replicas to be in perfect sync before a failover.
2019-12-12 08:38:09 +02:00
Salvatore Sanfilippo
1ed8bda113
Merge pull request #6656 from oranagra/leak_rm_load_from_str
...
fix leak in RM_LoadDataTypeFromString, and save
2019-12-11 11:39:27 +01:00
Oran Agra
4e1326940c
fix leak in RM_LoadDataTypeFromString, and save
2019-12-11 12:35:00 +02:00
antirez
63cf0a2b7c
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-11 10:18:15 +01:00
antirez
5b203adbe0
Clients connected and bytes used is too spammy for verbose.
...
This message is there for ten years, but is hardly useful.
Moreover it is likely that it will fill an entire disk if log ratation
is not configured, for no good reasons.
2019-12-11 10:17:23 +01:00
antirez
bfc40083ac
create-cluster script tailall option.
2019-12-11 10:16:25 +01:00
Michael Chaten
71ec9478a6
Change description to be agnostic to the number of policies.
2019-12-09 11:27:53 -08:00