John Sully
e5e1350219
Fix polarity issue in async rehash
...
Former-commit-id: 9eefba49d4fcde7f12929929d7aeb36f5186a63d
2021-02-09 02:41:44 +00:00
John Sully
2c6616bd82
Fix polarity issue in async rehash
...
Former-commit-id: 9eefba49d4fcde7f12929929d7aeb36f5186a63d
2021-02-09 02:41:44 +00:00
John Sully
3de15c16ac
Fix deadlock with disconnecting client and storage provider
...
Former-commit-id: 0831745323e425f463322e8c0dc27fc25854868e
2021-02-08 19:02:01 +00:00
John Sully
f6b9c13c54
Fix deadlock with disconnecting client and storage provider
...
Former-commit-id: 0831745323e425f463322e8c0dc27fc25854868e
2021-02-08 19:02:01 +00:00
John Sully
078abba316
Merge branch 'unstable' into keydbpro
...
Former-commit-id: e2140793f2bf565972ada799af73bf4457e2718d
2021-02-08 18:17:09 +00:00
John Sully
e5343f47c2
Merge branch 'unstable' into keydbpro
...
Former-commit-id: e2140793f2bf565972ada799af73bf4457e2718d
2021-02-08 18:17:09 +00:00
Huang Zw
65801af4d0
Fix typo and some out of date comments ( #8449 )
...
Fix typo and some out of date comments
2021-02-08 09:29:32 -08:00
Huang Zw
8f9958dc24
Fix typo and some out of date comments ( #8449 )
...
Fix typo and some out of date comments
2021-02-08 09:29:32 -08:00
Yossi Gottlieb
4f0362b59e
Fix and cleanup Sentinel leaked fds test. ( #8469 )
...
* For consistency, use tclsh for the script as well
* Ignore leaked fds that originate from grandparent process, since we
only care about fds redis-sentinel itself is responsible for
* Check every test iteration to catch problems early
* Some cleanups, e.g. parameterization of file name, etc.
2021-02-08 17:02:46 +02:00
Yossi Gottlieb
dbcc0a85d0
Fix and cleanup Sentinel leaked fds test. ( #8469 )
...
* For consistency, use tclsh for the script as well
* Ignore leaked fds that originate from grandparent process, since we
only care about fds redis-sentinel itself is responsible for
* Check every test iteration to catch problems early
* Some cleanups, e.g. parameterization of file name, etc.
2021-02-08 17:02:46 +02:00
filipe oliveira
36e54e93b7
[fix] Increasing block on background timeout time to avoid test failure ( #8470 )
...
The test failed from time to time on Github actions.
We think it's possible that on the module's blocking timeout
time tracking test, the timeout is happening prior we issue the
RedisModule_BlockedClientMeasureTimeStart(bc) on the
background thread. If that is the case one possible solution
is to increase the timeout.
Increasing to 200ms to 500ms to see if nightly stops failing.
2021-02-08 16:24:00 +02:00
filipe oliveira
b2351ea0dc
[fix] Increasing block on background timeout time to avoid test failure ( #8470 )
...
The test failed from time to time on Github actions.
We think it's possible that on the module's blocking timeout
time tracking test, the timeout is happening prior we issue the
RedisModule_BlockedClientMeasureTimeStart(bc) on the
background thread. If that is the case one possible solution
is to increase the timeout.
Increasing to 200ms to 500ms to see if nightly stops failing.
2021-02-08 16:24:00 +02:00
sundb
77a3aae99e
Fix random probability check in ziplistRandomPairsUnique ( #8467 )
...
When (remaining == (total_size - index)), element will definitely be random to.
But when rand() == RAND_MAX, the element will miss, this will trigger assert
in serverAssert(ziplistRandomPairsUnique(zsetobj->ptr, count, keys, vals) == count).
2021-02-08 12:41:16 +02:00
sundb
1f12be3072
Fix random probability check in ziplistRandomPairsUnique ( #8467 )
...
When (remaining == (total_size - index)), element will definitely be random to.
But when rand() == RAND_MAX, the element will miss, this will trigger assert
in serverAssert(ziplistRandomPairsUnique(zsetobj->ptr, count, keys, vals) == count).
2021-02-08 12:41:16 +02:00
Andy Pan
be48f04807
Fix typos in comments ( #8466 )
2021-02-08 12:09:39 +02:00
Andy Pan
88272cf7ac
Fix typos in comments ( #8466 )
2021-02-08 12:09:39 +02:00
John Sully
4efab08466
Fix bug in fastlock stack metadata
...
Former-commit-id: 241d1bd7e1ed64885adbb07653a5c7e8ef882607
2021-02-07 19:11:05 -05:00
John Sully
bb733b0aab
Fix bug in fastlock stack metadata
...
Former-commit-id: 241d1bd7e1ed64885adbb07653a5c7e8ef882607
2021-02-07 19:11:05 -05:00
John Sully
662fc28fdc
Disable multithreaded rehash when active defrag is enabled. The two are not compatible
...
Former-commit-id: 56addcd17262ffbaefea26c0097cde53c616ece2
2021-02-07 19:11:05 -05:00
John Sully
7d588e637a
Disable multithreaded rehash when active defrag is enabled. The two are not compatible
...
Former-commit-id: 56addcd17262ffbaefea26c0097cde53c616ece2
2021-02-07 19:11:05 -05:00
John Sully
1b3dc3d422
The server should recalibrate periodically. Also reduce log noise
...
Former-commit-id: 8d8e1810d49da6aa921d2327cb4ea250c2b5b234
2021-02-07 19:11:05 -05:00
John Sully
3970f4a5a7
The server should recalibrate periodically. Also reduce log noise
...
Former-commit-id: 8d8e1810d49da6aa921d2327cb4ea250c2b5b234
2021-02-07 19:11:05 -05:00
John Sully
27552cb307
Ensure the C lock implementation behaves the same as the ASM
...
Former-commit-id: b5ddc11c46d2eabd28fae4c69927c356dd18bf6e
2021-02-07 19:11:05 -05:00
John Sully
8ce03686ed
Ensure the C lock implementation behaves the same as the ASM
...
Former-commit-id: b5ddc11c46d2eabd28fae4c69927c356dd18bf6e
2021-02-07 19:11:05 -05:00
John Sully
ba006abe02
Ensure rehash completes even when we're in a long running task
...
Former-commit-id: f107746e90f7a8ff3c7094145ee1ad438911e8c2
2021-02-07 19:11:05 -05:00
John Sully
7c700f1987
Ensure rehash completes even when we're in a long running task
...
Former-commit-id: f107746e90f7a8ff3c7094145ee1ad438911e8c2
2021-02-07 19:11:05 -05:00
John Sully
495dff1e8c
Implement rehash during spinlock
...
Former-commit-id: f68a26381a35b27948046d46c2c7bcfbdc21143d
2021-02-07 19:11:05 -05:00
John Sully
bef72e5f6a
Implement rehash during spinlock
...
Former-commit-id: f68a26381a35b27948046d46c2c7bcfbdc21143d
2021-02-07 19:11:05 -05:00
John Sully
071ecb801a
Allow multiple threads to rehash simultaneously
...
Former-commit-id: 5a2cc90786dfd1bfd341dbf5713bcde01f0cfff3
2021-02-07 19:11:05 -05:00
John Sully
5ab1095022
Allow multiple threads to rehash simultaneously
...
Former-commit-id: 5a2cc90786dfd1bfd341dbf5713bcde01f0cfff3
2021-02-07 19:11:05 -05:00
John Sully
6379ae6c7f
Fix races in free
...
Former-commit-id: 3881d5c1f22f022855c0abcf7b0c2070e204c0a3
2021-02-07 19:11:05 -05:00
John Sully
5d161ca2f2
Fix races in free
...
Former-commit-id: 3881d5c1f22f022855c0abcf7b0c2070e204c0a3
2021-02-07 19:11:05 -05:00
John Sully
1c0b603def
Initial implementation
...
Former-commit-id: 958f2c00c8efc15dc91fdeec2ff2e2ae2016c124
2021-02-07 19:11:05 -05:00
John Sully
c6c1084dd8
Initial implementation
...
Former-commit-id: 958f2c00c8efc15dc91fdeec2ff2e2ae2016c124
2021-02-07 19:11:05 -05:00
John Sully
5c884b6fd8
Merge branch 'keydbpro' into PRO_RELEASE_6
...
Former-commit-id: 4a269c3382083f6ad7f697ef07eebc552e0de9d8
2021-02-08 00:02:54 +00:00
John Sully
a997b2d5ad
Merge branch 'keydbpro' into PRO_RELEASE_6
...
Former-commit-id: 4a269c3382083f6ad7f697ef07eebc552e0de9d8
2021-02-08 00:02:54 +00:00
John Sully
f4c7da7284
Merge branch 'unstable' into RELEASE_6
...
Former-commit-id: 0b7b5332f2a3bb5a6f4310643c343f53f546bd81
2021-02-07 23:55:58 +00:00
John Sully
2da3216228
Merge branch 'unstable' into RELEASE_6
...
Former-commit-id: 0b7b5332f2a3bb5a6f4310643c343f53f546bd81
2021-02-07 23:55:58 +00:00
John Sully
aa47e643b0
Fix memory leak in mvccRestore
...
Former-commit-id: 165333b0fc648c79e66f04d9c8c4a1d0059fe57a
2021-02-07 23:38:49 +00:00
John Sully
e55ca3603c
Fix memory leak in mvccRestore
...
Former-commit-id: 165333b0fc648c79e66f04d9c8c4a1d0059fe57a
2021-02-07 23:38:49 +00:00
John Sully
e2f634aef5
Fix cluster test failure
...
Former-commit-id: 230fde39882766426d892fd30d0c8349f5cca912
2021-02-07 23:38:25 +00:00
John Sully
4c9f912c3b
Fix cluster test failure
...
Former-commit-id: 230fde39882766426d892fd30d0c8349f5cca912
2021-02-07 23:38:25 +00:00
John Sully
6a7b193fc1
Fix memory leak in mvccRestore
...
Former-commit-id: 92da1cbd0a08b66264f170a9b57ef7270f270157
2021-02-07 23:38:09 +00:00
John Sully
ea74c705a6
Fix memory leak in mvccRestore
...
Former-commit-id: 92da1cbd0a08b66264f170a9b57ef7270f270157
2021-02-07 23:38:09 +00:00
John Sully
52c1d17127
Update test to handle forkless bgsave
...
Former-commit-id: fc8c6de8252e6b802688413050f1a823093d0a1d
2021-02-07 21:41:19 +00:00
John Sully
483b43156e
Update test to handle forkless bgsave
...
Former-commit-id: fc8c6de8252e6b802688413050f1a823093d0a1d
2021-02-07 21:41:19 +00:00
John Sully
b20ab1fd21
Merge branch 'keydbpro' of https://gitlab.eqalpha.com/keydb-dev/KeyDB-Pro into keydbpro
...
Former-commit-id: 8bad923169b2a73f249fd8b3153236d6a74100c9
2021-02-07 20:53:07 +00:00
John Sully
886fcf6387
Merge branch 'keydbpro' of https://gitlab.eqalpha.com/keydb-dev/KeyDB-Pro into keydbpro
...
Former-commit-id: 8bad923169b2a73f249fd8b3153236d6a74100c9
2021-02-07 20:53:07 +00:00
jsully
1c0c0ebd3f
Merge branch 'opensourcemerge_2021-02-01' into 'keydbpro'
...
Merge from open source Feb 5 2021
See merge request keydb-dev/KeyDB-Pro!9
Former-commit-id: 1a2e2b99cc0123b1b03b78b5f28107df395decdb
2021-02-07 20:49:08 +00:00
jsully
ab45347ed6
Merge branch 'opensourcemerge_2021-02-01' into 'keydbpro'
...
Merge from open source Feb 5 2021
See merge request keydb-dev/KeyDB-Pro!9
Former-commit-id: 1a2e2b99cc0123b1b03b78b5f28107df395decdb
2021-02-07 20:49:08 +00:00