John Sully
2526d51d1a
Thread safety fixes
2019-02-18 22:25:35 -05:00
John Sully
2f9d958e96
Reduce memory usage for in place strings by 8 bytes
2019-02-09 13:04:18 -05:00
John Sully
41a24e689e
Make main headers C++ safe, and change rdb to use file descriptor instead of FILE pointer
2019-02-05 23:36:40 -05:00
John Sully
0ffcf355fe
Custom flash heap
2019-01-29 18:10:46 -05:00
antirez
cbb6c8f978
RESP3: t_stream.c updated.
2019-01-09 17:00:29 +01:00
antirez
9956f4f61b
Stream: fix XREADGROUP history reading of deleted messages.
...
This commit fixes #5570 . It is a similar bug to one fixed a few weeks
ago and is due to the range API to be called with NULL as "end ID"
parameter instead of repeating again the start ID, to be sure that we
selectively issue the entry with a given ID, or we get zero returned
(and we know we should emit a NULL reply).
2018-11-19 17:00:34 +01:00
antirez
cd47c66c7a
Streams: fix XREADGROUP history reading when CG last_id is low.
...
This fixes the issue reported in #5570 .
This was fixed the hard way, that is, propagating more information to
the lower level API about this being a request to read just the history,
so that the code is simpler and less likely to regress.
2018-11-19 16:41:27 +01:00
antirez
f943c1d3f4
t_stream.c comment resized to 80 cols.
2018-11-19 16:26:02 +01:00
antirez
7f5f6d954e
Fix XCLAIM missing entry bug.
...
This bug had a double effect:
1. Sometimes entries may not be emitted, producing broken protocol where
the array length was greater than the emitted entires, blocking the
client waiting for more data.
2. Some other time the right entry was claimed, but a wrong entry was
returned to the client.
This fix should correct both the instances.
2018-11-05 13:17:32 +01:00
antirez
9bfdc19946
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-11-05 13:07:14 +01:00
antirez
27cf2a7c00
Improve streamReplyWithRange() top comment.
2018-11-05 13:06:01 +01:00
michael-grunder
71a2f9b1b4
Use typedef'd mstime_t instead of time_t
...
This fixes an overflow on 32-bit systems.
2018-11-03 15:13:28 -07:00
Guy Korland
8e3ec37117
Fix some typos
2018-10-31 17:33:53 +02:00
antirez
c7818eec49
Add command fingerprint comment for XSETID.
2018-10-25 13:08:48 +02:00
antirez
235645f5ae
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 11:50:15 +02:00
Salvatore Sanfilippo
1a8f69c990
Merge pull request #5459 from itamarhaber/xpending_count_underflow
...
A fix to XPENDING's count underflow
2018-10-25 11:50:04 +02:00
antirez
f66299705b
Fix XRANGE COUNT option for value of 0.
2018-10-25 11:36:24 +02:00
antirez
95770b8a52
Fix typo in streamReplyWithRange() top comment.
2018-10-24 16:28:44 +02:00
Itamar Haber
af29051e9d
Plugs a potential underflow
2018-10-17 19:33:11 +03:00
antirez
0e3cd8fbc7
Streams: use bulk replies instead of status replies.
...
They play better with Lua scripting, otherwise Lua will see status
replies as "ok" = "string" which is very odd, and actually as @oranagra
reasoned in issue #5456 in the rest of the Redis code base there was no
such concern as saving a few bytes when the protocol is emitted.
2018-10-17 17:21:09 +02:00
Itamar Haber
b404783fea
Corrects inline documentation of syntax
2018-10-17 16:13:55 +03:00
antirez
333a39dc33
Fix conditional in XGROUP.
2018-10-17 13:00:35 +02:00
antirez
7707bd7bf3
Fix XGROUP CREATE MKSTREAM handling of .
2018-10-17 12:10:52 +02:00
antirez
a4a03d8df2
Process MKSTREAM option of XGROUP CREATE at a later time.
...
This avoids issues with having to replicate a command that produced
errors.
2018-10-17 12:04:06 +02:00
antirez
2e0f4eb757
XGROUP CREATE: MKSTREAM option for automatic stream creation.
2018-10-17 11:27:27 +02:00
antirez
03e2232857
XSETID: accept IDs based on last entry.
...
Related to #5426 .
2018-10-16 16:46:17 +02:00
antirez
2093b42879
Streams: XSTREAM SETID -> XSETID.
...
Keep vanilla stream commands at toplevel, see #5426 .
2018-10-16 13:17:14 +02:00
Salvatore Sanfilippo
060cd5c941
Merge pull request #5426 from soloestoy/feature-xstream
...
Bugfix data inconsistency after aof rewrite, and add XSTREAM command.
2018-10-16 13:10:36 +02:00
antirez
71d6760f48
Make comment about nack->consumer test for minidle more obvious.
...
Related to #5437 .
2018-10-15 12:01:17 +02:00
antirez
b061b05d5f
Streams: use propagate_last_id itself as streamPropagateGroupID trigger.
...
Avoid storing the dirty value. See #5437 .
2018-10-15 11:52:24 +02:00
antirez
9372eddb95
Streams: better naming: lastid_updated -> propagate_last_id.
...
See #5437 but also I updated a previous usage of the same var name.
2018-10-15 11:50:18 +02:00
zhaozhao.zz
cae5cb86bc
Streams: panic if streamID invalid after check, should not be possible.
2018-10-11 21:46:47 +08:00
zhaozhao.zz
df4099c0d2
Streams: propagate lastid in XCLAIM when it has effect
2018-10-11 21:44:20 +08:00
zhaozhao.zz
929e39d1f5
Streams: XCLAIM ignore minidle if NACK is created by FORCE
...
Because the NACK->consumer is NULL, if idletime < minidle
the NACK does not belong to any consumer, then redis will crash
in XPENDING.
2018-10-11 21:20:49 +08:00
zhaozhao.zz
fe8a6c4fba
Streams: bugfix XCLAIM should propagate group name not consumer name
2018-10-11 21:12:09 +08:00
antirez
599e872fba
Fix propagation of consumer groups last ID.
...
Issue #5433 .
2018-10-10 12:51:02 +02:00
zhaozhao.zz
197e36df46
Streams: rewrite id in XSTREAM CREATE *
2018-10-09 16:22:30 +08:00
zhaozhao.zz
0a968cc348
Streams: add a new command XTREAM
...
XSTREAM CREATE <key> <id or *> -- Create a new empty stream.
XSTREAM SETID <key> <id or $> -- Set the current stream ID.
2018-10-09 13:11:04 +08:00
antirez
65598e3f22
Refactoring of XADD / XTRIM MAXLEN rewriting.
...
See #5141 .
2018-10-08 12:05:22 +02:00
Salvatore Sanfilippo
f654899b7f
Merge pull request #5141 from soloestoy/fix-xtrim-inconsistency
...
Fix XTRIM and XADD with MAXLEN inconsistency
2018-10-08 12:00:00 +02:00
antirez
511e94cabf
xclaimCommand(): fix comment typos.
2018-10-04 17:34:06 +02:00
antirez
de25d81b21
streamAppendItem(): Update the radix tree pointer only if changed.
2018-10-02 19:45:33 +02:00
antirez
9179b87231
streamIteratorRemoveEntry(): set back lp only if pointer changed.
...
Most of the times the pointer will remain the same since integers of
similar size don't take more space in listpacks.
Related to #5210 .
2018-10-02 16:20:40 +02:00
Salvatore Sanfilippo
132e115d29
Merge pull request #5210 from soloestoy/raxinsert-in-xdel
...
Streams: update listpack with new pointer in XDEL
2018-10-02 16:18:55 +02:00
antirez
241e2e938d
Fix XINFO comment for consistency.
2018-10-01 11:38:58 +02:00
Guy Korland
1c32aebf8c
add missing argument to function doc
2018-09-21 02:46:31 +03:00
Sascha Roland
24fe102997
#5299 Fix blocking XREAD for streams that ran dry
...
The conclusion, that a xread request can be answered syncronously in
case that the stream's last_id is larger than the passed last-received-id
parameter, assumes, that there must be entries present, which could be
returned immediately.
This assumption fails for empty streams that actually contained some
entries which got removed by xdel, ... .
As result, the client is answered synchronously with an empty result,
instead of blocking for new entries to arrive.
An additional check for a non-empty stream is required.
2018-09-04 13:13:36 +02:00
zhaozhao.zz
594d3b9023
Streams: update listpack with new pointer in XDEL
2018-08-04 01:06:53 +08:00
Salvatore Sanfilippo
4898e66aff
Merge pull request #5146 from 0xtonyxia/fix-xclaim-id-parse
...
Streams: ID of xclaim command should start from the sixth argument.
2018-08-03 13:45:27 +02:00
shenlongxing
82d4d8020f
Fix stream command paras
2018-08-03 19:01:15 +08:00