Oran Agra
0bf6face8a
Don't queue commands in an already aborted MULTI state
2020-06-08 09:43:10 +03:00
Oran Agra
b64641f995
Avoid rejecting WATCH / UNWATCH, like MULTI/EXEC/DISCARD
...
Much like MULTI/EXEC/DISCARD, the WATCH and UNWATCH are not actually
operating on the database or server state, but instead operate on the
client state. the client may send them all in one long pipeline and check
all the responses only at the end, so failing them may lead to a
mismatch between the client state on the server and the one on the
client end, and execute the wrong commands (ones that were meant to be
discarded)
the watched keys are not actually stored in the client struct, but they
are in fact part of the client state. for instance, they're not cleared
or moved in SWAPDB or FLUSHDB.
2020-06-08 09:16:32 +03:00
John Sully
ad4d76422c
Some valgrind fixes
...
Former-commit-id: ba974c9810dc30b6b5bd21c4bcc6cc5b219f7ea4
2020-06-07 23:20:10 -04:00
John Sully
f252cc9e41
fix valgrind false error
...
Former-commit-id: 9817db7eddf06becd151e5fef7cc6808777c49cb
2020-06-07 20:17:47 -04:00
John Sully
08842f8d6e
Endurance mode for tests ignore flaky ones
...
Former-commit-id: 515bb0e6bda8abcab4f8b4cd693084594c734007
2020-06-07 16:59:59 -04:00
John Sully
00ae6d58a9
Bump version
...
Former-commit-id: 4a3e1f3b9b164ec0f19ca2a67c8003792a5ccc5c
2020-06-07 16:43:07 -04:00
John Sully
f26d5048cd
Solo tests should work with loopn
...
Former-commit-id: 575fc9801094985e24671101e68549787b536782
2020-06-07 16:43:07 -04:00
John Sully
3c63be7159
Stream tests rely on deferring clients, mitigate races caused by them
...
Former-commit-id: eb18345a6113296b98fc59599aa670d58166081a
2020-06-07 16:43:07 -04:00
John Sully
cb7b03aeea
replication test race
...
Former-commit-id: d528c5c2c2ff8497563b5dc012f9ad458e93ecd4
2020-06-07 16:43:07 -04:00
John Sully
3b083f4ed9
fix race in test
...
Former-commit-id: fa03a539f391e53bcd8237625dc0b52f3f25c9bd
2020-06-07 16:43:07 -04:00
John Sully
668d482f08
Make lazyfree more reliable
...
Former-commit-id: 9646b1d94475e39066887062f96f493c7529e440
2020-06-07 16:43:07 -04:00
John Sully
55633ab401
Detect issues like #189
...
Former-commit-id: cc5e906ebd3b09367f0a0daf861923e55182f1fd
2020-06-07 16:43:07 -04:00
John Sully
d0d24e04f0
Ensure CRON jobs run in a clean environment
...
Former-commit-id: b0e14683b2e655dc3aeb2f19b9227fc7fa24cc73
2020-06-07 16:43:07 -04:00
John Sully
e2cd106d2d
Undecorated new is OK to use
...
Former-commit-id: 8d5cc4cf0c9d05f0d68cffec2b87b5c3dcb562ba
2020-06-07 16:43:07 -04:00
John Sully
0120d23a48
Solo tests should work with loopn
...
Former-commit-id: bc7ea8fb20c71ace6c35559791e2e8dc6bf4097b
2020-06-07 15:06:50 -04:00
John Sully
97908941bf
Stream tests rely on deferring clients, mitigate races caused by them
...
Former-commit-id: 2caf8e4c8095215b189942b7eaec3bf5023f7fcf
2020-06-07 13:59:41 -04:00
xhe
4c5eb1cac1
return the correct proto version
...
HELLO should return the current proto version, while the code hardcoded
3
2020-06-07 13:34:55 +08:00
John Sully
7384abfe56
replication test race
...
Former-commit-id: e1f3cd6ec3bf2319484de04c3796dcfa75e0479c
2020-06-07 01:14:57 -04:00
John Sully
c60bf228b4
fix race in test
...
Former-commit-id: 02e821530a402796697e63c68e768b563de0a3cb
2020-06-07 00:44:11 -04:00
John Sully
ebf5d2826a
Make lazyfree more reliable
...
Former-commit-id: b6c3d80edbdc4348c071b4108b039f4da5c88ce5
2020-06-07 00:40:58 -04:00
Oran Agra
fed743b2e1
fix pingoff test race
2020-06-06 11:44:21 +02:00
Kevin Fwu
ce014c2a3b
Fix TLS certificate loading for chained certificates.
...
This impacts client verification for chained certificates (such as Lets
Encrypt certificates). Client Verify requires the full chain in order to
properly verify the certificate.
2020-06-06 11:44:21 +02:00
antirez
5fe90c04a1
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-06-06 11:44:05 +02:00
antirez
bec1ac9899
Revert "Implements sendfile for redis."
...
This reverts commit 5675053269b0cbc2cf525c99321c96b7c2b39abe.
2020-06-06 11:43:29 +02:00
antirez
8bfdba1e08
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit 13bbd165e87923558952203d310e9ad053d4d7c0.
2020-06-06 11:43:29 +02:00
Liu Zhen
123d94ffc0
fix clusters mixing accidentally by gossip
...
`clusterStartHandshake` will start hand handshake
and eventually send CLUSTER MEET message, which is strictly prohibited
in the REDIS CLUSTER SPEC.
Only system administrator can initiate CLUSTER MEET message.
Futher, according to the SPEC, rather than IP/PORT pairs, only nodeid
can be trusted.
2020-06-06 11:43:29 +02:00
antirez
a5f0fa7f7a
Fix handling of special chars in ACL LOAD.
...
Now it is also possible for ACL SETUSER to accept empty strings
as valid operations (doing nothing), so for instance
ACL SETUSER myuser ""
Will have just the effect of creating a user in the default state.
This should fix #7329 .
2020-06-06 11:43:29 +02:00
antirez
8b15ba933d
Revert "Implements sendfile for redis."
...
This reverts commit 5675053269b0cbc2cf525c99321c96b7c2b39abe.
2020-06-06 11:42:45 +02:00
antirez
3b452cac99
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit 13bbd165e87923558952203d310e9ad053d4d7c0.
2020-06-06 11:42:41 +02:00
John Sully
8f8015bb22
Detect issues like #189
...
Former-commit-id: 0042586190a3e5b212a015aeb3577695cd3623c5
2020-06-05 22:18:28 -04:00
John Sully
779023beff
Ensure CRON jobs run in a clean environment
...
Former-commit-id: c6dce838b7cc94e115fd73a64dda663f0a2c28c5
2020-06-05 21:35:47 -04:00
zhaozhao.zz
cfc3e6f55d
AOF: append origin SET if no expire option
2020-06-03 17:55:18 +08:00
zhaozhao.zz
14dc507de2
donot free protected client in freeClientsInAsyncFreeQueue
...
related #7234
2020-06-02 11:48:14 +08:00
John Sully
64adf015b1
Undecorated new is OK to use
...
Former-commit-id: 5b885bb1649805f6a2edb8d28edd1447bb6c4843
2020-06-01 23:36:01 -04:00
John Sully
a90ff44fb8
RELEASE endurance tests should run offset from unstable
...
Former-commit-id: b608acb3496bbf5a19823ba426c08adf1cfaa296
2020-06-01 17:02:16 -04:00
John Sully
c799f6855b
Bump version
...
Former-commit-id: 8dbea2a050dd9e741018230fedeeda46780a7a31
2020-06-01 17:01:50 -04:00
John Sully
419720d5ef
maxmem tests should be run solo for higher reliability
...
Former-commit-id: 95f46e60779fca715244745ced7b2ab04bbf9e3a
2020-06-01 16:50:30 -04:00
John Sully
b2a885c98f
Remove debug logs that shouldn't have been checked in
...
Former-commit-id: 31f58311e3de7441d81dd37bd4396be3b64efec5
2020-06-01 16:34:05 -04:00
John Sully
4820142896
PSYNC test shouldn't wait forever
...
Former-commit-id: 130613e16636923296a8d5b2c4bc623e62fef2f5
2020-06-01 16:13:58 -04:00
John Sully
92de178bfe
PSYNC test reliability improvements (test only issue)
...
Former-commit-id: 50fd4fa7e62f3996f15f6a8c4dcd892022f111ec
2020-06-01 16:01:26 -04:00
John Sully
9e87395c34
Fix for issue #187 we need to properly handle the case where a key with a subkey expirey itself expires during load
...
Former-commit-id: e6a9a6b428b91b6108df24ae6285ea9b582b7b23
2020-06-01 15:33:19 -04:00
John Sully
02d602b3fd
Update endurance.yml
...
Former-commit-id: d6be93537ebd31f1c6c1dc63c5d3c299b49efec9
2020-06-01 00:25:31 -04:00
John Sully
0a9a32e5d7
Fix module multithreaded test failures
...
Former-commit-id: 1ef35cf466ea944c56974b3795d7d6b5e89f5a3d
2020-05-31 23:46:12 -04:00
John Sully
08fca5ef31
sendfile has high latency in some scenarios, don't use it
...
Former-commit-id: 1eb0e3c1c604e71c54423f1d11b8c709c847a516
2020-05-31 23:22:25 -04:00
John Sully
b30fa046f4
we must always respect the output of sdscat, also change the string so its not a substring of other config params
...
Former-commit-id: e50313b20718bc8df0a53c11b0960e4bcb2177d4
2020-05-31 23:22:10 -04:00
John Sully
9b9c54b4ce
Do another iteration for endurance
...
Former-commit-id: ac3f8d1ac7af62b01816156b8578f4cbc48709e1
2020-05-31 22:51:02 -04:00
John Sully
4b317392be
Don't start multimaster tests until all nodes are connected
...
Former-commit-id: 202b97eff76501e736a2f0969607e3297e9703a4
2020-05-31 22:50:30 -04:00
John Sully
de0540d34b
Fix client race in test (test only issue)
...
Former-commit-id: f25aebf2698509a132ebf599374b245efb51e365
2020-05-31 21:39:50 -04:00
John Sully
dd45ade779
--loop should run forever
...
Former-commit-id: 9b1e636a6654a4ba3b629b5ad1097caf513ca000
2020-05-31 21:27:15 -04:00
John Sully
9ab9a7684d
PUBSUB test reliability: A client race was erroneously failing tests (test only issue)
...
Former-commit-id: 5147f0153ad1efb827a1709c10cd0f58e6ae65d8
2020-05-31 21:27:15 -04:00