Guy Benoish
a76a961cdd
Use __attribute__ only if __GNUC__ is defined
2020-04-03 14:49:40 +03:00
Salvatore Sanfilippo
f80b946bea
Merge pull request #6855 from guybe7/var_funcs_format_check
...
Modules: Perform printf-like format checks in variadic API
2020-04-03 13:46:27 +02:00
Guy Benoish
a8857320a5
Modules: Perform printf-like format checks in variadic API
2020-04-03 14:39:55 +03:00
Salvatore Sanfilippo
cbf212f981
Merge pull request #7030 from valentinogeron/xread-in-lua
...
XREAD and XREADGROUP should not be allowed from scripts when BLOCK op…
2020-04-03 11:14:13 +02:00
Salvatore Sanfilippo
4158664d2b
Merge pull request #6933 from guybe7/multi_exec_allow_stale
...
Stale replica should allow MULTI/EXEC
2020-04-03 11:12:58 +02:00
Salvatore Sanfilippo
4e8e7fb067
Merge pull request #7055 from zxdvd/patch-1
...
fix integer overflow
2020-04-03 11:10:26 +02:00
antirez
ef610802c7
LCS: fix stale comment.
2020-04-02 21:17:31 +02:00
Salvatore Sanfilippo
5b73ea3cf6
Merge pull request #7054 from guybe7/fix_neg_zero_test
...
Fix no-negative-zero test
2020-04-02 20:00:51 +02:00
Salvatore Sanfilippo
eb9ca33414
Merge pull request #6694 from oranagra/signal_modified_key
...
modules don't signalModifiedKey in setKey() since that's done (optionally) in RM_CloseKey
2020-04-02 19:00:20 +02:00
Xudong Zhang
78df016584
fix integer overflow
2020-04-02 23:43:47 +08:00
Guy Benoish
4665b3ebfb
Fix no-negative-zero test
2020-04-02 18:41:29 +03:00
Guy Benoish
85a0d29d04
Stale replica should allow MULTI/EXEC
...
Example: Client uses a pipe to send the following to a
stale replica:
MULTI
.. do something ...
DISCARD
The replica will reply the MUTLI with -MASTERDOWN and
execute the rest of the commands... A client using a
pipe might not be aware that MULTI failed until it's
too late.
I can't think of a reason why MULTI/EXEC/DISCARD should
not be executed on stale replicas...
Also, enable MULTI/EXEC/DISCARD during loading
2020-04-02 18:23:59 +03:00
Salvatore Sanfilippo
416d394cd9
Merge pull request #6927 from oranagra/ci-moduleapi-tests
...
change CI to build and run the module api tests
2020-04-02 16:32:41 +02:00
Salvatore Sanfilippo
0062194d74
Merge pull request #6654 from oranagra/fix_module_info_warning
...
fix possible warning on incomplete struct init
2020-04-02 16:32:20 +02:00
Salvatore Sanfilippo
10b626b3d5
Merge pull request #6546 from guybe7/fix_neg_zero
...
Make sure Redis does not reply with negative zero
2020-04-02 16:26:57 +02:00
Salvatore Sanfilippo
2f53ad30ee
Merge pull request #6813 from guybe7/debug_object_pass_keyname
...
DEBUG OBJECT should pass keyname to module when loading
2020-04-02 16:20:48 +02:00
antirez
5a3d85745a
LCS: output LCS len as well in IDX mode.
2020-04-02 16:15:17 +02:00
antirez
3f96e1623d
LCS: MINMATCHLEN and WITHMATCHLEN options.
2020-04-02 13:37:35 +02:00
Salvatore Sanfilippo
88351275fe
Merge pull request #6960 from devnexen/debug_arm_linux
...
debug, dump registers on arm too.
2020-04-02 11:26:08 +02:00
Salvatore Sanfilippo
fa4f50739a
Merge pull request #7006 from hwware/fixspelling
...
fix spelling in cluster.c clusterDelNode
2020-04-02 11:23:53 +02:00
Salvatore Sanfilippo
dfef407499
Merge pull request #7029 from valentinogeron/fix-xack
...
XACK should be executed in a "all or nothing" fashion.
2020-04-02 11:23:23 +02:00
Salvatore Sanfilippo
8d6dc136e1
Merge pull request #7041 from hwware/trackingfix
...
CLIENT TRACKING Command Fix: Add More Checking for OPTIN/OPTOUT mode
2020-04-02 11:22:30 +02:00
Salvatore Sanfilippo
b73d87f5e5
Merge pull request #7039 from guybe7/persist_ksn
...
PERSIST should notify a keyspace event
2020-04-02 11:21:20 +02:00
Salvatore Sanfilippo
babada8b5f
Merge pull request #7042 from guybe7/stream_cg_last_id_fix
...
streamReplyWithRange: Redundant XSETIDs to replica
2020-04-02 11:20:54 +02:00
antirez
80ec0431e8
Simplify comment in moduleTryServeClientBlockedOnKey().
2020-04-02 11:20:09 +02:00
antirez
545a5046f5
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-04-02 11:18:33 +02:00
Salvatore Sanfilippo
10afb9639a
Merge pull request #6798 from guybe7/module_circular_block
...
Fix memory corruption in moduleHandleBlockedClients
2020-04-02 11:17:29 +02:00
antirez
88e66ecf94
LCS: 7x speedup by accessing the array with better locality.
2020-04-01 23:45:07 +02:00
antirez
8cdc15c309
LCS: implement KEYS option.
2020-04-01 22:11:59 +02:00
antirez
4cbf3f5ddd
LCS: other fixes to range emission.
2020-04-01 17:36:32 +02:00
antirez
c9c03c3ee6
LCS: fix emission of last range starting at index 0.
2020-04-01 17:14:40 +02:00
antirez
b3400559be
LCS: implement range indexes option.
2020-04-01 17:11:31 +02:00
antirez
1010c1b43e
LCS: initial functionality implemented.
2020-04-01 16:13:18 +02:00
Guy Benoish
c4dc5b80b2
Fix memory corruption in moduleHandleBlockedClients
...
By using a "circular BRPOPLPUSH"-like scenario it was
possible the get the same client on db->blocking_keys
twice (See comment in moduleTryServeClientBlockedOnKey)
The fix was actually already implememnted in
moduleTryServeClientBlockedOnKey but it had a bug:
the funxction should return 0 or 1 (not OK or ERR)
Other changes:
1. Added two commands to blockonkeys.c test module (To
reproduce the case described above)
2. Simplify blockonkeys.c in order to make testing easier
3. cast raxSize() to avoid warning with format spec
2020-04-01 12:53:26 +03:00
antirez
957e917a84
Redis 6.0-RC3.
2020-03-31 17:56:04 +02:00
antirez
38076fd6ba
cast raxSize() to avoid warning with format spec.
2020-03-31 17:41:46 +02:00
antirez
ef1b1f01a8
cast raxSize() to avoid warning with format spec.
2020-03-31 17:41:23 +02:00
antirez
9f347fabba
Minor changes to #7037 .
2020-03-31 17:12:19 +02:00
Guy Benoish
a509400d58
Modules: Test MULTI/EXEC replication of RM_Replicate
...
Makse sure call() doesn't wrap replicated commands with
a redundant MULTI/EXEC
Other, unrelated changes:
1. Formatting compiler warning in INFO CLIENTS
2. Use CLIENT_ID_AOF instead of UINT64_MAX
2020-03-31 17:12:19 +02:00
antirez
1d13ff0b39
Minor changes to #7037 .
2020-03-31 17:10:09 +02:00
Salvatore Sanfilippo
0c52ce6c8e
Merge pull request #7037 from guybe7/fix_module_replicate_multi
...
Modules: Test MULTI/EXEC replication of RM_Replicate
2020-03-31 17:00:57 +02:00
antirez
c3b268a0bc
timeout.c created: move client timeouts code there.
2020-03-31 16:57:20 +02:00
Oran Agra
0f7dfc378c
AOFRW on an empty stream created with MKSTREAM loads badkly
...
the AOF will be loaded successfully, but the stream will be missing,
i.e inconsistencies with the original db.
this was because XADD with id of 0-0 would error.
add a test to reproduce.
2020-03-31 16:57:20 +02:00
Guy Benoish
805c8c94a9
RENAME can unblock XREADGROUP
...
Other changes:
Support stream in serverLogObjectDebugInfo
2020-03-31 16:57:20 +02:00
antirez
97b80b57e9
Fix the propagate Tcl test after module changes.
2020-03-31 16:57:20 +02:00
antirez
4f6b6b8008
Modify the propagate unit test to show more cases.
2020-03-31 16:57:20 +02:00
antirez
616b1cb7ac
Fix module commands propagation double MULTI bug.
...
37a10cef introduced automatic wrapping of MULTI/EXEC for the
alsoPropagate API. However this collides with the built-in mechanism
already present in module.c. To avoid complex changes near Redis 6 GA
this commit introduces the ability to exclude call() MUTLI/EXEC wrapping
for also propagate in order to continue to use the old code paths in
module.c.
2020-03-31 16:57:20 +02:00
antirez
08fdef4bf6
Fix RM_Call() stale comment due to cut&paste.
2020-03-31 16:57:20 +02:00
OMG-By
26b79ca18c
fix: dict.c->dictResize()->minimal type
2020-03-31 16:57:20 +02:00
zhaozhao.zz
fa41863752
PSYNC2: reset backlog_idx and master_repl_offset correctly
2020-03-31 16:57:20 +02:00