gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,498 Commits 1 Branch 0 Tags
Commit Graph

12498 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
WuYunlong
23ccd476b7 Add 14-consistency-check.tcl to prove there is a data consistency issue. 2020-03-25 15:54:34 +01:00
antirez
352ea2365f Aesthetic changes in PR #6989. 2020-03-25 15:54:34 +01:00
Itamar Haber
2eec521f8c Adds keyspace notifications to migrate and restore 2020-03-25 15:54:34 +01:00
antirez
91af3f73e1 Regression test for #7011. 2020-03-25 15:54:34 +01:00
bodong.ybd
a8f56fbfcd Remove duplicate obj files in Makefile 2020-03-25 15:54:34 +01:00
antirez
21c22bcd9a ACL: default user off should not allow automatic authentication. 
This fixes issue #7011.
 2020-03-25 15:54:34 +01:00
antirez
63e4a47010 Sentinel: document auth-user directive. 2020-03-25 15:54:34 +01:00
antirez
d9f9a29afa ACL: Make Redis 6 more backward compatible with requirepass. 
Note that this as a side effect fixes Sentinel "requirepass" mode.
 2020-03-25 15:54:34 +01:00
antirez
31707f25c7 Sentinel: implement auth-user directive for ACLs. 2020-03-25 15:54:34 +01:00
antirez
3734ba96ba PSYNC2: meaningful offset test. 2020-03-25 15:43:34 +01:00
antirez
21976106a9 PSYNC2: meaningful offset implemented. 
A very commonly signaled operational problem with Redis master-replicas
sets is that, once the master becomes unavailable for some reason,
especially because of network problems, many times it wont be able to
perform a partial resynchronization with the new master, once it rejoins
the partition, for the following reason:

1. The master becomes isolated, however it keeps sending PINGs to the
replicas. Such PINGs will never be received since the link connection is
actually already severed.
2. On the other side, one of the replicas will turn into the new master,
setting its secondary replication ID offset to the one of the last
command received from the old master: this offset will not include the
PINGs sent by the master once the link was already disconnected.
3. When the master rejoins the partion and is turned into a replica, its
offset will be too advanced because of the PINGs, so a PSYNC will fail,
and a full synchronization will be required.

Related to issue #7002 and other discussion we had in the past around
this problem.
 2020-03-25 15:26:37 +01:00
antirez
27a14b7a32 Explain why we allow transactions in -BUSY state. 
Related to #7022.
 2020-03-25 12:46:59 +01:00
Salvatore Sanfilippo
7090ea4e89 Merge pull request #7022 from oranagra/multi-busy-script 
MULTI/EXEC during LUA script timeout are messed up
 2020-03-25 12:44:26 +01:00
John Sully
41dfd175a8 Fix failure to load subkey expires 
Former-commit-id: 528a43bd6c80f073d928dd18c4f67f37cfd0977a
 2020-03-25 01:38:58 -04:00
John Sully
9ff5d3f3c4 Expire entry needs to be resorted after a subkey expires 
Former-commit-id: b357803362728c26a1169e3cec279c693b86205b
 2020-03-25 01:06:40 -04:00
John Sully
982175b584 Evict on load if we have a storage provider 
Former-commit-id: bb091796c3da7282e040c7b72a28ec1c5f5ecfb7
 2020-03-24 14:49:43 -04:00
John Sully
aed3d33499 Prevent issue where count can be out of sync temporarily, causing crashes where we expect the count to be perfect 
Former-commit-id: 77c9f36413c6f0cbb0b13a7ec746746c97faadcd
 2020-03-24 00:21:12 -04:00
John Sully
ad8a61697b Fix OOM errors during forkless bgsave 
Former-commit-id: c31c64b13409c741e8d52ad06add78300c39fce2
 2020-03-23 23:12:10 -04:00
John Sully
f0e85993ad Fix incorrect prefix comparison 
Former-commit-id: 1ef167546be0678edd457d65a5368e8706fde0a3
 2020-03-23 22:51:46 -04:00
John Sully
28c632729e Fix incorrect count when loading FLASH 
Former-commit-id: 38ee9c0df144621f7ca750527e9efb16e754ef40
 2020-03-23 19:47:48 -04:00
John Sully
b695c0279e Prevent bookkeeping keys from leaking through 
Former-commit-id: 1a5af28e115fc123bf250b4a80ac69232bb3add0
 2020-03-23 18:06:47 -04:00
Oran Agra
fd1e1935a6 MULTI/EXEC during LUA script timeout are messed up 
Redis refusing to run MULTI or EXEC during script timeout may cause partial
transactions to run.

1) if the client sends MULTI+commands+EXEC in pipeline without waiting for
response, but these arrive to the shards partially while there's a busy script,
and partially after it eventually finishes: we'll end up running only part of
the transaction (since multi was ignored, and exec would fail).

2) similar to the above if EXEC arrives during busy script, it'll be ignored and
the client state remains in a transaction.

the 3rd test which i added for a case where MULTI and EXEC are ok, and
only the body arrives during busy script was already handled correctly
since processCommand calls flagTransaction
 2020-03-23 20:45:32 +02:00
antirez
8dfbee0f89 Improve comments of replicationCacheMasterUsingMyself(). 2020-03-23 16:17:35 +01:00
antirez
fc92fa780b Fix BITFIELD_RO test. 2020-03-23 12:02:12 +01:00
antirez
0558a0b35e Abort transactions after -READONLY error. Fix #7014. 2020-03-23 11:47:49 +01:00
antirez
f3e021943f Minor changes to BITFIELD_RO PR #6951. 2020-03-23 11:28:09 +01:00
Salvatore Sanfilippo
5f848d8cb3 Merge pull request #6951 from yangbodong22011/feature-bitfield-ro 
Added BITFIELD_RO variants for read-only operations.
 2020-03-23 11:23:21 +01:00
antirez
6a2a1d9a00 Modules: updated function doc after #7003. 2020-03-23 11:17:50 +01:00
Salvatore Sanfilippo
47f3bca574 Merge pull request #7003 from guybe7/rm_context_flags_handle_null 
Allow RM_GetContextFlags to work with ctx==NULL
 2020-03-23 11:15:42 +01:00
Salvatore Sanfilippo
a97d1792e5 Merge pull request #7005 from hwware/memoryleakfix-redis-cli 
fix potential memory leak in redis-cli lua debug mode
 2020-03-23 11:14:46 +01:00
Salvatore Sanfilippo
1d5959f8ef Merge pull request #7018 from yossigo/fix-accept-issues 
Fix issues with failed/rejected accepts.
 2020-03-23 11:10:59 +01:00
Salvatore Sanfilippo
510c7430ec Merge pull request #7019 from hwware/cscfix 
Fix Bug for Client Side Caching: Unexpected Behaviour when Switching between OPTIN/OPTOUT Mode
 2020-03-23 11:09:55 +01:00
hwware
a2c5f8cfd5 remove redundant Semicolon 2020-03-23 01:07:46 -04:00
hwware
d286c1434a clean CLIENT_TRACKING_CACHING flag when disabled caching 2020-03-23 01:04:49 -04:00
Yossi Gottlieb
06391e27ce Fix crashes related to failed/rejected accepts. 2020-03-22 14:47:44 +02:00
Yossi Gottlieb
9895f32dfb Cluster: fix misleading accept errors. 2020-03-22 14:46:16 +02:00
Yossi Gottlieb
efea1b2001 Conns: Fix connClose() / connAccept() behavior. 
We assume accept handlers may choose to reject a connection and close
it, but connAccept() callers can't distinguish between this state and
other error states requiring connClose().

This makes it safe (and mandatory!) to always call connClose() if
connAccept() fails, and safe for accept handlers to close connections
(which will defer).
 2020-03-22 14:42:03 +02:00
Salvatore Sanfilippo
279d884983 Merge pull request #7013 from hwware/clusterhelpfix 
add missing commands description in cluster help
 2020-03-20 16:33:10 +01:00
hwware
8d8644b330 add missing commands in cluster help 2020-03-20 09:01:12 -04:00
antirez
08af68436d Merge branch 'unstable' of github.com:/antirez/redis into unstable 2020-03-20 13:21:28 +01:00
antirez
bbbd16a90d Regression test for #7011. 2020-03-20 12:52:06 +01:00
antirez
90f5d83381 ACL: default user off should not allow automatic authentication. 
This fixes issue #7011.
 2020-03-20 12:45:48 +01:00
John Sully
2b199b384d Unstable branch should always be version 0.0.0 
Former-commit-id: 448808529ab9e9e4705c2e7cbda5b3e6523b7c6f
 2020-03-19 15:52:24 -04:00
John Sully
436ffa98de Merge branch 'RELEASE_5' into unstable 
Former-commit-id: a0bc2084128f991697d3e1b7473d14c55afdd785
 2020-03-19 15:38:16 -04:00
John Sully
4f55afa948 Print stack traces of other threads in the deadlock detector 
Former-commit-id: 6b0172b9bf124372f4c8688c91c380c6c1b607c7
 2020-03-19 15:37:49 -04:00
John Sully
833f5b39f4 Log which thread a message came from 
Former-commit-id: bc1eccb66d3302d6c99588fb4a5a879e1ef243b1
 2020-03-19 15:37:24 -04:00
John Sully
1b9ef774da Fix lock inversion in processEventsWhileBlocked 
Former-commit-id: a9249d4a82a0f0355ac8ffa40b34b9c14cabf66b
 2020-03-19 15:28:39 -04:00
John Sully
96be5f6a6c Prevent dangling lock when we can't free the client 
Former-commit-id: 3c373494d63b21744b264f0a47e6999bcdda6b2b
 2020-03-19 14:34:23 -04:00
hwware
d59e54c32c fix spelling in cluster.c 2020-03-18 09:48:03 -04:00
hwware
ee1443973c fix potentical memory leak in redis-cli 2020-03-18 09:33:52 -04:00