Matt Stancliff
7e63dd23f3
Rename two 'buf' vars to 'ip' for better clarity
...
Clearly ip[32] is wrong, but it's less clear that buf[32] was wrong
without further reading.
2014-08-25 10:16:20 +02:00
Eiichi Sato
090afef1c4
Sentinel: fix bufsize to support IPv6 address
...
Closes #1914
2014-08-25 10:15:43 +02:00
Eiichi Sato
c38884ceac
Sentinel: fix bufsize to support IPv6 address
...
Closes #1914
2014-08-25 10:15:43 +02:00
Matt Stancliff
dd36d09ae6
Sentinel: Reject config from STDIN
...
Sentinel needs to die with a more accurate error message
when attempted to open a config from STDIN.
See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
2014-08-25 10:13:34 +02:00
Matt Stancliff
681de88df4
Sentinel: Reject config from STDIN
...
Sentinel needs to die with a more accurate error message
when attempted to open a config from STDIN.
See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
2014-08-25 10:13:34 +02:00
Matt Stancliff
1832617d46
Cluster: Fix segfault if cluster config corrupt
...
This commit adds a size check after initial config
line parsing to make sure we have *at least* 8 arguments
per line.
Also, instead of asserting for cluster->myself, we just test
and error out normally (since the error does a hard exit anyway).
Closes #1597
2014-08-25 10:11:38 +02:00
Matt Stancliff
60c448b584
Cluster: Fix segfault if cluster config corrupt
...
This commit adds a size check after initial config
line parsing to make sure we have *at least* 8 arguments
per line.
Also, instead of asserting for cluster->myself, we just test
and error out normally (since the error does a hard exit anyway).
Closes #1597
2014-08-25 10:11:38 +02:00
Matt Stancliff
2d5db1bbd1
Fix memory leak in cluster config parsing
...
The continue stop us from triggering the
free after the long line for loop, so add it
earlier.
2014-08-18 11:27:19 +02:00
Matt Stancliff
879e18b7ec
Fix memory leak in cluster config parsing
...
The continue stop us from triggering the
free after the long line for loop, so add it
earlier.
2014-08-18 11:27:19 +02:00
Matt Stancliff
132ed86ab1
Remove unused global variable
...
It has an important name, but nothing uses it...
2014-08-18 11:23:58 +02:00
Matt Stancliff
82bac1b729
Remove unused global variable
...
It has an important name, but nothing uses it...
2014-08-18 11:23:58 +02:00
antirez
8fbf4c2afa
Fix invalid expire error for SET family commands.
2014-08-18 11:15:50 +02:00
antirez
a6edfceaa8
Fix invalid expire error for SET family commands.
2014-08-18 11:15:50 +02:00
Cong Ding
ca13fbca08
Remove unused function
...
Closes #878
2014-08-18 11:12:26 +02:00
Cong Ding
18ca831830
Remove unused function
...
Closes #878
2014-08-18 11:12:26 +02:00
David Palm
027fbd6975
Extend range of bytesToHuman to TB and PB
...
Also adds a fallthrough case for when given
large values (like overflow numbers of 2^64 by mistake).
Closes #858
2014-08-18 11:11:00 +02:00
David Palm
100c3315be
Extend range of bytesToHuman to TB and PB
...
Also adds a fallthrough case for when given
large values (like overflow numbers of 2^64 by mistake).
Closes #858
2014-08-18 11:11:00 +02:00
yoav
3fc3157dc2
Add error check for writing RDB checksum
...
Closes #857
2014-08-18 11:09:06 +02:00
yoav
0a98b21f65
Add error check for writing RDB checksum
...
Closes #857
2014-08-18 11:09:06 +02:00
Dov Murik
a52ee4fd0e
redis-cli: fix prompt after shutdown command
...
Fix redis-cli prompt to state "not connected" after a SHUTDOWN command
is sent.
2014-08-18 11:05:36 +02:00
Dov Murik
233d24a737
redis-cli: fix prompt after shutdown command
...
Fix redis-cli prompt to state "not connected" after a SHUTDOWN command
is sent.
2014-08-18 11:05:36 +02:00
xiaoyu
1c63ccb119
Clarify argument to dict macro
...
d is more clear because the type of argument is dict not dictht
Closes #513
2014-08-18 10:59:01 +02:00
xiaoyu
d786fb6e94
Clarify argument to dict macro
...
d is more clear because the type of argument is dict not dictht
Closes #513
2014-08-18 10:59:01 +02:00
Matt Stancliff
ac427859ff
Clarify existing slot wording on cluster start
2014-08-18 10:58:00 +02:00
Matt Stancliff
6a7a32a806
Clarify existing slot wording on cluster start
2014-08-18 10:58:00 +02:00
antirez
ca7d9f42b3
Fix undefined behavior in ll2string().
...
The bug was found by @CAFxX, thanks!
See issue #1940 .
2014-08-15 15:48:15 +02:00
antirez
c951c3ee5a
Fix undefined behavior in ll2string().
...
The bug was found by @CAFxX, thanks!
See issue #1940 .
2014-08-15 15:48:15 +02:00
antirez
2e94ffb1d1
Remove warnings and improve integer sign correctness.
2014-08-13 11:44:38 +02:00
antirez
edca2b14d2
Remove warnings and improve integer sign correctness.
2014-08-13 11:44:38 +02:00
antirez
029a1e9e24
Add -W to compilation flags.
2014-08-13 10:53:54 +02:00
antirez
7e3ccddc6d
Add -W to compilation flags.
2014-08-13 10:53:54 +02:00
antirez
02b06ba8f0
Use unsigned integers in SDS header.
...
This raises the max string to 4GB without any downside.
2014-08-13 10:53:51 +02:00
antirez
68db7b1f56
Use unsigned integers in SDS header.
...
This raises the max string to 4GB without any downside.
2014-08-13 10:53:51 +02:00
Pieter Noordhuis
de398a534e
va_copy must be matched by va_end
...
Hat tip to @rfuchs. See: https://github.com/redis/hiredis/pull/178 .
Fixes #1187
2014-08-12 11:50:02 +02:00
Pieter Noordhuis
cf85b5ba81
va_copy must be matched by va_end
...
Hat tip to @rfuchs. See: https://github.com/redis/hiredis/pull/178 .
Fixes #1187
2014-08-12 11:50:02 +02:00
charsyam
7b0da4811e
Remove duplicate prototypes in redis.h
...
Also moves acceptHandler() to be near the other accept...() functions.
Closes #1105
2014-08-12 11:45:25 +02:00
charsyam
3426866e0a
Remove duplicate prototypes in redis.h
...
Also moves acceptHandler() to be near the other accept...() functions.
Closes #1105
2014-08-12 11:45:25 +02:00
NanXiao
50860ee720
Use resolv library in Solaris
...
For some Solaris flavours, the inet_aton in in resolv library.
Not linking this library will introduce link error.
Improves compatability with older Solaris and still
works on new Solaris.
Closes #1092
2014-08-12 11:30:46 +02:00
NanXiao
951eefae3c
Use resolv library in Solaris
...
For some Solaris flavours, the inet_aton in in resolv library.
Not linking this library will introduce link error.
Improves compatability with older Solaris and still
works on new Solaris.
Closes #1092
2014-08-12 11:30:46 +02:00
antirez
29b38e9901
representRedisNodeFlags() moved into right code section.
...
The funciton was also modified in order to be more standalone and
produce an output without trailing spaces, making the reuse simpler.
The global variable was renamed in cammel case as most other Redis
globals, except the main ones we refer too many times, like 'server'.
2014-08-08 15:53:42 +02:00
antirez
ded57795ff
representRedisNodeFlags() moved into right code section.
...
The funciton was also modified in order to be more standalone and
produce an output without trailing spaces, making the reuse simpler.
The global variable was renamed in cammel case as most other Redis
globals, except the main ones we refer too many times, like 'server'.
2014-08-08 15:53:42 +02:00
charsyam
40a90bfd7b
Refactor cluster flag printing
...
Less copy/paste code duplication.
Closes #952
2014-08-08 15:39:44 +02:00
charsyam
de5465baf7
Refactor cluster flag printing
...
Less copy/paste code duplication.
Closes #952
2014-08-08 15:39:44 +02:00
Matt Stancliff
afc81c95c0
Cleanup double semicolons
...
Closes #1161
2014-08-08 14:54:02 +02:00
Matt Stancliff
da0132638f
Cleanup double semicolons
...
Closes #1161
2014-08-08 14:54:02 +02:00
SungBin_Hong
9a8653e1e1
Free memory in clusterLoadConfig error handler
...
Closes #1327
2014-08-08 14:40:32 +02:00
SungBin_Hong
dec58464d8
Free memory in clusterLoadConfig error handler
...
Closes #1327
2014-08-08 14:40:32 +02:00
Chris Lamb
e60125fde8
redis-check-dump: Prevent segfault if can't malloc
...
Found by The Mayhem Team (Alexandre Rebert, Thanassis Avgerinos,
Sang Kil Cha, David Brumley, Manuel Egele) Cylab, Carnegie Mellon
University. See http://bugs.debian.org/716259 for more.
Signed-off-by: Chris Lamb <lamby@debian.org>
Fixes #1191
2014-08-08 14:10:34 +02:00
Chris Lamb
af62d9a687
redis-check-dump: Prevent segfault if can't malloc
...
Found by The Mayhem Team (Alexandre Rebert, Thanassis Avgerinos,
Sang Kil Cha, David Brumley, Manuel Egele) Cylab, Carnegie Mellon
University. See http://bugs.debian.org/716259 for more.
Signed-off-by: Chris Lamb <lamby@debian.org>
Fixes #1191
2014-08-08 14:10:34 +02:00
charsyam
413fd132f9
Remove unused LINE_BUFLEN definition
...
Closes #1129
2014-08-08 14:05:02 +02:00