gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
10,758 Commits 1 Branch 0 Tags
Commit Graph

10758 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Salvatore Sanfilippo
f07205e48c
Merge pull request #5709 from artix75/cluster_manager_fix_cmd 
Fixed memory leak in clusterManagerCompareKeysValues.
 2018-12-19 17:24:38 +01:00
Salvatore Sanfilippo
9b6ceafc00 Merge pull request #5709 from artix75/cluster_manager_fix_cmd 
Fixed memory leak in clusterManagerCompareKeysValues.
 2018-12-19 17:24:38 +01:00
artix
cc29590188 Fixed memory leak in clusterManagerCompareKeysValues. 2018-12-18 18:45:10 +01:00
artix
1055c6b484 Fixed memory leak in clusterManagerCompareKeysValues. 2018-12-18 18:45:10 +01:00
Salvatore Sanfilippo
0d166674f9
Merge pull request #5708 from artix75/cluster_manager_fix_cmd 
Cluster Manager: compare key values after BUSYKEY error (migration).
 2018-12-18 18:27:38 +01:00
Salvatore Sanfilippo
d54066e90f Merge pull request #5708 from artix75/cluster_manager_fix_cmd 
Cluster Manager: compare key values after BUSYKEY error (migration).
 2018-12-18 18:27:38 +01:00
artix
143bfa1e6e Cluster Manager: compare key values after BUSYKEY error (migration). 
If a key exists in the target node during a migration (BUSYKEY),
the value of the key on both nodes (source and target) will be compared.
If the key has the same value on both keys, the migration will be
automatically retried with the REPLACE argument in order to override
the target's key.

If the key has different values, the behaviour will depend on such
cases:
- In case of 'fix' command, the migration will stop and the user
  will be warned to manually check the key(s).
- In other cases (ie. reshard), if the user launched the command
  with the --cluster-replace option, the migration will be
  retried with the REPLACE argument, elsewhere the migration will
  stop and the user will be warned.
 2018-12-18 17:45:35 +01:00
artix
4ec37c3bd3 Cluster Manager: compare key values after BUSYKEY error (migration). 
If a key exists in the target node during a migration (BUSYKEY),
the value of the key on both nodes (source and target) will be compared.
If the key has the same value on both keys, the migration will be
automatically retried with the REPLACE argument in order to override
the target's key.

If the key has different values, the behaviour will depend on such
cases:
- In case of 'fix' command, the migration will stop and the user
  will be warned to manually check the key(s).
- In other cases (ie. reshard), if the user launched the command
  with the --cluster-replace option, the migration will be
  retried with the REPLACE argument, elsewhere the migration will
  stop and the user will be warned.
 2018-12-18 17:45:35 +01:00
Guy Benoish
ed88f77d6d Check server.verbosity in RM_LogRaw 2018-12-13 13:57:38 +01:00
Salvatore Sanfilippo
81008bf99e
Merge pull request #5691 from artix75/cluster_manager_fix_cmd 
Cluster Manager: avoid using reply error messages to check slot status.
 2018-12-12 13:39:53 +01:00
Salvatore Sanfilippo
46baf72ddd Merge pull request #5691 from artix75/cluster_manager_fix_cmd 
Cluster Manager: avoid using reply error messages to check slot status.
 2018-12-12 13:39:53 +01:00
artix
d935cfcb89 Cluster Manager: avoid using reply error messages to check slot status. 
Slot assignment status is now checked by using CLUSTER SLOTS.
Furthermore, one memory leak has been fixed.
 2018-12-12 13:34:43 +01:00
artix
cc21057890 Cluster Manager: avoid using reply error messages to check slot status. 
Slot assignment status is now checked by using CLUSTER SLOTS.
Furthermore, one memory leak has been fixed.
 2018-12-12 13:34:43 +01:00
antirez
009a929269 Remove debugging printf from replication.tcl test. 2018-12-12 11:55:30 +01:00
antirez
0ba9e0f8dd Remove debugging printf from replication.tcl test. 2018-12-12 11:55:30 +01:00
antirez
129f2d2746 freeMemoryIfNeeded() small refactoring. 
Related to issue #5686 and PR #5689.
 2018-12-12 11:37:15 +01:00
antirez
b166aff1bf freeMemoryIfNeeded() small refactoring. 
Related to issue #5686 and PR #5689.
 2018-12-12 11:37:15 +01:00
Salvatore Sanfilippo
7ae184bfea
Merge pull request #5689 from soloestoy/donot-evict-when-AOF-loading 
evict: don't care about mem if loading
 2018-12-12 11:29:10 +01:00
Salvatore Sanfilippo
5daed99b5c Merge pull request #5689 from soloestoy/donot-evict-when-AOF-loading 
evict: don't care about mem if loading
 2018-12-12 11:29:10 +01:00
antirez
03e2bb0cfd Crashing is too much in addReplyErrorLength(). 
See #5663.
 2018-12-11 17:50:18 +01:00
antirez
76e5519516 Crashing is too much in addReplyErrorLength(). 
See #5663.
 2018-12-11 17:50:18 +01:00
zhaozhao.zz
b9cd89d108 evict: don't care about mem if loading 
When loading data, we call processEventsWhileBlocked
to process events and execute commands.
But if we are loading AOF it's dangerous, because
processCommand would call freeMemoryIfNeeded to evict,
and that will break data consistency, see issue #5686.
 2018-12-12 00:25:58 +08:00
zhaozhao.zz
19ef3890e9 evict: don't care about mem if loading 
When loading data, we call processEventsWhileBlocked
to process events and execute commands.
But if we are loading AOF it's dangerous, because
processCommand would call freeMemoryIfNeeded to evict,
and that will break data consistency, see issue #5686.
 2018-12-12 00:25:58 +08:00
antirez
0110e46f6e Merge branch 'unstable' of github.com:/antirez/redis into unstable 2018-12-11 13:30:04 +01:00
antirez
e16d2dfb5f Merge branch 'unstable' of github.com:/antirez/redis into unstable 2018-12-11 13:30:04 +01:00
antirez
a31ca8d753 stringmatchlen() fuzz test added. 
Verified to be able to trigger at least #5632. Does not report other
issues.
 2018-12-11 13:29:30 +01:00
antirez
7c25def9a0 stringmatchlen() fuzz test added. 
Verified to be able to trigger at least #5632. Does not report other
issues.
 2018-12-11 13:29:30 +01:00
antirez
c710d4afdc Fix stringmatchlen() read past buffer bug. 
See #5632.
 2018-12-11 13:18:52 +01:00
antirez
c30b9dc868 Fix stringmatchlen() read past buffer bug. 
See #5632.
 2018-12-11 13:18:52 +01:00
Salvatore Sanfilippo
f77edf4234
Merge pull request #5665 from louiszhw/unstable 
fix comments fault discription
 2018-12-11 13:03:09 +01:00
Salvatore Sanfilippo
5106a32402 Merge pull request #5665 from louiszhw/unstable 
fix comments fault discription
 2018-12-11 13:03:09 +01:00
Salvatore Sanfilippo
e8529d1b1e
Merge pull request #4264 from lsytj0413/unstable 
fix a typo: craeted -> created
 2018-12-11 13:02:28 +01:00
Salvatore Sanfilippo
0a0dbf6027 Merge pull request #4264 from lsytj0413/unstable 
fix a typo: craeted -> created
 2018-12-11 13:02:28 +01:00
Salvatore Sanfilippo
11d399dded
Merge pull request #5684 from soloestoy/ignore-multi-cmd-flags-loading-aof 
multi: ignore multiState's cmd_flags when loading AOF
 2018-12-11 12:57:25 +01:00
Salvatore Sanfilippo
22d9e8ce65 Merge pull request #5684 from soloestoy/ignore-multi-cmd-flags-loading-aof 
multi: ignore multiState's cmd_flags when loading AOF
 2018-12-11 12:57:25 +01:00
zhaozhao.zz
6100be7d82 fix typo 2018-12-11 19:53:54 +08:00
zhaozhao.zz
3ab14c56f7 fix typo 2018-12-11 19:53:54 +08:00
zhaozhao.zz
1530c0a7dd multi: ignore multiState's cmd_flags when loading AOF 2018-12-11 19:47:36 +08:00
zhaozhao.zz
e60a8ce2f2 multi: ignore multiState's cmd_flags when loading AOF 2018-12-11 19:47:36 +08:00
antirez
274531396c Reject EXEC containing write commands against RO replica. 
Thanks to @soloestoy for discovering this issue in #5667.
This is an alternative fix in order to avoid both cycling the clients
and also disconnecting clients just having valid read-only transactions
pending.
 2018-12-11 11:39:21 +01:00
antirez
fc4b1319d0 Reject EXEC containing write commands against RO replica. 
Thanks to @soloestoy for discovering this issue in #5667.
This is an alternative fix in order to avoid both cycling the clients
and also disconnecting clients just having valid read-only transactions
pending.
 2018-12-11 11:39:21 +01:00
Salvatore Sanfilippo
086363babf
Merge pull request #5681 from artix75/cluster_manager_fix_cmd 
Cluster manager fix cmd
 2018-12-11 08:23:54 +01:00
Salvatore Sanfilippo
eaaf22a4f8 Merge pull request #5681 from artix75/cluster_manager_fix_cmd 
Cluster manager fix cmd
 2018-12-11 08:23:54 +01:00
artix
27ddb2ba3a Cluster Manager: 
- Multiple owners checking in 'fix'/'check' commands is now
  optional (using --cluster-search-multiple-owners).
- Updated help.
 2018-12-10 18:01:18 +01:00
artix
440e8164a1 Cluster Manager: 
- Multiple owners checking in 'fix'/'check' commands is now
  optional (using --cluster-search-multiple-owners).
- Updated help.
 2018-12-10 18:01:18 +01:00
artix
0c1336caf4 Cluster Manager: 
- FixOpenSlot now correctly updates in-memory cluster configuration.
    - Improved output messages.
 2018-12-10 17:43:58 +01:00
artix
17ff4e873f Cluster Manager: 
- FixOpenSlot now correctly updates in-memory cluster configuration.
    - Improved output messages.
 2018-12-10 17:43:58 +01:00
artix
1a56fc913e Cluster Manager: 'fix' command now handles open slots with migrating state 
in one node and importing state in multiple nodes.
 2018-12-10 17:43:58 +01:00
artix
c2ea297052 Cluster Manager: 'fix' command now handles open slots with migrating state 
in one node and importing state in multiple nodes.
 2018-12-10 17:43:58 +01:00
artix
d5f7703367 Cluster Manager: setting new slot owner is now handled atomically 
in 'fix' command.
 2018-12-10 17:43:58 +01:00