Itamar Haber
863e969675
Adds HELP to LATENCY
...
Signed-off-by: Itamar Haber <itamar@redislabs.com>
2018-11-02 22:58:16 +02:00
Salvatore Sanfilippo
da62ac4bb7
Merge pull request #5511 from gkorland/patch-1
...
Fix some typos
2018-10-31 16:36:12 +01:00
Guy Korland
d923a4ae6b
Fix some typos
2018-10-31 17:33:53 +02:00
antirez
d1d9140540
Add support for Sentinel authentication.
...
So far it was not possible to setup Sentinel with authentication
enabled. This commit introduces this feature: every Sentinel will try to
authenticate with other sentinels using the same password it is
configured to accept clients with.
So for instance if a Sentinel has a "requirepass" configuration
statemnet set to "foo", it will use the "foo" password to authenticate
with every other Sentinel it connects to. So basically to add the
"requirepass" to all the Sentinels configurations is enough in order to
make sure that:
1) Clients will require the password to access the Sentinels instances.
2) Each Sentinel will use the same password to connect and authenticate
with every other Sentinel in the group.
Related to #3279 and #3329 .
2018-10-31 12:56:47 +01:00
antirez
13405529ab
Disable protected mode in Sentinel mode.
...
Sentinel must be exposed, so protected mode is just an issue for users
in case Redis was started in Sentinel mode.
Related to #3279 and #3329 .
2018-10-31 12:37:48 +01:00
antirez
2e14b6bbca
When replica kills a pending RDB save during SYNC, log it.
...
This logs what happens in the context of the fix in PR #5367 .
2018-10-31 11:47:10 +01:00
Salvatore Sanfilippo
2a5ac7ad88
Merge pull request #5367 from nUl1/fullresync-stopbgsave
...
Prevent RDB autosave from overwriting full resync results
2018-10-31 11:42:04 +01:00
David Carlier
04e1d8c1cb
Merge branch 'clang_build_fix_warnings' of https://github.com/devnexen/redis into clang_build_fix_warnings
2018-10-31 09:53:25 +00:00
David Carlier
185a0ac62a
tweak form feedback
2018-10-31 09:53:07 +00:00
David Carlier
d4820638da
allow flavors
2018-10-30 21:41:49 +00:00
David Carlier
131df0d757
allow flavors
2018-10-30 14:38:05 +00:00
David Carlier
8d5748a0bb
Fix clang build.
...
Some math functions require c11 standard.
2018-10-30 13:23:43 +00:00
antirez
5789a7ef6d
asyncCloseClientOnOutputBufferLimitReached(): don't free fake clients.
...
Fake clients are used in special situations and are not linked to the
normal clients list, freeing them will always result in Redis crashing
in one way or the other.
It's not common to send replies to fake clients, but we have one usage
in the modules API. When a client is blocked, we associate to the
blocked client object (that is safe to manipulate in a thread), a fake
client that accumulates replies. So because of this bug there was
the problem described in issue #5443 .
The fix was verified to work with the provided example module. To write
a regression is very hard and unlikely to be triggered in the future.
2018-10-30 13:38:41 +01:00
Salvatore Sanfilippo
495e508614
Merge pull request #5489 from devnexen/unstable
...
Fix non Linux build.
2018-10-29 18:25:14 +01:00
David Carlier
977556fa5b
needs it for the global
2018-10-26 14:12:47 +00:00
David Carlier
a2cc07cad4
Fix non Linux build.
...
timezone global is a linux-ism whereas it is a function under BSD.
Here a helper to get the timezone value in a more portable manner.
2018-10-26 14:02:09 +00:00
antirez
efa96f0648
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 13:08:58 +02:00
antirez
75672bff45
Add command fingerprint comment for XSETID.
2018-10-25 13:08:48 +02:00
Salvatore Sanfilippo
50f68bcbdf
Merge pull request #5454 from soloestoy/multi-oom
...
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-25 13:00:19 +02:00
antirez
f37fa5f7d6
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 11:50:15 +02:00
Salvatore Sanfilippo
4aa2ff5840
Merge pull request #5459 from itamarhaber/xpending_count_underflow
...
A fix to XPENDING's count underflow
2018-10-25 11:50:04 +02:00
antirez
c02aeee147
Fix XRANGE COUNT option for value of 0.
2018-10-25 11:36:24 +02:00
antirez
3df187410f
Fix typo in streamReplyWithRange() top comment.
2018-10-24 16:28:44 +02:00
Salvatore Sanfilippo
6f79cc62e6
Merge pull request #5469 from soloestoy/stat-key-miss-if-expired
...
if we read a expired key, misses++
2018-10-24 12:31:28 +02:00
Salvatore Sanfilippo
f588805a52
Merge pull request #5453 from damz/pr/aof-buffer-evict
...
Overhead is the allocated size of the AOF buffer, not its length
2018-10-24 12:28:28 +02:00
antirez
5f8d96699d
Simplify part of the #5470 patch.
2018-10-24 12:26:27 +02:00
Salvatore Sanfilippo
0f4e72fb8d
Merge pull request #5470 from soloestoy/keys-no-trigger-expire
...
do not delete expired keys in KEYS command
2018-10-24 12:23:59 +02:00
antirez
63787d5cbc
Use guide comments to make changes in #5462 more obvious.
2018-10-22 17:43:48 +02:00
antirez
9389de6304
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-22 17:41:43 +02:00
Salvatore Sanfilippo
409ada78c1
Merge pull request #5462 from youjiali1995/fix-migrate-expired-keys
...
migrate: fix mismatch of RESTORE reply when some keys have expired.
2018-10-22 17:40:37 +02:00
antirez
5f9de96d2f
Remove useless complexity from MSET implementation.
2018-10-22 12:24:02 +02:00
Salvatore Sanfilippo
d1e9aa4b56
Merge pull request #5451 from hujiecs/unstable
...
several typos fixed, optimize MSETNX to avoid unnecessary loop
2018-10-22 12:17:08 +02:00
hujie
f96dbdf0ab
fix typo in config.c
2018-10-21 10:37:36 +08:00
hujie
2cf0ab76fd
fix typo
2018-10-20 12:18:56 +08:00
zhaozhao.zz
2906ba5b5c
if we read a expired key, misses++
2018-10-19 18:16:29 +08:00
zhaozhao.zz
357909d7dd
do not delete expired keys in KEYS command
2018-10-19 18:00:57 +08:00
antirez
196555bf26
Fix again stack generation on the Raspberry Pi.
...
The fix was removed by f6627a3e6 attempting to fix the stack generation
on ARM64, without testing if it would still work on ARM32.
Now it should work both sides.
2018-10-19 10:39:57 +02:00
youjiali1995
e29c6573b9
migrate: fix mismatch of RESTORE reply when some keys have expired.
2018-10-18 18:57:51 +08:00
Itamar Haber
fbc22b4d21
Plugs a potential underflow
2018-10-17 19:33:11 +03:00
antirez
fc0e7b5e88
Streams: use bulk replies instead of status replies.
...
They play better with Lua scripting, otherwise Lua will see status
replies as "ok" = "string" which is very odd, and actually as @oranagra
reasoned in issue #5456 in the rest of the Redis code base there was no
such concern as saving a few bytes when the protocol is emitted.
2018-10-17 17:21:09 +02:00
Itamar Haber
ce6c8730a0
Corrects inline documentation of syntax
2018-10-17 16:13:55 +03:00
antirez
60f84c7776
Fix conditional in XGROUP.
2018-10-17 13:00:35 +02:00
antirez
f130bb13f0
Update help.h for redis-cli.
2018-10-17 12:57:21 +02:00
antirez
de887c7e1d
Tests for XGROUP CREATE MKSTREAM.
2018-10-17 12:11:10 +02:00
antirez
182e83b5c7
Fix XGROUP CREATE MKSTREAM handling of .
2018-10-17 12:10:52 +02:00
antirez
9a0cdbd59d
Process MKSTREAM option of XGROUP CREATE at a later time.
...
This avoids issues with having to replicate a command that produced
errors.
2018-10-17 12:04:06 +02:00
antirez
6e6f322ee5
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-17 11:36:03 +02:00
antirez
34a57904f0
XGROUP CREATE: MKSTREAM option for automatic stream creation.
2018-10-17 11:27:27 +02:00
zhaozhao.zz
549b9142f6
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-17 16:40:45 +08:00
Salvatore Sanfilippo
9388517487
Merge pull request #5333 from soloestoy/stream-commands-flag
...
Scripting & Streams: some commands need right flags
2018-10-17 07:50:32 +02:00