antirez
3b4fdf36c4
Be more verbose when DEBUG RESTART fails.
2017-11-30 18:08:21 +01:00
zhaozhao.zz
2f98aa2d83
networking: optimize unlinkClient() in freeClient()
2017-11-30 18:11:05 +08:00
zhaozhao.zz
3b2be172fa
aof: cast sdslen to ssize_t
2017-11-30 10:27:12 +08:00
zhaozhao.zz
9393e49ee9
aof: fix the short write
2017-11-30 10:22:12 +08:00
Itamar Haber
5252d3d8ea
Check arity in SLOWLOG before accessing arg
2017-11-30 00:30:30 +02:00
antirez
e7313e4372
Merge branch 'lfu-fixes' into unstable
2017-11-29 17:16:13 +01:00
Itamar Haber
b8275f187e
Merge branch 'unstable' into help_subcommands
2017-11-28 21:28:40 +02:00
Itamar Haber
50ce8124a3
Standardizes the 'help' subcommand
...
This adds a new `addReplyHelp` helper that's used by commands
when returning a help text. The following commands have been
touched: DEBUG, OBJECT, COMMAND, PUBSUB, SCRIPT and SLOWLOG.
WIP
Fix entry command table entry for OBJECT for HELP option.
After #4472 the command may have just 2 arguments.
Improve OBJECT HELP descriptions.
See #4472 .
WIP 2
WIP 3
2017-11-28 21:15:45 +02:00
Salvatore Sanfilippo
0a3a92d180
Merge pull request #4200 from jeesyn/fix_typo
...
fix a typo
2017-11-28 18:44:11 +01:00
Salvatore Sanfilippo
47951a1d1d
Merge pull request #4165 from zyegfryed/patch-1
...
Fix some typos
2017-11-28 18:43:45 +01:00
Salvatore Sanfilippo
ad06aea258
Merge pull request #4166 from charpty/wip-redisclic-typo
...
redis-cli.c typo: helpe -> helper.
2017-11-28 18:41:51 +01:00
Salvatore Sanfilippo
8f1404310d
Merge pull request #4167 from charpty/wip-redisclic-typo2
...
redis-cli.c typo: Requets -> Requests.
2017-11-28 18:41:28 +01:00
Salvatore Sanfilippo
0e1c37fc8c
Merge pull request #4170 from TehWebby/patch-2
...
Fix typo
2017-11-28 18:40:43 +01:00
Salvatore Sanfilippo
3cae56b866
Merge pull request #4172 from TehWebby/patch-3
...
Fix typo
2017-11-28 18:40:02 +01:00
Salvatore Sanfilippo
0679f760ff
Merge pull request #4176 from KrauseFx/patch-1
...
Update link to https and use inline link
2017-11-28 18:39:43 +01:00
antirez
6d91878a23
t_hash.c: clarify calling two times the same function.
2017-11-28 18:39:00 +01:00
antirez
38adb13962
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2017-11-28 18:27:35 +01:00
antirez
8862e64771
adlist: fix listJoin() in the case the second list is empty.
...
See #4192 , the original PR removed lines of code that are actually
needed, so thanks to @chunqiulfq for reporting the problem, but merging
solution from @jeesyn after checking, together with @artix75, that the
logic covers all the cases.
2017-11-28 18:25:14 +01:00
Salvatore Sanfilippo
2afb6b3b5b
Merge pull request #4215 from lamby/correct-faield-spelling
...
Correct spelling of "faield".
2017-11-28 18:08:32 +01:00
Salvatore Sanfilippo
534c013ae9
Merge pull request #4374 from rouzier/patch-1
...
Fix file descriptor leak and error handling
2017-11-28 17:33:23 +01:00
Salvatore Sanfilippo
51695bb3f8
Merge pull request #4451 from devnexen/minor_build_fixes
...
Fix undefined behavior constant defined.
2017-11-28 17:23:48 +01:00
Itamar Haber
c6d2fd3d4e
Standardizes arity handling of DEBUG
2017-11-28 18:18:45 +02:00
antirez
94b7095366
LFU: Fix LFUDecrAndReturn() to just decrement.
...
Splitting the popularity in half actually just needs decrementing the
counter because the counter is logarithmic.
2017-11-28 12:18:30 +01:00
zhaozhao.zz
472f3a4ff7
LFU: add hotkeys option to redis-cli
2017-11-27 18:39:29 +01:00
zhaozhao.zz
22950a6284
LFU: do some changes about LFU to find hotkeys
...
Firstly, use access time to replace the decreas time of LFU.
For function LFUDecrAndReturn,
it should only try to get decremented counter,
not update LFU fields, we will update it in an explicit way.
And we will times halve the counter according to the times of
elapsed time than server.lfu_decay_time.
Everytime a key is accessed, we should update the LFU
including update access time, and increment the counter after
call function LFUDecrAndReturn.
If a key is overwritten, the LFU should be also updated.
Then we can use `OBJECT freq` command to get a key's frequence,
and LFUDecrAndReturn should be called in `OBJECT freq` command
in case of the key has not been accessed for a long time,
because we update the access time only when the key is read or
overwritten.
2017-11-27 18:39:22 +01:00
zhaozhao.zz
ac4614a079
LFU: change lfu* parameters to int
2017-11-27 18:38:55 +01:00
zhaozhao.zz
d78a701b20
LFU: fix the missing of config get and rewrite
2017-11-27 18:38:33 +01:00
antirez
02aafda9af
Improve OBJECT HELP descriptions.
...
See #4472 .
2017-11-27 18:09:08 +01:00
antirez
f00eeb8cac
Fix entry command table entry for OBJECT for HELP option.
...
After #4472 the command may have just 2 arguments.
2017-11-27 13:16:07 +01:00
Salvatore Sanfilippo
05c596e1a3
Merge pull request #4472 from itamarhaber/object_patch
...
A minor fix and `help` subcommand for `OBJECT`
2017-11-27 12:41:02 +01:00
Itamar Haber
e3019b7e13
Adds -u <uri> option to redis-cli.
2017-11-27 11:34:11 +01:00
Itamar Haber
fc5c3bdd1b
Adds OBJECT help
2017-11-24 19:59:05 +02:00
Itamar Haber
b9329a2959
Prevents OBJECT freq
with noeviction
...
When maxmemory is set to noeviction, idletime is implicitly kept. This renders access frequency nonsensical.
2017-11-24 19:58:37 +02:00
antirez
1dc952210a
Test: regression test for latency expire events logging bug.
...
Regression for #4452 .
2017-11-24 18:33:31 +01:00
Salvatore Sanfilippo
75c9fd6c51
Merge pull request #4452 from soloestoy/expire-latency
...
expire & latency: fix the missing latency records generated by expire
2017-11-24 18:21:35 +01:00
antirez
78c28a5a54
Modules: fix memory leak in RM_IsModuleNameBusy().
2017-11-24 13:29:54 +01:00
antirez
2ed2fb7f25
PSYNC2: reorganize comments related to recent fixes.
...
Related to PR #4412 and issue #4407 .
2017-11-24 11:08:29 +01:00
Salvatore Sanfilippo
acfece8854
Merge pull request #4412 from soloestoy/bugfix-psync2
...
PSYNC2: safe free backlog when reach the time limit and others
2017-11-24 10:56:18 +01:00
Salvatore Sanfilippo
8fa2ab29d8
Merge pull request #4344 from soloestoy/fix-module-name-conflict
...
Fix module name conflict
2017-11-24 09:37:06 +01:00
Salvatore Sanfilippo
3781bb3ade
Merge pull request #4470 from oranagra/fix_string_to_double
...
fix string to double conversion, stopped parsing on \0 …
2017-11-24 08:59:23 +01:00
Oran Agra
43a17cc78d
fix string to double conversion, stopped parsing on \0 even if the string has more data.
...
getLongLongFromObject calls string2ll which has this line:
/* Return if not all bytes were used. */
so if you pass an sds with 3 characters "1\01" it will fail.
but getLongDoubleFromObject calls strtold, and considers it ok if eptr[0]==`\0`
i.e. if the end of the string found by strtold ends with null terminator
127.0.0.1:6379> set a 1
OK
127.0.0.1:6379> setrange a 2 2
(integer) 3
127.0.0.1:6379> get a
"1\x002"
127.0.0.1:6379> incrbyfloat a 2
"3"
127.0.0.1:6379> get a
"3"
2017-11-23 17:15:27 +02:00
antirez
c2097bc95c
Modules: fix for scripting replication of modules commands.
...
See issue #4466 / #4467 .
2017-11-23 15:14:17 +01:00
Salvatore Sanfilippo
7db576f8c8
Merge pull request #4467 from yossigo/fix-nested-multi
...
Nested MULTI/EXEC may replicate in different cases.
2017-11-23 13:38:43 +01:00
Yossi Gottlieb
4902e26fef
Nested MULTI/EXEC may replicate in different cases.
...
For example:
1. A module command called within a MULTI section.
2. A Lua script with replicate_commands() called within a MULTI section.
3. A module command called from a Lua script in the above context.
2017-11-22 22:02:51 +02:00
zhaozhao.zz
1e4dbdd0a1
PSYNC2: persist cached_master's dbid inside the RDB
2017-11-22 12:11:26 +08:00
zhaozhao.zz
07842aaaab
PSYNC2: make repl_stream_db never be -1
...
it means that after this change all the replication
info in RDB is valid, and it can distinguish us from
the older version.
2017-11-22 12:05:34 +08:00
zhaozhao.zz
167330153a
expire & latency: fix the missing latency records generated by expire
2017-11-21 23:35:30 +08:00
zhaozhao.zz
084b3f3cba
rehash: handle one db until finished
2017-11-21 09:49:42 +01:00
David Carlier
b65d8172ae
Fix undefined behavior constant defined.
2017-11-19 16:23:42 +00:00
Salvatore Sanfilippo
4278b57cd3
Merge pull request #2741 from kmiku7/unstable
...
fix boundary case for _dictNextPower
2017-11-08 17:06:09 +01:00