Oran Agra
10e71b3d01
Optimize temporary memory allocations for getKeysFromCommand mechanism
...
now that we may use it more often (ACL), these excessive calls to malloc
and free can become an overhead.
2020-03-05 12:51:14 +01:00
antirez
edc0ed1415
Modules: reformat RM_Scan() top comment a bit.
2020-03-05 12:51:14 +01:00
antirez
c5319612b4
Modules: more details in RM_Scan API top comment.
2020-03-05 12:51:14 +01:00
Oran Agra
fff6b26ae3
RM_Scan disable dict rehashing
...
The callback approach we took is very efficient, the module can do any
filtering of keys without building any list and cloning strings, it can
also read data from the key's value. but if the user tries to re-open
the key, or any other key, this can cause dict re-hashing (dictFind does
that), and that's very bad to do from inside dictScan.
this commit protects the dict from doing any rehashing during scan, but
also warns the user not to attempt any writes or command calls from
within the callback, for fear of unexpected side effects and crashes.
2020-03-05 12:51:14 +01:00
Guy Benoish
650484604c
Add RM_CreateStringFromDouble
2020-03-05 12:51:14 +01:00
Oran Agra
3144a278dd
add no_auth to COMMAND INFO
2020-03-05 12:51:14 +01:00
Oran Agra
afe0b16c02
module api docs for aux_save and aux_load
2020-03-05 12:51:14 +01:00
Guy Benoish
df152b0ce7
streamReplyWithRangeFromConsumerPEL: Redundant streamDecodeID
2020-03-05 12:51:14 +01:00
antirez
e3c1f43952
Show Redis version when not understanding a config directive.
...
This makes simpler to give people help when posting such kind of errors
in the mailing list or other help forums, because sometimes the
directive looks well spelled, but the version of Redis they are using is
not able to support it.
2020-03-05 12:51:14 +01:00
John Sully
0114827642
Fix CLANG build break
...
Former-commit-id: 5e63c0955d2861ab0ebe2055d4f2d2e8989ea4f3
2020-03-04 17:24:17 -05:00
John Sully
09f08908e2
Fix CLANG build break
...
Former-commit-id: e523afa7410399697659106c88e9f65e2cffae79
2020-03-04 17:24:00 -05:00
John Sully
b3e33daf7d
Fix CLANG build break
...
Former-commit-id: c2a98a60f964f28455a5d04e18b88a9a45c9e586
2020-03-04 17:23:40 -05:00
John Sully
2833febaa5
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 6bc92d6d3182970ebe64184d5be9108321182218
2020-03-04 17:13:50 -05:00
John Sully
43befe9985
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: 13cf8bbeb7b96e771620cf79dacba9b63cd31591
2020-03-04 17:13:32 -05:00
John Sully
3dbe23f513
Add missing files from last checkin
...
Former-commit-id: 60c0d4104de3ff904758c200342e4d132b19501c
2020-03-04 17:13:18 -05:00
John Sully
a669a40ac6
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 52fd4445a472fa3112e96c6a7ef66ecdfe6ce9f5
2020-03-04 17:13:01 -05:00
John Sully
6a254a8d39
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: 693ba4ed4ad2fe3f9190b8dc8ca5f940d02baf51
2020-03-04 17:09:29 -05:00
John Sully
de2b08c3f8
Add extra logging when reporting errors from masters - especially in rreplay
...
Former-commit-id: 5397f0b03312b8cace07a85333d8f035bdfb8d57
2020-03-04 17:09:12 -05:00
John Sully
21fb601851
MOTD refactor
...
Former-commit-id: 6c78ec7c41223b3381e19fdf78478f66b4959dc9
2020-03-04 16:22:55 -05:00
John Sully
bffd982853
min-clients-per-thread needs to use the new config code
...
Former-commit-id: fed4bd5269a95a24f99d4542ceece09b9ad66d2c
2020-03-04 15:14:41 -05:00
John Sully
53a66f6a72
Update README.md
...
Former-commit-id: c0882864f2fff0a32899e983ad4fe060eb71c1ad
2020-03-03 13:58:48 -08:00
John Sully
529b860f85
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 1a7e2e663e0ebabdf51ec8b6bd50d8a4c8a611c8
2020-03-01 21:48:51 -05:00
John Sully
a6a0400b86
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: faa87ed8393c9f020ba85da1d30f81bca4cf8202
2020-03-01 21:43:21 -05:00
John Sully
de3d796eb7
Update tests to reflect new CRON name (keydb.cron)
...
Former-commit-id: 83f585e30ab9d37408c79b74e2536664325a051f
2020-03-01 21:42:01 -05:00
benschermel
7785fa981a
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: 7a244bb847491f992e15c4e9c55473ffd734a8ec
2020-03-01 19:53:32 -05:00
John Sully
0648930af4
Rename cron command to KEYDB.CRON and add help
...
Former-commit-id: 1b925119b5ad24ab3a91763bf9f4633f5bc9fef4
2020-03-01 19:18:21 -05:00
John Sully
765ffea018
Rename cron command to KEYDB.CRON and add help
...
Former-commit-id: 3eb847e28f6df45528dcebc6761290ff60248e78
2020-03-01 19:17:58 -05:00
John Sully
d5ed6f1b5e
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 9dc8f30e4783d7e2e9749b155f6bf3df57c536a7
2020-02-28 23:56:26 -05:00
John Sully
ef291b246e
Bump version
...
Former-commit-id: 3ce6441a0c0f5c58f31f5fa28116cea09aebbf35
2020-02-28 23:53:54 -05:00
John Sully
42b6305fbc
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: 6d00a1a5cf86f69bc9204973adb67a4e215260bd
2020-02-28 23:53:00 -05:00
John Sully
ec4eb534d7
Fix compile failure on raspberry pi machines, issue #141
...
Former-commit-id: aaca32a5cd1bdb0314b4a57847938854b8a4fef2
2020-02-28 23:49:17 -05:00
John Sully
f68f3d0d14
Fix not respecting max clients config, issue #147
...
Former-commit-id: 54c96d19954fbddcfd2a307e436ca3290c76e0fb
2020-02-28 22:04:42 -05:00
John Sully
1db49c5897
Fix issue #146
...
Former-commit-id: e5a2d594464a965f36e4cbf924f02929265186e6
2020-02-28 21:21:05 -05:00
antirez
141c0679a0
Changelog: explain Redis 6 SPOP change.
2020-02-27 18:04:34 +01:00
Hengjian Tang
973297336f
modify the read buf size according to the write buf size PROTO_IOBUF_LEN defined before
2020-02-27 18:02:30 +01:00
bodong.ybd
fe902461f4
Fix spop return nil #4709
2020-02-27 18:02:30 +01:00
Ariel
15ea13245a
fix ThreadSafeContext lock/unlock function names
2020-02-27 18:02:30 +01:00
antirez
9d4219ebac
Fix SDS misuse in enumConfigSet(). Related to #6778 .
2020-02-27 18:02:30 +01:00
Guy Benoish
4d12c37c54
XREADGROUP should propagate XCALIM/SETID in MULTI/EXEC
...
Use built-in alsoPropagate mechanism that wraps commands
in MULTI/EXEC before sending them to replica/AOF
2020-02-27 18:02:30 +01:00
antirez
8424306433
Remove useless comment from enumConfigSet().
2020-02-27 18:02:30 +01:00
Oran Agra
12626ce9bb
fix race in module api test for fork
...
in some cases we were trying to kill the fork before it got created
2020-02-27 18:02:30 +01:00
Ponnuvel Palaniyappan
dafb94db79
Fix a potential overflow with strncpy
2020-02-27 18:02:30 +01:00
Guy Benoish
2ecab0b63a
Modules: Do not auto-unblock clients if not blocked on keys
2020-02-27 18:02:30 +01:00
antirez
ea697b6345
Improve aeDeleteEventLoop() top comment grammar.
2020-02-27 18:02:30 +01:00
Oran Agra
635321d47e
fix github actions failing latency test for active defrag - part 2
...
it seems that running two clients at a time is ok too, resuces action
time from 20 minutes to 10. we'll use this for now, and if one day it
won't be enough we'll have to run just the sensitive tests one by one
separately from the others.
this commit also fixes an issue with the defrag test that appears to be
very rare.
2020-02-27 18:02:30 +01:00
wangyuan21
dd4798802c
free time event when delete eventloop
2020-02-27 18:02:30 +01:00
Oran Agra
0b988fa9ec
fix github actions failing latency test for active defrag
...
seems that github actions are slow, using just one client to reduce
false positives.
also adding verbose, testing only on latest ubuntu, and building on
older one.
when doing that, i can reduce the test threshold back to something saner
2020-02-27 18:02:30 +01:00
srzhao
ecf3b2ef32
fix impl of aof-child whitelist SIGUSR1 feature.
2020-02-27 18:02:30 +01:00
Oran Agra
60096bc1a1
Fix latency sensitivity of new defrag test
...
I saw that the new defag test for list was failing in CI recently, so i
reduce it's threshold from 12 to 60.
besides that, i add / improve the latency test for that other two defrag
tests (add a sensitive latency and digest / save checks)
and fix bad usage of debug populate (can't overrides existing keys).
this was the original intention, which creates higher fragmentation.
2020-02-27 18:02:30 +01:00
meir@redislabs.com
2966132c52
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-27 18:02:30 +01:00