hwware
74778c8a01
add check for not switching between optin optout mode directly
2020-04-07 16:52:04 +02:00
hwware
02cfb2cb1d
add check for not providing both optin optout flag
2020-04-07 16:52:04 +02:00
Guy Benoish
6e5efbf918
PERSIST should notify a keyspace event
2020-04-07 16:52:04 +02:00
Guy Benoish
f1ed8d93a0
Fix memory corruption in moduleHandleBlockedClients
...
By using a "circular BRPOPLPUSH"-like scenario it was
possible the get the same client on db->blocking_keys
twice (See comment in moduleTryServeClientBlockedOnKey)
The fix was actually already implememnted in
moduleTryServeClientBlockedOnKey but it had a bug:
the funxction should return 0 or 1 (not OK or ERR)
Other changes:
1. Added two commands to blockonkeys.c test module (To
reproduce the case described above)
2. Simplify blockonkeys.c in order to make testing easier
3. cast raxSize() to avoid warning with format spec
2020-04-07 16:52:03 +02:00
antirez
b4a9ff11e1
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-04-07 14:10:43 +02:00
antirez
45d7fcec22
Speedup INFO by counting client memory incrementally.
...
Related to #5145 .
Design note: clients may change type when they turn into replicas or are
moved into the Pub/Sub category and so forth. Moreover the recomputation
of the bytes used is problematic for obvious reasons: it changes
continuously, so as a conservative way to avoid accumulating errors,
each client remembers the contribution it gave to the sum, and removes
it when it is freed or before updating it with the new memory usage.
2020-04-07 12:07:54 +02:00
Salvatore Sanfilippo
00c6ab858f
Merge pull request #7064 from mymilkbottles/unstable
...
Optimize lua log level judgment
2020-04-06 17:34:14 +02:00
Salvatore Sanfilippo
7aa3dc86f5
Merge pull request #7065 from qetu3790/unstable
...
fix comments about RESIZE DB opcode in rdb.c
2020-04-06 17:32:44 +02:00
antirez
1bbe60eab8
Clarify redis.conf comment about lazyfree-lazy-user-del.
2020-04-06 17:32:04 +02:00
Salvatore Sanfilippo
a58de4cff0
Merge pull request #6243 from soloestoy/expand-lazy-free-server-del
...
lazyfree: add a new configuration lazyfree-lazy-user-del
2020-04-06 17:27:39 +02:00
qetu3790
84979cadf6
fix comments about RESIZE DB opcode in rdb.c
...
fix comments about RESIZE DB opcode in rdb.c
2020-04-06 20:52:32 +08:00
antirez
f543150d0b
Merge branch 'lcs' into unstable
2020-04-06 13:51:55 +02:00
antirez
9cd8e2d749
LCS: more tests.
2020-04-06 13:51:49 +02:00
antirez
d48eb1bbe5
LCS: allow KEYS / STRINGS to be anywhere.
...
Initially they needed to be at the end so that we could extend to N
strings in the future, but after further consideration I no longer
believe it's worth it.
2020-04-06 13:48:31 +02:00
antirez
2f1c1ffa0b
LCS tests.
2020-04-06 13:45:37 +02:00
mymilkbottles
acee342f2f
Merge pull request #1 from mymilkbottles/mymilkbottles-log-level-judge
...
Optimize lua log level judgment
2020-04-06 19:34:07 +08:00
antirez
73b3c87eb1
LCS: get rid of STOREIDX option. Fix get keys helper.
2020-04-06 13:32:15 +02:00
mymilkbottles
22905bae98
Judge the log level in advance
2020-04-06 19:27:06 +08:00
Salvatore Sanfilippo
60251ac868
Merge pull request #6797 from patpatbear/issue_#6565_memory_borderline
...
Check OOM at script start to get stable lua OOM state.
2020-04-06 11:59:01 +02:00
Salvatore Sanfilippo
61aee6a5e0
Merge pull request #7063 from oranagra/oran-runtest-external
...
diffrent fix for runtest --host --port
2020-04-06 11:47:35 +02:00
Oran Agra
98208c3f30
diffrent fix for runtest --host --port
2020-04-06 09:41:14 +03:00
John Sully
a0447f23ac
Fix failure to AUTH with master when masterauth is set last
...
Former-commit-id: 3fdc8608f35b9e333a1c789b039d16722a6ceef5
2020-04-06 01:24:59 -04:00
John Sully
9b2392107c
Add the ability to set a starting core # when setting thread affinity
...
Former-commit-id: 9e2e2067c6df5919f1c6b8b9e6e3457c7edc0755
2020-04-04 22:58:17 -04:00
John Sully
a6444c8ce9
Fix issue #164
...
Former-commit-id: f112c77fcc3a60277ce344478bc37adb0fe4a99d
2020-04-04 22:45:12 -04:00
John Sully
bf93e32e7e
Role command protocol corruption with multiple masters
...
Former-commit-id: 888d69a87a0076caa5b381d2531a6a638aa69051
2020-04-04 22:32:15 -04:00
John Sully
2684a266c8
Fix subkey expires not replicating correctly, and AOF issues
...
Former-commit-id: bd183cdee13081a02efef5df75edf2292b872a16
2020-04-04 21:52:27 -04:00
Salvatore Sanfilippo
516484c09d
Merge pull request #7051 from guybe7/sleep_in_blockonkeys_tests
...
Try to fix time-sensitive tests in blockonkey.tcl
2020-04-03 14:12:31 +02:00
Salvatore Sanfilippo
ba7ed1013e
Merge pull request #7057 from guybe7/fix_attr_gnuc
...
Use __attribute__ only if __GNUC__ is defined
2020-04-03 13:52:24 +02:00
Guy Benoish
0529bc185a
Try to fix time-sensitive tests in blockonkey.tcl
...
There is an inherent race between the deferring client and the
"main" client of the test: While the deferring client issues a blocking
command, we can't know for sure that by the time the "main" client
tries to issue another command (Usually one that unblocks the deferring
client) the deferring client is even blocked...
For lack of a better choice this commit uses TCL's 'after' in order
to give some time for the deferring client to issues its blocking
command before the "main" client does its thing.
This problem probably exists in many other tests but this commit
tries to fix blockonkeys.tcl
2020-04-03 14:51:45 +03:00
Guy Benoish
d03bc20d25
Use __attribute__ only if __GNUC__ is defined
2020-04-03 14:49:40 +03:00
Salvatore Sanfilippo
5af170c517
Merge pull request #6855 from guybe7/var_funcs_format_check
...
Modules: Perform printf-like format checks in variadic API
2020-04-03 13:46:27 +02:00
Guy Benoish
032cf29e87
Modules: Perform printf-like format checks in variadic API
2020-04-03 14:39:55 +03:00
Salvatore Sanfilippo
d07c340a58
Merge pull request #7030 from valentinogeron/xread-in-lua
...
XREAD and XREADGROUP should not be allowed from scripts when BLOCK op…
2020-04-03 11:14:13 +02:00
Salvatore Sanfilippo
036b54b820
Merge pull request #6933 from guybe7/multi_exec_allow_stale
...
Stale replica should allow MULTI/EXEC
2020-04-03 11:12:58 +02:00
Salvatore Sanfilippo
a861736343
Merge pull request #7055 from zxdvd/patch-1
...
fix integer overflow
2020-04-03 11:10:26 +02:00
antirez
689c3f7678
LCS: fix stale comment.
2020-04-02 21:17:31 +02:00
Salvatore Sanfilippo
86c11714f0
Merge pull request #7054 from guybe7/fix_neg_zero_test
...
Fix no-negative-zero test
2020-04-02 20:00:51 +02:00
Salvatore Sanfilippo
9a64bcf30a
Merge pull request #6694 from oranagra/signal_modified_key
...
modules don't signalModifiedKey in setKey() since that's done (optionally) in RM_CloseKey
2020-04-02 19:00:20 +02:00
Xudong Zhang
f2fd46e5d3
fix integer overflow
2020-04-02 23:43:47 +08:00
Guy Benoish
74daccece3
Fix no-negative-zero test
2020-04-02 18:41:29 +03:00
Guy Benoish
7894a37841
Stale replica should allow MULTI/EXEC
...
Example: Client uses a pipe to send the following to a
stale replica:
MULTI
.. do something ...
DISCARD
The replica will reply the MUTLI with -MASTERDOWN and
execute the rest of the commands... A client using a
pipe might not be aware that MULTI failed until it's
too late.
I can't think of a reason why MULTI/EXEC/DISCARD should
not be executed on stale replicas...
Also, enable MULTI/EXEC/DISCARD during loading
2020-04-02 18:23:59 +03:00
Salvatore Sanfilippo
1cd2266fbc
Merge pull request #6927 from oranagra/ci-moduleapi-tests
...
change CI to build and run the module api tests
2020-04-02 16:32:41 +02:00
Salvatore Sanfilippo
4ff2041c94
Merge pull request #6654 from oranagra/fix_module_info_warning
...
fix possible warning on incomplete struct init
2020-04-02 16:32:20 +02:00
Salvatore Sanfilippo
ee34e741f0
Merge pull request #6546 from guybe7/fix_neg_zero
...
Make sure Redis does not reply with negative zero
2020-04-02 16:26:57 +02:00
Salvatore Sanfilippo
9588b79207
Merge pull request #6813 from guybe7/debug_object_pass_keyname
...
DEBUG OBJECT should pass keyname to module when loading
2020-04-02 16:20:48 +02:00
antirez
424facd7a1
LCS: output LCS len as well in IDX mode.
2020-04-02 16:15:17 +02:00
antirez
a9954197aa
LCS: MINMATCHLEN and WITHMATCHLEN options.
2020-04-02 13:37:35 +02:00
Salvatore Sanfilippo
b6298bd112
Merge pull request #6960 from devnexen/debug_arm_linux
...
debug, dump registers on arm too.
2020-04-02 11:26:08 +02:00
Salvatore Sanfilippo
590954ae02
Merge pull request #7006 from hwware/fixspelling
...
fix spelling in cluster.c clusterDelNode
2020-04-02 11:23:53 +02:00
Salvatore Sanfilippo
079cf0ece4
Merge pull request #7029 from valentinogeron/fix-xack
...
XACK should be executed in a "all or nothing" fashion.
2020-04-02 11:23:23 +02:00