gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,324 Commits 1 Branch 0 Tags
Commit Graph

7514 Commits

Author SHA1 Message Date
antirez
159347cef1 Use a less aggressive query buffer resize policy. 
A user with many connections (10 thousand) on a single Redis server
reports in issue #4983 that sometimes Redis is idle becuase at the same
time many clients need to resize their query buffer according to the old
policy.

It looks like this was created by the fact that we allow the query
buffer to grow without problems to a size up to PROTO_MBULK_BIG_ARG
normally, but when the client is idle we immediately are more strict,
and a query buffer greater than 1024 bytes is already enough to trigger
the resize. So for instance if most of the clients stop at the same time
this issue should be easily triggered.

This behavior actually looks odd, and there should be only a clear limit
after we say, let's look at this query buffer to check if it's time to
resize it. This commit puts the limit at PROTO_MBULK_BIG_ARG, and the
check is performed both if compared to the peak usage the current usage
is too big, or if the client is idle.

Then when the check is performed, to waste just a few kbytes is
considered enough to proceed with the resize. This should fix the issue.
 2018-06-11 17:12:28 +02:00
antirez
5bbb00fbb4 Merge branch 'unstable' of github.com:/antirez/redis into unstable 2018-06-11 16:52:45 +02:00
antirez
10c4c45137 Merge branch 'unstable' of github.com:/antirez/redis into unstable 2018-06-11 16:52:45 +02:00
antirez
34bd44187a Fix client unblocking for XREADGROUP, issue #4978. 
We unblocked the client too early, when the group name object was no
longer valid in client->bpop, so propagating XCLAIM later in
streamPropagateXCLAIM() deferenced a field already set to NULL.
 2018-06-11 16:51:06 +02:00
antirez
e2f96f3eab Fix client unblocking for XREADGROUP, issue #4978. 
We unblocked the client too early, when the group name object was no
longer valid in client->bpop, so propagating XCLAIM later in
streamPropagateXCLAIM() deferenced a field already set to NULL.
 2018-06-11 16:51:06 +02:00
Salvatore Sanfilippo
ba2101738d
Merge pull request #5000 from shenlongxing/fix-config 
fix integer case error
 2018-06-11 16:34:26 +02:00
Salvatore Sanfilippo
d762172729 Merge pull request #5000 from shenlongxing/fix-config 
fix integer case error
 2018-06-11 16:34:26 +02:00
Salvatore Sanfilippo
5db262b623
Merge pull request #5002 from soloestoy/streams-read-or-write 
Streams: lookupKey[Read->Write]OrReply in xdel and xtrim
 2018-06-11 16:33:10 +02:00
Salvatore Sanfilippo
b578ab0bf4 Merge pull request #5002 from soloestoy/streams-read-or-write 
Streams: lookupKey[Read->Write]OrReply in xdel and xtrim
 2018-06-11 16:33:10 +02:00
Salvatore Sanfilippo
e2a9ea0405
Merge pull request #4901 from KFilipek/zmalloc_typo_fix 
HW_PHYSMEM typo in preprocessor condition
 2018-06-11 16:32:40 +02:00
Salvatore Sanfilippo
f49b7e0d1d Merge pull request #4901 from KFilipek/zmalloc_typo_fix 
HW_PHYSMEM typo in preprocessor condition
 2018-06-11 16:32:40 +02:00
Salvatore Sanfilippo
295db9ee0a
Merge pull request #5003 from soloestoy/streams-checkType 
Streams: checkType for xread & xinfo
 2018-06-11 16:32:00 +02:00
Salvatore Sanfilippo
e54b49ac4c Merge pull request #5003 from soloestoy/streams-checkType 
Streams: checkType for xread & xinfo
 2018-06-11 16:32:00 +02:00
zhaozhao.zz
b8913ce721 Streams: checkType for xread & xinfo 2018-06-11 01:17:52 +08:00
zhaozhao.zz
83bb4a0dff Streams: checkType for xread & xinfo 2018-06-11 01:17:52 +08:00
zhaozhao.zz
cc81c6f1d3 Streams: lookupKey[Read->Write]OrReply in xdel and xtrim 2018-06-11 00:14:17 +08:00
zhaozhao.zz
b47471880d Streams: lookupKey[Read->Write]OrReply in xdel and xtrim 2018-06-11 00:14:17 +08:00
michael-grunder
c04082cf13 Abort in XGROUP if the key is not a stream 2018-06-10 08:55:58 -07:00
michael-grunder
efcc676b0b Abort in XGROUP if the key is not a stream 2018-06-10 08:55:58 -07:00
Itamar Haber
e654b68d1f
Merge branch 'unstable' into module_command_help 2018-06-09 21:10:53 +03:00
Itamar Haber
8a2eca39ce Merge branch 'unstable' into module_command_help 2018-06-09 21:10:53 +03:00
Itamar Haber
fefde6e3e4 Capitalizes subcommands & orders lexicographically 2018-06-09 21:03:52 +03:00
Itamar Haber
4ef817295e Capitalizes subcommands & orders lexicographically 2018-06-09 21:03:52 +03:00
Itamar Haber
21ef0376fe
Capitalizes subscommands 2018-06-09 20:54:05 +03:00
Itamar Haber
4502f10789 Capitalizes subscommands 2018-06-09 20:54:05 +03:00
shenlongxing
1210dd8a20 fix integer case error 2018-06-09 22:24:33 +08:00
shenlongxing
6e6c13123e fix integer case error 2018-06-09 22:24:33 +08:00
Salvatore Sanfilippo
be899b824e
Merge pull request #4519 from soloestoy/zset-int-problem 
Zset int problem
 2018-06-08 12:45:11 +02:00
Salvatore Sanfilippo
b7df488618 Merge pull request #4519 from soloestoy/zset-int-problem 
Zset int problem
 2018-06-08 12:45:11 +02:00
Salvatore Sanfilippo
5ebaadc96b
Merge pull request #4800 from soloestoy/dict-expand 
adjust position of _dictNextPower in dictExpand
 2018-06-08 12:32:18 +02:00
Salvatore Sanfilippo
980969ec59 Merge pull request #4800 from soloestoy/dict-expand 
adjust position of _dictNextPower in dictExpand
 2018-06-08 12:32:18 +02:00
Salvatore Sanfilippo
9fa2e7020e
Merge pull request #4861 from soloestoy/rdb-dict-expand 
RDB: expand dict if needed when rdb load object
 2018-06-08 12:12:34 +02:00
Salvatore Sanfilippo
5ff23db284 Merge pull request #4861 from soloestoy/rdb-dict-expand 
RDB: expand dict if needed when rdb load object
 2018-06-08 12:12:34 +02:00
antirez
269e80526f Implement DEBUG htstats-key. 2018-06-08 11:17:20 +02:00
antirez
d2c353280e Implement DEBUG htstats-key. 2018-06-08 11:17:20 +02:00
antirez
97e1f6812c Merge branch 'unstable' of github.com:/antirez/redis into unstable 2018-06-08 11:02:30 +02:00
antirez
08da518c19 Merge branch 'unstable' of github.com:/antirez/redis into unstable 2018-06-08 11:02:30 +02:00
antirez
2268d7e5dd redis-cli inline help updated. 2018-06-07 18:53:00 +02:00
antirez
52e4b9eda3 redis-cli inline help updated. 2018-06-07 18:53:00 +02:00
Salvatore Sanfilippo
66c6218a3c
Merge pull request #4977 from michael-grunder/xpending-early-return 
Return early in XPENDING if sent a nonexistent consumer group.
 2018-06-07 18:49:09 +02:00
Salvatore Sanfilippo
ac0b8125e0 Merge pull request #4977 from michael-grunder/xpending-early-return 
Return early in XPENDING if sent a nonexistent consumer group.
 2018-06-07 18:49:09 +02:00
Itamar Haber
c199280edb Globally applies addReplySubSyntaxError 2018-06-07 18:39:36 +03:00
Itamar Haber
594dc58322 Globally applies addReplySubSyntaxError 2018-06-07 18:39:36 +03:00
Itamar Haber
76ad23d012 Adds MODULE HELP and implements addReplySubSyntaxError 2018-06-07 18:34:58 +03:00
Itamar Haber
041354e665 Adds MODULE HELP and implements addReplySubSyntaxError 2018-06-07 18:34:58 +03:00
antirez
a7dbe37d53 Typo: entires -> entries in several places. 2018-06-07 14:36:56 +02:00
antirez
664cfb8d6b Typo: entires -> entries in several places. 2018-06-07 14:36:56 +02:00
antirez
dfb3bf1b1e Streams: make macro node limits configurable. 2018-06-07 14:36:13 +02:00
antirez
5c7bda3752 Streams: make macro node limits configurable. 2018-06-07 14:36:13 +02:00
antirez
6d34ff3645 Streams: max node limits only checked if non zero. 2018-06-07 14:30:25 +02:00