gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,264 Commits 1 Branch 0 Tags
Commit Graph

20863 Commits

Author SHA1 Message Date
杨博东
cbaf3c5bba
Fix flock cluster config may cause failure to restart after kill -9 (#7674) 
After fork, the child process(redis-aof-rewrite) will get the fd opened
by the parent process(redis), when redis killed by kill -9, it will not
graceful exit(call prepareForShutdown()), so redis-aof-rewrite thread may still
alive, the fd(lock) will still be held by redis-aof-rewrite thread, and
redis restart will fail to get lock, means fail to start.

This issue was causing failures in the cluster tests in github actions.

Co-authored-by: Oran Agra <oran@redislabs.com>
 2020-08-20 08:59:02 +03:00
Raghav Muddur
f7cf24b5da Update clusterMsgDataPublish to clusterMsgModule (#7682) 
Correcting the variable to clusterMsgModule.
 2020-08-19 19:13:32 -07:00
Raghav Muddur
34c3be365a
Update clusterMsgDataPublish to clusterMsgModule (#7682) 
Correcting the variable to clusterMsgModule.
 2020-08-19 19:13:32 -07:00
Madelyn Olson
17c6b3c7ee Fixed hset error since it's shared with hmset (#7678) 2020-08-19 19:07:43 -07:00
Madelyn Olson
cbd9af8583
Fixed hset error since it's shared with hmset (#7678) 2020-08-19 19:07:43 -07:00
Wang Yuan
77155c4744 Add comments on 'slave.repldboff' when use diskless replication (#7679) 2020-08-19 10:52:53 +03:00
Wang Yuan
89d544d6f2
Add comments on 'slave.repldboff' when use diskless replication (#7679) 2020-08-19 10:52:53 +03:00
guybe7
64cceb12ad PERSIST should signalModifiedKey (Like EXPIRE does) (#7671) 2020-08-18 19:07:59 +03:00
guybe7
b87c288016
PERSIST should signalModifiedKey (Like EXPIRE does) (#7671) 2020-08-18 19:07:59 +03:00
Oran Agra
1b5cc94836 OOM Crash log include size of allocation attempt. (#7670) 
Since users often post just the crash log in github issues, the log
print that's above it is missing.
No reason not to include the size in the panic message itself.
 2020-08-18 09:53:59 +03:00
Oran Agra
0f741a9e2d
OOM Crash log include size of allocation attempt. (#7670) 
Since users often post just the crash log in github issues, the log
print that's above it is missing.
No reason not to include the size in the panic message itself.
 2020-08-18 09:53:59 +03:00
Wen Hui
3962f80bd7 edit auth failed message (#7648) 
Edit auth failed message include user disabled case in hello command
 2020-08-18 08:59:24 +03:00
Wen Hui
88662c243d
edit auth failed message (#7648) 
Edit auth failed message include user disabled case in hello command
 2020-08-18 08:59:24 +03:00
Wen Hui
b7236f0002 [module] using predefined REDISMODULE_NO_EXPIRE in RM_GetExpire (#7669) 
It was already defined in the API header and the documentation, but not used by the implementation.
 2020-08-18 08:50:03 +03:00
Wen Hui
93d87d6d4c
[module] using predefined REDISMODULE_NO_EXPIRE in RM_GetExpire (#7669) 
It was already defined in the API header and the documentation, but not used by the implementation.
 2020-08-18 08:50:03 +03:00
Oran Agra
05a4af3464 Trim trailing spaces in error replies coming from rejectCommand (#7668) 
fe8d6fe749 added rejectCommand which takes an robj reply and passes it
through addReplyErrorSafe to addReplyErrorLength.
The robj contains newline at it's end, but addReplyErrorSafe converts it
to spaces, and passes it to addReplyErrorLength which adds the protocol
newlines.

The result was that most error replies (like OOM) had extra two trailing
spaces in them.
 2020-08-18 08:28:43 +03:00
Oran Agra
cdd925b289
Trim trailing spaces in error replies coming from rejectCommand (#7668) 
65a3307bc9 added rejectCommand which takes an robj reply and passes it
through addReplyErrorSafe to addReplyErrorLength.
The robj contains newline at it's end, but addReplyErrorSafe converts it
to spaces, and passes it to addReplyErrorLength which adds the protocol
newlines.

The result was that most error replies (like OOM) had extra two trailing
spaces in them.
 2020-08-18 08:28:43 +03:00
Yossi Gottlieb
2ec11f941a Module API: fix missing RM_CLIENTINFO_FLAG_SSL. (#7666) 
The `REDISMODULE_CLIENTINFO_FLAG_SSL` flag was already a part of the `RedisModuleClientInfo` structure but was not implemented.
 2020-08-17 17:46:54 +03:00
Yossi Gottlieb
64c360c515
Module API: fix missing RM_CLIENTINFO_FLAG_SSL. (#7666) 
The `REDISMODULE_CLIENTINFO_FLAG_SSL` flag was already a part of the `RedisModuleClientInfo` structure but was not implemented.
 2020-08-17 17:46:54 +03:00
Yossi Gottlieb
24efd22e89 TLS: relax verification on CONFIG SET. (#7665) 
Avoid re-configuring (and validating) SSL/TLS configuration on `CONFIG
SET` when TLS is not actively enabled for incoming connections, cluster
bus or replication.

This fixes failures when tests run without `--tls` on binaries that were
built with TLS support.

An additional benefit is that it's now possible to perform a multi-step
configuration process while TLS is disabled. The new configuration will
be verified and applied only when TLS is effectively enabled.
 2020-08-17 17:36:50 +03:00
Yossi Gottlieb
fb2a94af3f
TLS: relax verification on CONFIG SET. (#7665) 
Avoid re-configuring (and validating) SSL/TLS configuration on `CONFIG
SET` when TLS is not actively enabled for incoming connections, cluster
bus or replication.

This fixes failures when tests run without `--tls` on binaries that were
built with TLS support.

An additional benefit is that it's now possible to perform a multi-step
configuration process while TLS is disabled. The new configuration will
be verified and applied only when TLS is effectively enabled.
 2020-08-17 17:36:50 +03:00
John Sully
dcf607622c Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: ed98be0ba81ffdc501847ea0d2486f5f01391319
 2020-08-17 02:26:51 +00:00
John Sully
7beb3401cf Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: ed98be0ba81ffdc501847ea0d2486f5f01391319
 2020-08-17 02:26:51 +00:00
John Sully
e8e7061a73 Fast cleanup of snapshots without leaving them forever 
Former-commit-id: fdd83b2b49244ed2988b080892ee5cffe9fd2684
 2020-08-17 00:33:37 +00:00
John Sully
035cde502a Fast cleanup of snapshots without leaving them forever 
Former-commit-id: fdd83b2b49244ed2988b080892ee5cffe9fd2684
 2020-08-17 00:33:37 +00:00
John Sully
c0586b3aed Allow garbage collection of generic data 
Former-commit-id: feadb7fb1845027422bcfca43dbcb6097409b8dc
 2020-08-17 00:32:48 +00:00
John Sully
b71f16471b Allow garbage collection of generic data 
Former-commit-id: feadb7fb1845027422bcfca43dbcb6097409b8dc
 2020-08-17 00:32:48 +00:00
John Sully
00934cd341 Add snapshot depth to info string 
Former-commit-id: 66aef678e9d6d7ab6c28622d54ada0ea8cdd2a99
 2020-08-16 00:27:10 +00:00
John Sully
e97e4f1a35 Add snapshot depth to info string 
Former-commit-id: 66aef678e9d6d7ab6c28622d54ada0ea8cdd2a99
 2020-08-16 00:27:10 +00:00
John Sully
4a356ac13f Don't try and consolidate snapshots with a depth of 1 
Former-commit-id: 26c298bd9bc4e2c6981de5c20284120ea54580c3
 2020-08-16 00:26:05 +00:00
John Sully
6ba6652fcf Don't try and consolidate snapshots with a depth of 1 
Former-commit-id: 26c298bd9bc4e2c6981de5c20284120ea54580c3
 2020-08-16 00:26:05 +00:00
John Sully
3093d9e117 Only save MVCC tstamps if its an active replica 
Former-commit-id: 5aded7dbad055308dc3932f7797fc71684b60966
 2020-08-16 00:24:18 +00:00
John Sully
c3365964a0 Only save MVCC tstamps if its an active replica 
Former-commit-id: 5aded7dbad055308dc3932f7797fc71684b60966
 2020-08-16 00:24:18 +00:00
John Sully
cf4e74006f Don't free snapshot objects in a critical path (under the AE lock) 
Former-commit-id: d0da3d3cb74334cc8a2d14f4bdaef7935181700a
 2020-08-16 00:13:19 +00:00
John Sully
71506d7e0a Don't free snapshot objects in a critical path (under the AE lock) 
Former-commit-id: d0da3d3cb74334cc8a2d14f4bdaef7935181700a
 2020-08-16 00:13:19 +00:00
John Sully
311b286d41 BUG: Cannot have an EMBSTR bigger than 255 
Former-commit-id: e2d6e2d9d585cb7a73f469a8580f9cb0ec71a429
 2020-08-15 23:30:22 +00:00
John Sully
e946e5f907 BUG: Cannot have an EMBSTR bigger than 255 
Former-commit-id: e2d6e2d9d585cb7a73f469a8580f9cb0ec71a429
 2020-08-15 23:30:22 +00:00
John Sully
82989540c4 remove unnecessary allocation in rdb save 
Former-commit-id: dfa76f04fd862e0cc7b4d3284b3922e3a5e5549d
 2020-08-15 23:27:32 +00:00
John Sully
2268a2b761 remove unnecessary allocation in rdb save 
Former-commit-id: dfa76f04fd862e0cc7b4d3284b3922e3a5e5549d
 2020-08-15 23:27:32 +00:00
John Sully
ce69a765f8 Remove unnecessary key comparisons in perf critical snapshot paths 
Former-commit-id: 40f8a8d102fdca9443399ef03a47df609b146d58
 2020-08-15 23:25:58 +00:00
John Sully
a14b2097c3 Remove unnecessary key comparisons in perf critical snapshot paths 
Former-commit-id: 40f8a8d102fdca9443399ef03a47df609b146d58
 2020-08-15 23:25:58 +00:00
John Sully
1055543817 dictMerge perf improvements 
Former-commit-id: 48401ec369c5693689ef658cca518dc94ab1402e
 2020-08-15 23:14:29 +00:00
John Sully
0311011131 dictMerge perf improvements 
Former-commit-id: 48401ec369c5693689ef658cca518dc94ab1402e
 2020-08-15 23:14:29 +00:00
John Sully
eb572c57e2 Rehash efficiency 
Former-commit-id: fab383156626ec683881101c22eb2f6c2cea4c5d
 2020-08-15 23:05:56 +00:00
John Sully
34937b0ad5 Rehash efficiency 
Former-commit-id: fab383156626ec683881101c22eb2f6c2cea4c5d
 2020-08-15 23:05:56 +00:00
John Sully
6c6ca43eef Prevent unnecessary copy when overwriting a value from a snapshot 
Former-commit-id: 654a7bc6ea82f4ac45a1c1a25c794e1c27c0d902
 2020-08-15 22:59:01 +00:00
John Sully
07c019fd3d Prevent unnecessary copy when overwriting a value from a snapshot 
Former-commit-id: 654a7bc6ea82f4ac45a1c1a25c794e1c27c0d902
 2020-08-15 22:59:01 +00:00
John Sully
c804b28446 Merge branch 'unstable' into keydbpro 
Former-commit-id: ae482585f0dc470efd73833f74111c2f87a172c5
 2020-08-15 21:29:00 +00:00
John Sully
db193a1ef1 Merge branch 'unstable' into keydbpro 
Former-commit-id: ae482585f0dc470efd73833f74111c2f87a172c5
 2020-08-15 21:29:00 +00:00
michael-grunder
3db28bfe68 Use Hiredis' sdscompat.h to map sds* calls to hi_sds* 2020-08-15 13:13:23 -07:00