futriix

gvsafronov/futriix

Fork 0

Commit Graph

Author	SHA1	Message	Date
Guy Benoish	c4dc5b80b2	Fix memory corruption in moduleHandleBlockedClients By using a "circular BRPOPLPUSH"-like scenario it was possible the get the same client on db->blocking_keys twice (See comment in moduleTryServeClientBlockedOnKey) The fix was actually already implememnted in moduleTryServeClientBlockedOnKey but it had a bug: the funxction should return 0 or 1 (not OK or ERR) Other changes: 1. Added two commands to blockonkeys.c test module (To reproduce the case described above) 2. Simplify blockonkeys.c in order to make testing easier 3. cast raxSize() to avoid warning with format spec	2020-04-01 12:53:26 +03:00
Guy Benoish	d7d13721d3	Modules: Fix blocked-client-related memory leak If a blocked module client times-out (or disconnects, unblocked by CLIENT command, etc.) we need to call moduleUnblockClient in order to free memory allocated by the module sub-system and blocked-client private data Other changes: Made blockedonkeys.tcl tests a bit more aggressive in order to smoke-out potential memory leaks	2019-12-30 10:10:59 +05:30
Guy Benoish	b81f486c2f	Modules: Test RedisModule_BlockClientOnKeys	2019-11-04 14:20:24 +05:30

Author

SHA1

Message

Date

Guy Benoish

c4dc5b80b2

Fix memory corruption in moduleHandleBlockedClients

By using a "circular BRPOPLPUSH"-like scenario it was
possible the get the same client on db->blocking_keys
twice (See comment in moduleTryServeClientBlockedOnKey)

The fix was actually already implememnted in
moduleTryServeClientBlockedOnKey but it had a bug:
the funxction should return 0 or 1 (not OK or ERR)

Other changes:
1. Added two commands to blockonkeys.c test module (To
   reproduce the case described above)
2. Simplify blockonkeys.c in order to make testing easier
3. cast raxSize() to avoid warning with format spec

2020-04-01 12:53:26 +03:00

Guy Benoish

d7d13721d3

Modules: Fix blocked-client-related memory leak

If a blocked module client times-out (or disconnects, unblocked
by CLIENT command, etc.) we need to call moduleUnblockClient
in order to free memory allocated by the module sub-system
and blocked-client private data

Other changes:
Made blockedonkeys.tcl tests a bit more aggressive in order
to smoke-out potential memory leaks

2019-12-30 10:10:59 +05:30

Guy Benoish

b81f486c2f

Modules: Test RedisModule_BlockClientOnKeys

2019-11-04 14:20:24 +05:30

3 Commits