gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,534 Commits 1 Branch 0 Tags
Commit Graph

14534 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
srzhao
38f6207f88 Check OOM at script start to get stable lua OOM state. 
Checking OOM by `getMaxMemoryState` inside script might get different result
with `freeMemoryIfNeededAndSafe` at script start, because lua stack and
arguments also consume memory.

This leads to memory `borderline` when memory grows near server.maxmemory:

- `freeMemoryIfNeededAndSafe` at script start detects no OOM, no memory freed
- `getMaxMemoryState` inside script detects OOM, script aborted

We solve this 'borderline' issue by saving OOM state at script start to get
stable lua OOM state.

related to issue #6565 and #5250.
 2020-01-20 21:34:05 +08:00
antirez
721a39ddff Document I/O threads in redis.conf. 2020-01-17 10:47:38 +01:00
antirez
cbabf779c2 Simplify #6379 changes. 2020-01-17 10:47:38 +01:00
antirez
ecd17e819c Jump to right label on AOF parsing error. 
Related to #6054.
 2020-01-17 10:47:38 +01:00
antirez
8e9d19bc65 Change error message for #6775. 2020-01-17 10:47:38 +01:00
antirez
5be3a15a82 Setting N I/O threads should mean N-1 additional + 1 main thread. 2020-01-17 10:47:38 +01:00
WuYunlong
658749cc54 Free allocated sds in pfdebugCommand() to avoid memory leak. 2020-01-17 10:47:38 +01:00
antirez
1927932b43 Port PR #6110 to new connection object code. 2020-01-17 10:47:38 +01:00
Vasyl Melnychuk
ba146d4c09 Make error when submitting command in incorrect context more explicit 
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
 2020-01-17 10:47:38 +01:00
WuYunlong
47988c9666 Fix potential memory leak of clusterLoadConfig(). 2020-01-17 10:47:38 +01:00
antirez
f2df5773b1 A few comments about main thread serving I/O as well. 
Related to #6110.
 2020-01-17 10:47:38 +01:00
WuYunlong
cc90f79baf Fix potential memory leak of rioWriteBulkStreamID(). 2020-01-17 10:47:38 +01:00
zhaozhao.zz
b3ff8a4b6d Threaded IO: use main thread to handle read work 2020-01-17 10:47:38 +01:00
zhaozhao.zz
b1f2c51037 Threaded IO: use main thread to handle write work 2020-01-17 10:47:38 +01:00
srzhao
dd05b7f67f fix impl of aof-child whitelist SIGUSR1 feature. 2020-01-17 11:50:51 +08:00
hwware
67ee87522a format fix 2020-01-16 17:35:26 -05:00
hwware
3f6d00d387 fix potentical memory leaks 2020-01-16 17:33:23 -05:00
antirez
7ef2270ee7 Change error message for #6775. 2020-01-15 17:55:24 +01:00
Salvatore Sanfilippo
456bbc02c8
Merge pull request #6775 from SqREL/make-error-of-invalid-command-withing-context-explicit 
Make error when submitting command in incorrect context more explicit
 2020-01-15 17:53:51 +01:00
Ponnuvel Palaniyappan
1d4ea00d12 Fix a potential overflow with strncpy 2020-01-14 08:10:39 +00:00
Ponnuvel Palaniyappan
abf8150b2e Fix typos in README.md 2020-01-14 07:38:57 +00:00
antirez
2d7dc71b6f Document I/O threads in redis.conf. 2020-01-13 19:10:42 +01:00
antirez
7d5fb5df3f Setting N I/O threads should mean N-1 additional + 1 main thread. 2020-01-13 18:53:36 +01:00
antirez
28d146bed6 Simplify #6379 changes. 2020-01-13 13:25:37 +01:00
Salvatore Sanfilippo
9506c860f6
Merge pull request #6739 from trevor211/fixMemoryLeak 
Fix potential memory leak of rioWriteBulkStreamID().
 2020-01-13 13:23:49 +01:00
antirez
baa88a1c14 Jump to right label on AOF parsing error. 
Related to #6054.
 2020-01-13 13:16:15 +01:00
antirez
d28948b143 Port PR #6110 to new connection object code. 2020-01-13 12:54:39 +01:00
antirez
a8c912ead6 A few comments about main thread serving I/O as well. 
Related to #6110.
 2020-01-13 12:50:26 +01:00
Salvatore Sanfilippo
24896427fc
Merge pull request #6110 from soloestoy/enhance-io-threaded 
Enhance IO Threaded: use main thread to handle read/write work
 2020-01-13 12:46:40 +01:00
John Sully
f412fff0c6 Fix build break for X64 
Former-commit-id: 76590fdce3ccf7bf3124832f6034c31caf7a8269
 2020-01-12 01:28:30 -05:00
John Sully
d2e3836dd9 Merge branch 'keydbpro' of https://github.com/JohnSully/KeyDB-Pro into keydbpro 
Former-commit-id: 4f39ca139f15a5f585f829937a46a56f20644db0
 2020-01-12 01:27:22 -05:00
John Sully
1a70e322dd Fix snapshot consolidation bugs and reduce log noise 
Former-commit-id: 7f3cb2981529277d3f02dceb2f60e7aa8385847d
 2020-01-12 01:22:44 -05:00
John Sully
bddcdd856e remove debug printfs 
Former-commit-id: 3dbd455321e4a2ee47a24662e164eac0e5614965
 2020-01-12 01:20:52 -05:00
John Sully
7a6085742d Merge branch 'moar_perf' into keydbpro_moarperf 
Former-commit-id: d0990a465c3c5c29b71f239d84a875af40699281
 2020-01-11 22:06:20 -05:00
John Sully
4360d1ab3d Avoid locking as late as possible 
Former-commit-id: acc894fe41d4e8869f28928cb0feffa1792c11c4
 2020-01-11 19:28:13 -05:00
John Sully
ac55fe6dac Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable 
Former-commit-id: 762396d997b4e155778ba62346376b37b4673154
 2020-01-11 16:35:06 -05:00
John Sully
e942999159 Avoid crash due to excessive posted functions for AOF rewrite 
Former-commit-id: c575e7df9408ad7bd66ac7a104a38e841d525681
 2020-01-11 16:34:30 -05:00
John Sully
74fcfc0b7f Avoid crash due to excessive posted functions for AOF rewrite 
Former-commit-id: aa6409f2e8a37288eb4953fbcf3a82e02545348b
 2020-01-11 16:34:09 -05:00
John Sully
6c0f148468 Merge branch 'unstable' into RELEASE_5 
Former-commit-id: e603e57588d040f96876d6b281a3867a8db53f6a
 2020-01-10 17:46:23 -05:00
John Sully
831528e8e4 Ignore other flags after pro is enabled since we won't understand them 
Former-commit-id: 049b48ef79fdde4c9b1c9f227a329bd9223e2b1d
 2020-01-10 17:46:02 -05:00
Vasyl Melnychuk
b5f52bf01c Make error when submitting command in incorrect context more explicit 
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
 2020-01-10 23:34:15 +02:00
John Sully
8a52788844 Update README.md 
Former-commit-id: 0ba0a6ab0a2c552e17a4344f9935b40f26c694e1
 2020-01-10 14:21:11 -05:00
John Sully
ce7dd77830 Update graphs 
Former-commit-id: 7475ea1b0b7d8b2f7a8dfb6c6b754126d5160e5b
 2020-01-10 14:19:44 -05:00
ShooterIT
7bbafc5639 Rename rdb asynchronously 2020-01-10 13:16:25 +01:00
Leo Murillo
c7f752667e Fix bug on KEYS command where pattern starts with * followed by \x00 (null char). 2020-01-10 13:16:25 +01:00
Jamie Scott
ed7ea13a2a Update to directive in redis.conf (missing s) 
The directive tls-prefer-server-cipher is actually tls-prefer-server-ciphers in config.c. This results in a failed directive call shown below. This pull request adds the "s" in ciphers so that the directive is able to be properly called in config.c

ubuntu@ip-172-31-16-31:~/redis$ src/redis-server ./redis.conf 

*** FATAL CONFIG FILE ERROR ***
Reading the configuration file, at line 200
>>> 'tls-prefer-server-cipher yes'
Bad directive or wrong number of arguments
 2020-01-10 13:16:25 +01:00
antirez
3be7762388 Free fakeclient argv on AOF error. 
We exit later, so no bug fixed, but it is more correct.

See #6054, thanks to @ShooterIT for finding the issue.
 2020-01-10 13:16:25 +01:00
antirez
15f6b74814 Git ignore: ignore more files. 2020-01-10 13:16:14 +01:00
Guy Benoish
1b5bf40c20 Blocking XREAD[GROUP] should always reply with valid data (or timeout) 
This commit solves the following bug:
127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM
OK
127.0.0.1:6379> XADD x 666 f v
"666-0"
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
   2) 1) 1) "666-0"
         2) 1) "f"
            2) "v"
127.0.0.1:6379> XADD x 667 f v
"667-0"
127.0.0.1:6379> XDEL x 667
(integer) 1
127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
1) 1) "x"
   2) (empty array)

The root cause is that we use s->last_id in streamCompareID
while we should use the last *valid* ID
 2020-01-10 13:16:14 +01:00
John Sully
954c20edd9 Add support for incremental build with header files 2020-01-10 13:16:14 +01:00